From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
Cc: balbi@kernel.org, gregkh@linuxfoundation.org, agross@kernel.org,
linux-usb@vger.kernel.org, linux-arm-msm@vger.kernel.org,
wcheng@codeaurora.org
Subject: Re: [PATCH 2/2] usb: dwc3: dwc3-qcom: Fix typo in the dwc3 vbus override API
Date: Tue, 29 Jun 2021 10:51:55 -0500 [thread overview]
Message-ID: <YNtBm2AKYaSziRXf@yoga> (raw)
In-Reply-To: <20210629144449.2550737-3-bryan.odonoghue@linaro.org>
On Tue 29 Jun 09:44 CDT 2021, Bryan O'Donoghue wrote:
> From: Wesley Cheng <wcheng@codeaurora.org>
>
> There was an extra character in the dwc3_qcom_vbus_override_enable()
> function. Removed the extra character.
>
> Signed-off-by: Wesley Cheng <wcheng@codeaurora.org>
> Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
But I think you should have sent the two patches in opposite order,
because this could have been merged, but now it depends on patch 1.
Regards,
Bjorn
> ---
> drivers/usb/dwc3/dwc3-qcom.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/usb/dwc3/dwc3-qcom.c b/drivers/usb/dwc3/dwc3-qcom.c
> index 4491704503ab..541e2626294a 100644
> --- a/drivers/usb/dwc3/dwc3-qcom.c
> +++ b/drivers/usb/dwc3/dwc3-qcom.c
> @@ -120,7 +120,7 @@ static inline void dwc3_qcom_clrbits(void __iomem *base, u32 offset, u32 val)
> readl(base + offset);
> }
>
> -static void dwc3_qcom_vbus_overrride_enable(struct dwc3_qcom *qcom, bool enable)
> +static void dwc3_qcom_vbus_override_enable(struct dwc3_qcom *qcom, bool enable)
> {
> if (enable) {
> dwc3_qcom_setbits(qcom->qscratch_base, QSCRATCH_SS_PHY_CTRL,
> @@ -141,7 +141,7 @@ static int dwc3_qcom_vbus_notifier(struct notifier_block *nb,
> struct dwc3_qcom *qcom = container_of(nb, struct dwc3_qcom, vbus_nb);
>
> /* enable vbus override for device mode */
> - dwc3_qcom_vbus_overrride_enable(qcom, event);
> + dwc3_qcom_vbus_override_enable(qcom, event);
> qcom->mode = event ? USB_DR_MODE_PERIPHERAL : USB_DR_MODE_HOST;
>
> return NOTIFY_DONE;
> @@ -153,7 +153,7 @@ static int dwc3_qcom_host_notifier(struct notifier_block *nb,
> struct dwc3_qcom *qcom = container_of(nb, struct dwc3_qcom, host_nb);
>
> /* disable vbus override in host mode */
> - dwc3_qcom_vbus_overrride_enable(qcom, !event);
> + dwc3_qcom_vbus_override_enable(qcom, !event);
> qcom->mode = event ? USB_DR_MODE_HOST : USB_DR_MODE_PERIPHERAL;
>
> return NOTIFY_DONE;
> @@ -329,7 +329,7 @@ static int dwc3_qcom_usb_role_switch_set(struct usb_role_switch *sw,
>
> qcom->mode = (role == USB_ROLE_HOST) ? USB_DR_MODE_HOST :
> USB_DR_MODE_PERIPHERAL;
> - dwc3_qcom_vbus_overrride_enable(qcom, enable);
> + dwc3_qcom_vbus_override_enable(qcom, enable);
> return 0;
> }
>
> @@ -917,7 +917,7 @@ static int dwc3_qcom_probe(struct platform_device *pdev)
>
> /* enable vbus override for device mode */
> if (qcom->mode == USB_DR_MODE_PERIPHERAL)
> - dwc3_qcom_vbus_overrride_enable(qcom, true);
> + dwc3_qcom_vbus_override_enable(qcom, true);
>
> if (dwc3_qcom_find_usb_connector(pdev)) {
> ret = dwc3_qcom_setup_role_switch(qcom);
> --
> 2.30.1
>
prev parent reply other threads:[~2021-06-29 15:52 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-29 14:44 [PATCH 0/2] dwc3-qcom: Prepare the ground for pm8150b tcpm Bryan O'Donoghue
2021-06-29 14:44 ` [PATCH 1/2] usb: dwc3: dwc3-qcom: Find USB connector and register role switch Bryan O'Donoghue
2021-06-29 15:48 ` Bjorn Andersson
2021-06-29 19:23 ` Bryan O'Donoghue
2021-06-29 20:02 ` Jack Pham
2021-06-29 20:16 ` Bryan O'Donoghue
2021-06-29 20:30 ` Bjorn Andersson
2021-06-29 21:57 ` Bryan O'Donoghue
2021-06-30 2:21 ` Bryan O'Donoghue
2021-07-01 1:12 ` Jack Pham
2021-07-01 2:08 ` Bryan O'Donoghue
2021-06-29 20:18 ` Bjorn Andersson
2021-06-29 14:44 ` [PATCH 2/2] usb: dwc3: dwc3-qcom: Fix typo in the dwc3 vbus override API Bryan O'Donoghue
2021-06-29 15:51 ` Bjorn Andersson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YNtBm2AKYaSziRXf@yoga \
--to=bjorn.andersson@linaro.org \
--cc=agross@kernel.org \
--cc=balbi@kernel.org \
--cc=bryan.odonoghue@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=wcheng@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).