From: Bhupesh Sharma <bhupesh.sharma@linaro.org>
To: Stephan Gerhold <stephan@gerhold.net>
Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
agross@kernel.org, linux-kernel@vger.kernel.org,
linux-crypto@vger.kernel.org, andersson@kernel.org,
bhupesh.linux@gmail.com, krzysztof.kozlowski@linaro.org,
robh+dt@kernel.org, konrad.dybcio@linaro.org,
vladimir.zapolskiy@linaro.org, rfoss@kernel.org,
neil.armstrong@linaro.org, djakov@kernel.org
Subject: Re: [PATCH v6 07/11] arm64: dts: qcom: sm6115: Add Crypto Engine support
Date: Fri, 19 May 2023 15:52:32 +0530 [thread overview]
Message-ID: <CAH=2Ntx4H+hOzYLWqiogdBGE+rQ2XayrweE_P8T8gVE0zbwzeg@mail.gmail.com> (raw)
In-Reply-To: <ZGdLCdSof027mk5u@gerhold.net>
Hi Stephan,
On Fri, 19 May 2023 at 15:40, Stephan Gerhold <stephan@gerhold.net> wrote:
>
> Hi Bhupesh,
>
> Not sure if this is the latest version of this series since it's pretty
> old but I didn't find a new one. Just came here because you mentioned
> RB1/RB2 [1] in my bam_dma patch and they don't have any BAM defined
> upstream yet.
>
> [1]: https://lore.kernel.org/linux-arm-msm/CAH=2Ntw0BZH=RGp14mYLhX7D6jV5O5eDKRQbby=uCy85xMDU_g@mail.gmail.com/
>
> On Wed, Apr 05, 2023 at 12:58:32PM +0530, Bhupesh Sharma wrote:
> > Add crypto engine (CE) and CE BAM related nodes and definitions to
> > 'sm6115.dtsi'.
> >
> > Signed-off-by: Bhupesh Sharma <bhupesh.sharma@linaro.org>
> > ---
> > arch/arm64/boot/dts/qcom/sm6115.dtsi | 22 ++++++++++++++++++++++
> > 1 file changed, 22 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/qcom/sm6115.dtsi b/arch/arm64/boot/dts/qcom/sm6115.dtsi
> > index 2a51c938bbcb..ebac026b4cc7 100644
> > --- a/arch/arm64/boot/dts/qcom/sm6115.dtsi
> > +++ b/arch/arm64/boot/dts/qcom/sm6115.dtsi
> > @@ -650,6 +650,28 @@ usb_hsphy: phy@1613000 {
> > status = "disabled";
> > };
> >
> > + cryptobam: dma-controller@1b04000 {
> > + compatible = "qcom,bam-v1.7.4", "qcom,bam-v1.7.0";
> > + reg = <0x0 0x01b04000 0x0 0x24000>;
> > + interrupts = <GIC_SPI 247 IRQ_TYPE_LEVEL_HIGH>;
> > + #dma-cells = <1>;
> > + qcom,ee = <0>;
> > + qcom,controlled-remotely;
> > + num-channels = <8>;
> > + qcom,num-ees = <2>;
> > + iommus = <&apps_smmu 0x94 0x11>,
> > + <&apps_smmu 0x96 0x11>;
> > + };
> > +
> > + crypto: crypto@1b3a000 {
> > + compatible = "qcom,sm6115-qce", "qcom,sm8150-qce", "qcom,qce";
> > + reg = <0x0 0x01b3a000 0x0 0x6000>;
> > + dmas = <&cryptobam 6>, <&cryptobam 7>;
> > + dma-names = "rx", "tx";
> > + iommus = <&apps_smmu 0x94 0x11>,
> > + <&apps_smmu 0x96 0x11>;
>
> Shouldn't you have clocks = <&rpmcc RPM_SMD_CE1_CLK> here to make sure
> the clock for the crypto engine is on? Your binding patch (PATCH 06/11)
> says "Crypto Engine block on Qualcomm SoCs SM6115 and QCM2290 do not
> require clocks strictly" but doesn't say why.
>
> Make sure you don't rely on having rpmcc keep unused clocks on
> permanently. This is the case at the moment, but we would like to change
> this [2]. Adding new users that rely on this broken behavior would just
> make this effort even more complicated.
>
> If you also add the clock to the cryptobam then you should be able to
> see the advantage of my bam_dma patch [3]. It allows you to drop
> "num-channels" and "qcom,num-ees" from the cryptobam in your changes
> above because it can then be read directly from the BAM registers.
Thanks for pointing this out. Actually that's why I was using your
patch while testing with RB1/RB2 :)
Yes, so the background is that I am preparing a new version of this
crypto enablement patchset.
Also your assumption about the clocks being turned on by the firmware
is true for RB1/RB2 devices, so enabling them via Linux is optional as
per Qualcomm enggs.
So, I am testing the new patchset right now with 'clock' entries
provided in the .dtsi and see if that causes any issue / improvement
(etc.)
Will come back with updates (and a new version of this patchset) soon.
Regards,
Bhupesh
> Thanks,
> Stephan
>
> [2]: https://lore.kernel.org/linux-arm-msm/20230303-topic-rpmcc_sleep-v2-0-ae80a325fe94@linaro.org/
> [3]: https://lore.kernel.org/linux-arm-msm/20230518-bamclk-dt-v1-1-82f738c897d9@gerhold.net/
next prev parent reply other threads:[~2023-05-19 10:22 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-05 7:28 [PATCH v6 00/11] arm64: qcom: Enable Crypto Engine for a few Qualcomm SoCs Bhupesh Sharma
2023-04-05 7:28 ` [PATCH v6 01/11] dt-bindings: dma: Add support for SM6115 and QCM2290 SoCs Bhupesh Sharma
2023-04-05 7:28 ` [PATCH v6 02/11] dt-bindings: dma: Increase iommu maxItems for BAM DMA Bhupesh Sharma
2023-04-05 7:28 ` [PATCH v6 03/11] arm64: dts: qcom: sdm8550: Fix the BAM DMA engine compatible string Bhupesh Sharma
2023-04-05 7:28 ` [PATCH v6 04/11] arm64: dts: qcom: sdm845: Fix the slimbam " Bhupesh Sharma
2023-04-05 7:28 ` [PATCH v6 05/11] dt-bindings: qcom-qce: Fix compatible combinations for SM8150 and IPQ4019 SoCs Bhupesh Sharma
2023-04-12 13:23 ` Rob Herring
2023-04-05 7:28 ` [PATCH v6 06/11] dt-bindings: qcom-qce: Add compatibles for SM6115 and QCM2290 Bhupesh Sharma
2023-04-05 7:28 ` [PATCH v6 07/11] arm64: dts: qcom: sm6115: Add Crypto Engine support Bhupesh Sharma
2023-04-06 13:52 ` Konrad Dybcio
2023-05-19 10:10 ` Stephan Gerhold
2023-05-19 10:22 ` Bhupesh Sharma [this message]
2023-05-19 10:42 ` Konrad Dybcio
2023-05-19 10:49 ` Bhupesh Sharma
2023-05-19 10:51 ` Konrad Dybcio
2023-04-05 7:28 ` [PATCH v6 08/11] arm64: dts: qcom: sm8150: " Bhupesh Sharma
2023-04-06 13:58 ` Konrad Dybcio
2023-05-19 10:33 ` Bhupesh Sharma
2023-04-05 7:28 ` [PATCH v6 09/11] arm64: dts: qcom: sm8250: " Bhupesh Sharma
2023-04-06 13:59 ` Konrad Dybcio
2023-05-19 10:34 ` Bhupesh Sharma
2023-04-05 7:28 ` [PATCH v6 10/11] arm64: dts: qcom: sm8350: " Bhupesh Sharma
2023-04-05 7:28 ` [PATCH v6 11/11] arm64: dts: qcom: sm8450: add crypto nodes Bhupesh Sharma
2023-04-12 11:55 ` [PATCH v6 00/11] arm64: qcom: Enable Crypto Engine for a few Qualcomm SoCs Naresh Kamboju
2023-06-16 17:42 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAH=2Ntx4H+hOzYLWqiogdBGE+rQ2XayrweE_P8T8gVE0zbwzeg@mail.gmail.com' \
--to=bhupesh.sharma@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=bhupesh.linux@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=djakov@kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=rfoss@kernel.org \
--cc=robh+dt@kernel.org \
--cc=stephan@gerhold.net \
--cc=vladimir.zapolskiy@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).