* [PULL]: qcom: SC7180 and SC7280 venus firmware updates
@ 2022-10-18 21:12 Nathan Hebert
2022-10-19 15:52 ` Rob Clark
0 siblings, 1 reply; 8+ messages in thread
From: Nathan Hebert @ 2022-10-18 21:12 UTC (permalink / raw)
To: linux-firmware; +Cc: linux-arm-msm, quic_vgarodia, Fritz Koenig
The following changes since commit 48407ffd7adb9511701547068b1e6f0956bd1c94:
cnm: update chips&media wave521c firmware. (2022-10-17 10:20:43 -0400)
are available in the Git repository at:
https://github.com/nathan-google/linux-firmware.git
update_sc7180_and_sc7280_firmwares
for you to fetch changes up to 76e160366a28010fa06ddc965659c38a44d159d9:
qcom: update venus firmware files for VPU-2.0 (2022-10-18 13:42:58 -0700)
----------------------------------------------------------------
Nathan Hebert (2):
qcom: update venus firmware files for v5.4
qcom: update venus firmware files for VPU-2.0
qcom/venus-5.4/venus.b00 | Bin 212 -> 212 bytes
qcom/venus-5.4/venus.b01 | Bin 6808 -> 6808 bytes
qcom/venus-5.4/venus.b02 | Bin 873596 -> 875020 bytes
qcom/venus-5.4/venus.b03 | Bin 33792 -> 33896 bytes
qcom/venus-5.4/venus.mbn | Bin 919708 -> 921236 bytes
qcom/venus-5.4/venus.mdt | Bin 7020 -> 7020 bytes
qcom/vpu-2.0/venus.b00 | Bin 692 -> 692 bytes
qcom/vpu-2.0/venus.b01 | Bin 7376 -> 7376 bytes
qcom/vpu-2.0/venus.b02 | Bin 300 -> 300 bytes
qcom/vpu-2.0/venus.b04 | Bin 20 -> 20 bytes
qcom/vpu-2.0/venus.b09 | Bin 939184 -> 939472 bytes
qcom/vpu-2.0/venus.b10 | Bin 42976 -> 43120 bytes
qcom/vpu-2.0/venus.mbn | Bin 2031188 -> 2031620 bytes
qcom/vpu-2.0/venus.mdt | Bin 8068 -> 8068 bytes
14 files changed, 0 insertions(+), 0 deletions(-)
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PULL]: qcom: SC7180 and SC7280 venus firmware updates 2022-10-18 21:12 [PULL]: qcom: SC7180 and SC7280 venus firmware updates Nathan Hebert @ 2022-10-19 15:52 ` Rob Clark 2022-10-19 16:02 ` Rob Clark 0 siblings, 1 reply; 8+ messages in thread From: Rob Clark @ 2022-10-19 15:52 UTC (permalink / raw) To: Nathan Hebert; +Cc: linux-firmware, linux-arm-msm, quic_vgarodia, Fritz Koenig Hmm, does venus not support the combined firmware yet? Elsewhere we've moved away from split fw to using a single ELF file.. BR, -R On Tue, Oct 18, 2022 at 2:18 PM Nathan Hebert <nhebert@chromium.org> wrote: > > The following changes since commit 48407ffd7adb9511701547068b1e6f0956bd1c94: > > cnm: update chips&media wave521c firmware. (2022-10-17 10:20:43 -0400) > > are available in the Git repository at: > > https://github.com/nathan-google/linux-firmware.git > update_sc7180_and_sc7280_firmwares > > for you to fetch changes up to 76e160366a28010fa06ddc965659c38a44d159d9: > > qcom: update venus firmware files for VPU-2.0 (2022-10-18 13:42:58 -0700) > > ---------------------------------------------------------------- > Nathan Hebert (2): > qcom: update venus firmware files for v5.4 > qcom: update venus firmware files for VPU-2.0 > > qcom/venus-5.4/venus.b00 | Bin 212 -> 212 bytes > qcom/venus-5.4/venus.b01 | Bin 6808 -> 6808 bytes > qcom/venus-5.4/venus.b02 | Bin 873596 -> 875020 bytes > qcom/venus-5.4/venus.b03 | Bin 33792 -> 33896 bytes > qcom/venus-5.4/venus.mbn | Bin 919708 -> 921236 bytes > qcom/venus-5.4/venus.mdt | Bin 7020 -> 7020 bytes > qcom/vpu-2.0/venus.b00 | Bin 692 -> 692 bytes > qcom/vpu-2.0/venus.b01 | Bin 7376 -> 7376 bytes > qcom/vpu-2.0/venus.b02 | Bin 300 -> 300 bytes > qcom/vpu-2.0/venus.b04 | Bin 20 -> 20 bytes > qcom/vpu-2.0/venus.b09 | Bin 939184 -> 939472 bytes > qcom/vpu-2.0/venus.b10 | Bin 42976 -> 43120 bytes > qcom/vpu-2.0/venus.mbn | Bin 2031188 -> 2031620 bytes > qcom/vpu-2.0/venus.mdt | Bin 8068 -> 8068 bytes > 14 files changed, 0 insertions(+), 0 deletions(-) ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PULL]: qcom: SC7180 and SC7280 venus firmware updates 2022-10-19 15:52 ` Rob Clark @ 2022-10-19 16:02 ` Rob Clark 2022-10-19 17:09 ` Vikash Garodia 0 siblings, 1 reply; 8+ messages in thread From: Rob Clark @ 2022-10-19 16:02 UTC (permalink / raw) To: Nathan Hebert Cc: linux-firmware, linux-arm-msm, quic_vgarodia, Fritz Koenig, Bjorn Andersson Actually, isn't the .mbn the joined fw? If so all you need to do is remove the other files? On Wed, Oct 19, 2022 at 8:52 AM Rob Clark <robdclark@gmail.com> wrote: > > Hmm, does venus not support the combined firmware yet? Elsewhere > we've moved away from split fw to using a single ELF file.. > > BR, > -R > > On Tue, Oct 18, 2022 at 2:18 PM Nathan Hebert <nhebert@chromium.org> wrote: > > > > The following changes since commit 48407ffd7adb9511701547068b1e6f0956bd1c94: > > > > cnm: update chips&media wave521c firmware. (2022-10-17 10:20:43 -0400) > > > > are available in the Git repository at: > > > > https://github.com/nathan-google/linux-firmware.git > > update_sc7180_and_sc7280_firmwares > > > > for you to fetch changes up to 76e160366a28010fa06ddc965659c38a44d159d9: > > > > qcom: update venus firmware files for VPU-2.0 (2022-10-18 13:42:58 -0700) > > > > ---------------------------------------------------------------- > > Nathan Hebert (2): > > qcom: update venus firmware files for v5.4 > > qcom: update venus firmware files for VPU-2.0 > > > > qcom/venus-5.4/venus.b00 | Bin 212 -> 212 bytes > > qcom/venus-5.4/venus.b01 | Bin 6808 -> 6808 bytes > > qcom/venus-5.4/venus.b02 | Bin 873596 -> 875020 bytes > > qcom/venus-5.4/venus.b03 | Bin 33792 -> 33896 bytes > > qcom/venus-5.4/venus.mbn | Bin 919708 -> 921236 bytes > > qcom/venus-5.4/venus.mdt | Bin 7020 -> 7020 bytes > > qcom/vpu-2.0/venus.b00 | Bin 692 -> 692 bytes > > qcom/vpu-2.0/venus.b01 | Bin 7376 -> 7376 bytes > > qcom/vpu-2.0/venus.b02 | Bin 300 -> 300 bytes > > qcom/vpu-2.0/venus.b04 | Bin 20 -> 20 bytes > > qcom/vpu-2.0/venus.b09 | Bin 939184 -> 939472 bytes > > qcom/vpu-2.0/venus.b10 | Bin 42976 -> 43120 bytes > > qcom/vpu-2.0/venus.mbn | Bin 2031188 -> 2031620 bytes > > qcom/vpu-2.0/venus.mdt | Bin 8068 -> 8068 bytes > > 14 files changed, 0 insertions(+), 0 deletions(-) ^ permalink raw reply [flat|nested] 8+ messages in thread
* RE: [PULL]: qcom: SC7180 and SC7280 venus firmware updates 2022-10-19 16:02 ` Rob Clark @ 2022-10-19 17:09 ` Vikash Garodia 2022-10-20 16:52 ` Nathan Hebert 0 siblings, 1 reply; 8+ messages in thread From: Vikash Garodia @ 2022-10-19 17:09 UTC (permalink / raw) To: Rob Clark, Nathan Hebert Cc: linux-firmware, linux-arm-msm, Vikash Garodia (QUIC), Fritz Koenig, Bjorn Andersson Hi Rob, > -----Original Message----- > From: Rob Clark <robdclark@gmail.com> > Sent: Wednesday, October 19, 2022 9:32 PM > To: Nathan Hebert <nhebert@chromium.org> > Cc: linux-firmware@kernel.org; linux-arm-msm@vger.kernel.org; Vikash > Garodia (QUIC) <quic_vgarodia@quicinc.com>; Fritz Koenig > <frkoenig@chromium.org>; Bjorn Andersson <andersson@kernel.org> > Subject: Re: [PULL]: qcom: SC7180 and SC7280 venus firmware updates > > WARNING: This email originated from outside of Qualcomm. Please be wary of > any links or attachments, and do not enable macros. > > Actually, isn't the .mbn the joined fw? If so all you need to do is remove the > other files? .mbn is the complete firmware image. We have migrated to .mbn for sc7280, while the Initial days of sc7280 was with .mdt binaries (split ones). So to support the boards which Have not upgraded the driver, we are retaining all binaries. > On Wed, Oct 19, 2022 at 8:52 AM Rob Clark <robdclark@gmail.com> wrote: > > > > Hmm, does venus not support the combined firmware yet? Elsewhere > > we've moved away from split fw to using a single ELF file.. > > > > BR, > > -R > > > > On Tue, Oct 18, 2022 at 2:18 PM Nathan Hebert <nhebert@chromium.org> > wrote: > > > > > > The following changes since commit > 48407ffd7adb9511701547068b1e6f0956bd1c94: > > > > > > cnm: update chips&media wave521c firmware. (2022-10-17 10:20:43 > > > -0400) > > > > > > are available in the Git repository at: > > > > > > https://github.com/nathan-google/linux-firmware.git > > > update_sc7180_and_sc7280_firmwares > > > > > > for you to fetch changes up to > 76e160366a28010fa06ddc965659c38a44d159d9: > > > > > > qcom: update venus firmware files for VPU-2.0 (2022-10-18 13:42:58 > > > -0700) > > > > > > ---------------------------------------------------------------- > > > Nathan Hebert (2): > > > qcom: update venus firmware files for v5.4 > > > qcom: update venus firmware files for VPU-2.0 > > > > > > qcom/venus-5.4/venus.b00 | Bin 212 -> 212 bytes > > > qcom/venus-5.4/venus.b01 | Bin 6808 -> 6808 bytes > > > qcom/venus-5.4/venus.b02 | Bin 873596 -> 875020 bytes > > > qcom/venus-5.4/venus.b03 | Bin 33792 -> 33896 bytes > > > qcom/venus-5.4/venus.mbn | Bin 919708 -> 921236 bytes > > > qcom/venus-5.4/venus.mdt | Bin 7020 -> 7020 bytes > > > qcom/vpu-2.0/venus.b00 | Bin 692 -> 692 bytes > > > qcom/vpu-2.0/venus.b01 | Bin 7376 -> 7376 bytes > > > qcom/vpu-2.0/venus.b02 | Bin 300 -> 300 bytes > > > qcom/vpu-2.0/venus.b04 | Bin 20 -> 20 bytes > > > qcom/vpu-2.0/venus.b09 | Bin 939184 -> 939472 bytes > > > qcom/vpu-2.0/venus.b10 | Bin 42976 -> 43120 bytes > > > qcom/vpu-2.0/venus.mbn | Bin 2031188 -> 2031620 bytes > > > qcom/vpu-2.0/venus.mdt | Bin 8068 -> 8068 bytes > > > 14 files changed, 0 insertions(+), 0 deletions(-) Thanks, Vikash ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PULL]: qcom: SC7180 and SC7280 venus firmware updates 2022-10-19 17:09 ` Vikash Garodia @ 2022-10-20 16:52 ` Nathan Hebert 2022-10-20 18:00 ` Dmitry Baryshkov 0 siblings, 1 reply; 8+ messages in thread From: Nathan Hebert @ 2022-10-20 16:52 UTC (permalink / raw) To: Vikash Garodia Cc: Rob Clark, linux-firmware, linux-arm-msm, Vikash Garodia (QUIC), Fritz Koenig, Bjorn Andersson On Wed, Oct 19, 2022 at 10:09 AM Vikash Garodia <vgarodia@qti.qualcomm.com> wrote: > > Hi Rob, > > > -----Original Message----- > > From: Rob Clark <robdclark@gmail.com> > > Sent: Wednesday, October 19, 2022 9:32 PM > > To: Nathan Hebert <nhebert@chromium.org> > > Cc: linux-firmware@kernel.org; linux-arm-msm@vger.kernel.org; Vikash > > Garodia (QUIC) <quic_vgarodia@quicinc.com>; Fritz Koenig > > <frkoenig@chromium.org>; Bjorn Andersson <andersson@kernel.org> > > Subject: Re: [PULL]: qcom: SC7180 and SC7280 venus firmware updates > > > > WARNING: This email originated from outside of Qualcomm. Please be wary of > > any links or attachments, and do not enable macros. > > > > Actually, isn't the .mbn the joined fw? If so all you need to do is remove the > > other files? > .mbn is the complete firmware image. We have migrated to .mbn for sc7280, while the > Initial days of sc7280 was with .mdt binaries (split ones). So to support the boards which > Have not upgraded the driver, we are retaining all binaries. > Thanks for the feedback (on and off-list). I will push a V2 of the pull request with the following changes: 1. Update both split and non-split binaries for venus-5.4 (SC7180). Also, update the version in WHENCE. We can remove the legacy split images in a later commit if it is feasible to do so. 2. Remove the split firmware images for vpu-2.0 (SC7280). There is no released device that uses the older firmware loader. I have tested to make sure the non-split image can be loaded and that the venus media functions work on a SC7280 device using a ChromeOS kernel based on 5.15. 3. Update the VPU-2.0 non-split binaries to the latest version and update the version in the WHENCE file. > > On Wed, Oct 19, 2022 at 8:52 AM Rob Clark <robdclark@gmail.com> wrote: > > > > > > Hmm, does venus not support the combined firmware yet? Elsewhere > > > we've moved away from split fw to using a single ELF file.. > > > > > > BR, > > > -R > > > > > > On Tue, Oct 18, 2022 at 2:18 PM Nathan Hebert <nhebert@chromium.org> > > wrote: > > > > > > > > The following changes since commit > > 48407ffd7adb9511701547068b1e6f0956bd1c94: > > > > > > > > cnm: update chips&media wave521c firmware. (2022-10-17 10:20:43 > > > > -0400) > > > > > > > > are available in the Git repository at: > > > > > > > > https://github.com/nathan-google/linux-firmware.git > > > > update_sc7180_and_sc7280_firmwares > > > > > > > > for you to fetch changes up to > > 76e160366a28010fa06ddc965659c38a44d159d9: > > > > > > > > qcom: update venus firmware files for VPU-2.0 (2022-10-18 13:42:58 > > > > -0700) > > > > > > > > ---------------------------------------------------------------- > > > > Nathan Hebert (2): > > > > qcom: update venus firmware files for v5.4 > > > > qcom: update venus firmware files for VPU-2.0 > > > > > > > > qcom/venus-5.4/venus.b00 | Bin 212 -> 212 bytes > > > > qcom/venus-5.4/venus.b01 | Bin 6808 -> 6808 bytes > > > > qcom/venus-5.4/venus.b02 | Bin 873596 -> 875020 bytes > > > > qcom/venus-5.4/venus.b03 | Bin 33792 -> 33896 bytes > > > > qcom/venus-5.4/venus.mbn | Bin 919708 -> 921236 bytes > > > > qcom/venus-5.4/venus.mdt | Bin 7020 -> 7020 bytes > > > > qcom/vpu-2.0/venus.b00 | Bin 692 -> 692 bytes > > > > qcom/vpu-2.0/venus.b01 | Bin 7376 -> 7376 bytes > > > > qcom/vpu-2.0/venus.b02 | Bin 300 -> 300 bytes > > > > qcom/vpu-2.0/venus.b04 | Bin 20 -> 20 bytes > > > > qcom/vpu-2.0/venus.b09 | Bin 939184 -> 939472 bytes > > > > qcom/vpu-2.0/venus.b10 | Bin 42976 -> 43120 bytes > > > > qcom/vpu-2.0/venus.mbn | Bin 2031188 -> 2031620 bytes > > > > qcom/vpu-2.0/venus.mdt | Bin 8068 -> 8068 bytes > > > > 14 files changed, 0 insertions(+), 0 deletions(-) > > Thanks, > Vikash ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PULL]: qcom: SC7180 and SC7280 venus firmware updates 2022-10-20 16:52 ` Nathan Hebert @ 2022-10-20 18:00 ` Dmitry Baryshkov 2022-10-25 6:20 ` Vikash Garodia 0 siblings, 1 reply; 8+ messages in thread From: Dmitry Baryshkov @ 2022-10-20 18:00 UTC (permalink / raw) To: Nathan Hebert Cc: Vikash Garodia, Rob Clark, linux-firmware, linux-arm-msm, Vikash Garodia (QUIC), Fritz Koenig, Bjorn Andersson Hi, On Thu, 20 Oct 2022 at 19:52, Nathan Hebert <nhebert@chromium.org> wrote: > > On Wed, Oct 19, 2022 at 10:09 AM Vikash Garodia > <vgarodia@qti.qualcomm.com> wrote: > > > > Hi Rob, > > > > > -----Original Message----- > > > From: Rob Clark <robdclark@gmail.com> > > > Sent: Wednesday, October 19, 2022 9:32 PM > > > To: Nathan Hebert <nhebert@chromium.org> > > > Cc: linux-firmware@kernel.org; linux-arm-msm@vger.kernel.org; Vikash > > > Garodia (QUIC) <quic_vgarodia@quicinc.com>; Fritz Koenig > > > <frkoenig@chromium.org>; Bjorn Andersson <andersson@kernel.org> > > > Subject: Re: [PULL]: qcom: SC7180 and SC7280 venus firmware updates > > > > > > WARNING: This email originated from outside of Qualcomm. Please be wary of > > > any links or attachments, and do not enable macros. > > > > > > Actually, isn't the .mbn the joined fw? If so all you need to do is remove the > > > other files? > > .mbn is the complete firmware image. We have migrated to .mbn for sc7280, while the > > Initial days of sc7280 was with .mdt binaries (split ones). So to support the boards which > > Have not upgraded the driver, we are retaining all binaries. > > > > Thanks for the feedback (on and off-list). I will push a V2 of the pull request > with the following changes: > > 1. Update both split and non-split binaries for venus-5.4 (SC7180). Also, > update the version in WHENCE. We can remove the legacy split images in a later > commit if it is feasible to do so. The mdt loader doesn't care about the file extension, the mdt loader will determine the type of the file based on the file contents. Thus I'd suggest adding only mbn files and adding a compat symlinks pointing from venus.mdt to venus.mbn > 2. Remove the split firmware images for vpu-2.0 (SC7280). There is no released > device that uses the older firmware loader. I have tested to make sure the > non-split image can be loaded and that the venus media functions work on a > SC7280 device using a ChromeOS kernel based on 5.15. > 3. Update the VPU-2.0 non-split binaries to the latest version and update the > version in the WHENCE file. -- With best wishes Dmitry ^ permalink raw reply [flat|nested] 8+ messages in thread
* RE: [PULL]: qcom: SC7180 and SC7280 venus firmware updates 2022-10-20 18:00 ` Dmitry Baryshkov @ 2022-10-25 6:20 ` Vikash Garodia 2022-10-25 15:13 ` Nathan Hebert 0 siblings, 1 reply; 8+ messages in thread From: Vikash Garodia @ 2022-10-25 6:20 UTC (permalink / raw) To: dmitry.baryshkov, Nathan Hebert Cc: Rob Clark, linux-firmware, linux-arm-msm, Vikash Garodia (QUIC), Fritz Koenig, Bjorn Andersson Hi Dmitry, > -----Original Message----- > From: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > Sent: Thursday, October 20, 2022 11:31 PM > To: Nathan Hebert <nhebert@chromium.org> > Cc: Vikash Garodia <vgarodia@qti.qualcomm.com>; Rob Clark > <robdclark@gmail.com>; linux-firmware@kernel.org; linux-arm- > msm@vger.kernel.org; Vikash Garodia (QUIC) <quic_vgarodia@quicinc.com>; > Fritz Koenig <frkoenig@chromium.org>; Bjorn Andersson > <andersson@kernel.org> > Subject: Re: [PULL]: qcom: SC7180 and SC7280 venus firmware updates > > WARNING: This email originated from outside of Qualcomm. Please be wary of > any links or attachments, and do not enable macros. > > Hi, > > On Thu, 20 Oct 2022 at 19:52, Nathan Hebert <nhebert@chromium.org> > wrote: > > > > On Wed, Oct 19, 2022 at 10:09 AM Vikash Garodia > > <vgarodia@qti.qualcomm.com> wrote: > > > > > > Hi Rob, > > > > > > > -----Original Message----- > > > > From: Rob Clark <robdclark@gmail.com> > > > > Sent: Wednesday, October 19, 2022 9:32 PM > > > > To: Nathan Hebert <nhebert@chromium.org> > > > > Cc: linux-firmware@kernel.org; linux-arm-msm@vger.kernel.org; > > > > Vikash Garodia (QUIC) <quic_vgarodia@quicinc.com>; Fritz Koenig > > > > <frkoenig@chromium.org>; Bjorn Andersson <andersson@kernel.org> > > > > Subject: Re: [PULL]: qcom: SC7180 and SC7280 venus firmware > > > > updates > > > > > > > > WARNING: This email originated from outside of Qualcomm. Please be > > > > wary of any links or attachments, and do not enable macros. > > > > > > > > Actually, isn't the .mbn the joined fw? If so all you need to do > > > > is remove the other files? > > > .mbn is the complete firmware image. We have migrated to .mbn for > > > sc7280, while the Initial days of sc7280 was with .mdt binaries > > > (split ones). So to support the boards which Have not upgraded the driver, > we are retaining all binaries. > > > > > > > Thanks for the feedback (on and off-list). I will push a V2 of the > > pull request with the following changes: > > > > 1. Update both split and non-split binaries for venus-5.4 (SC7180). > > Also, update the version in WHENCE. We can remove the legacy split > > images in a later commit if it is feasible to do so. > > The mdt loader doesn't care about the file extension, the mdt loader will > determine the type of the file based on the file contents. Thus I'd suggest adding > only mbn files and adding a compat symlinks pointing from venus.mdt to > venus.mbn sc7180 is using venus-5.4 firmware and currently the name is passed as "qcom/venus-5.4/venus.mdt" while making call to "request_firmware()" https://elixir.bootlin.com/linux/latest/source/drivers/media/platform/qcom/venus/core.c#L765 https://elixir.bootlin.com/linux/latest/source/drivers/media/platform/qcom/venus/firmware.c#L104 IIUC, before we remove the split files (.mdt), we should also make change in driver to update the name from .mdt to .mbn. Please help to clarify if we can remove the split files with driver still referring to "qcom/venus-5.4/venus.mdt" in call to request_firmware(). > > 2. Remove the split firmware images for vpu-2.0 (SC7280). There is no > > released device that uses the older firmware loader. I have tested to > > make sure the non-split image can be loaded and that the venus media > > functions work on a > > SC7280 device using a ChromeOS kernel based on 5.15. > > 3. Update the VPU-2.0 non-split binaries to the latest version and > > update the version in the WHENCE file. > > > -- > With best wishes > Dmitry ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PULL]: qcom: SC7180 and SC7280 venus firmware updates 2022-10-25 6:20 ` Vikash Garodia @ 2022-10-25 15:13 ` Nathan Hebert 0 siblings, 0 replies; 8+ messages in thread From: Nathan Hebert @ 2022-10-25 15:13 UTC (permalink / raw) To: Vikash Garodia Cc: dmitry.baryshkov, Rob Clark, linux-firmware, linux-arm-msm, Vikash Garodia (QUIC), Fritz Koenig, Bjorn Andersson Hi Vikash, On Mon, Oct 24, 2022 at 11:20 PM Vikash Garodia <vgarodia@qti.qualcomm.com> wrote: > > Hi Dmitry, > > > -----Original Message----- > > From: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > > Sent: Thursday, October 20, 2022 11:31 PM > > To: Nathan Hebert <nhebert@chromium.org> > > Cc: Vikash Garodia <vgarodia@qti.qualcomm.com>; Rob Clark > > <robdclark@gmail.com>; linux-firmware@kernel.org; linux-arm- > > msm@vger.kernel.org; Vikash Garodia (QUIC) <quic_vgarodia@quicinc.com>; > > Fritz Koenig <frkoenig@chromium.org>; Bjorn Andersson > > <andersson@kernel.org> > > Subject: Re: [PULL]: qcom: SC7180 and SC7280 venus firmware updates > > > > WARNING: This email originated from outside of Qualcomm. Please be wary of > > any links or attachments, and do not enable macros. > > > > Hi, > > > > On Thu, 20 Oct 2022 at 19:52, Nathan Hebert <nhebert@chromium.org> > > wrote: > > > > > > On Wed, Oct 19, 2022 at 10:09 AM Vikash Garodia > > > <vgarodia@qti.qualcomm.com> wrote: > > > > > > > > Hi Rob, > > > > > > > > > -----Original Message----- > > > > > From: Rob Clark <robdclark@gmail.com> > > > > > Sent: Wednesday, October 19, 2022 9:32 PM > > > > > To: Nathan Hebert <nhebert@chromium.org> > > > > > Cc: linux-firmware@kernel.org; linux-arm-msm@vger.kernel.org; > > > > > Vikash Garodia (QUIC) <quic_vgarodia@quicinc.com>; Fritz Koenig > > > > > <frkoenig@chromium.org>; Bjorn Andersson <andersson@kernel.org> > > > > > Subject: Re: [PULL]: qcom: SC7180 and SC7280 venus firmware > > > > > updates > > > > > > > > > > WARNING: This email originated from outside of Qualcomm. Please be > > > > > wary of any links or attachments, and do not enable macros. > > > > > > > > > > Actually, isn't the .mbn the joined fw? If so all you need to do > > > > > is remove the other files? > > > > .mbn is the complete firmware image. We have migrated to .mbn for > > > > sc7280, while the Initial days of sc7280 was with .mdt binaries > > > > (split ones). So to support the boards which Have not upgraded the driver, > > we are retaining all binaries. > > > > > > > > > > Thanks for the feedback (on and off-list). I will push a V2 of the > > > pull request with the following changes: > > > > > > 1. Update both split and non-split binaries for venus-5.4 (SC7180). > > > Also, update the version in WHENCE. We can remove the legacy split > > > images in a later commit if it is feasible to do so. > > > > The mdt loader doesn't care about the file extension, the mdt loader will > > determine the type of the file based on the file contents. Thus I'd suggest adding > > only mbn files and adding a compat symlinks pointing from venus.mdt to > > venus.mbn > > sc7180 is using venus-5.4 firmware and currently the name is passed as "qcom/venus-5.4/venus.mdt" while making call to "request_firmware()" > https://elixir.bootlin.com/linux/latest/source/drivers/media/platform/qcom/venus/core.c#L765 > https://elixir.bootlin.com/linux/latest/source/drivers/media/platform/qcom/venus/firmware.c#L104 Thanks for the code links! That is helpful. > > IIUC, before we remove the split files (.mdt), we should also make change in driver to update the name from .mdt to .mbn. > Please help to clarify if we can remove the split files with driver still referring to "qcom/venus-5.4/venus.mdt" in call to request_firmware(). I think Dmitry is saying that we could remove the venus.b0* files and replace the venus.mdt file with a symbolic link to venus.mbn. This would achieve the goal of reducing the size of the files that are stored and deployed, while staying compatible with the existing driver code. The best solution would probably be to change the driver to load the .mbn files, but using the symbolic link seems like a good intermediate solution. If there is no complaint about Dmitiry's suggestion, I will make a PR V3 with an additional commit to remove the split files and use a symbolic link linking venus.mdt to venus.mbn. This commit will precede the commit to update venus 5.4 firmware. > > > > 2. Remove the split firmware images for vpu-2.0 (SC7280). There is no > > > released device that uses the older firmware loader. I have tested to > > > make sure the non-split image can be loaded and that the venus media > > > functions work on a > > > SC7280 device using a ChromeOS kernel based on 5.15. > > > 3. Update the VPU-2.0 non-split binaries to the latest version and > > > update the version in the WHENCE file. > > > > > > -- > > With best wishes > > Dmitry ^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2022-10-25 15:13 UTC | newest] Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2022-10-18 21:12 [PULL]: qcom: SC7180 and SC7280 venus firmware updates Nathan Hebert 2022-10-19 15:52 ` Rob Clark 2022-10-19 16:02 ` Rob Clark 2022-10-19 17:09 ` Vikash Garodia 2022-10-20 16:52 ` Nathan Hebert 2022-10-20 18:00 ` Dmitry Baryshkov 2022-10-25 6:20 ` Vikash Garodia 2022-10-25 15:13 ` Nathan Hebert
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).