* [PATCH 1/2] mfd: qcom-spmi-pmic: Document eight more PMICs to binding @ 2021-10-05 2:48 Bjorn Andersson 2021-10-05 2:48 ` [PATCH 2/2] mfd: qcom-spmi-pmic: Add missing PMICs supported by socinfo Bjorn Andersson 2021-10-12 14:46 ` [PATCH 1/2] mfd: qcom-spmi-pmic: Document eight more PMICs to binding Lee Jones 0 siblings, 2 replies; 5+ messages in thread From: Bjorn Andersson @ 2021-10-05 2:48 UTC (permalink / raw) To: Andy Gross, Bjorn Andersson, Lee Jones, Rob Herring Cc: linux-arm-msm, devicetree, linux-kernel Update the binding with eitght more SPMI PMIC compatibles found in the PMIC info list in the Qualcomm socinfo driver. Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org> --- Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.txt | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.txt b/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.txt index 5ef79bf3d035..1d2b5f067556 100644 --- a/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.txt +++ b/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.txt @@ -29,6 +29,8 @@ Required properties: "qcom,pm8916", "qcom,pm8004", "qcom,pm8909", + "qcom,pm8028", + "qcom,pm8901", "qcom,pm8950", "qcom,pmi8950", "qcom,pm8998", @@ -38,6 +40,12 @@ Required properties: "qcom,pmk8350", "qcom,pm7325", "qcom,pmr735a", + "qcom,pm8150", + "qcom,pm8150l", + "qcom,pm8150b", + "qcom,pmk8002", + "qcom,pm8150c", + "qcom,smb2351", or generalized "qcom,spmi-pmic". - reg: Specifies the SPMI USID slave address for this device. For more information see: -- 2.29.2 ^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH 2/2] mfd: qcom-spmi-pmic: Add missing PMICs supported by socinfo 2021-10-05 2:48 [PATCH 1/2] mfd: qcom-spmi-pmic: Document eight more PMICs to binding Bjorn Andersson @ 2021-10-05 2:48 ` Bjorn Andersson 2021-10-12 14:46 ` [PATCH 1/2] mfd: qcom-spmi-pmic: Document eight more PMICs to binding Lee Jones 1 sibling, 0 replies; 5+ messages in thread From: Bjorn Andersson @ 2021-10-05 2:48 UTC (permalink / raw) To: Andy Gross, Bjorn Andersson, Lee Jones, Rob Herring Cc: linux-arm-msm, devicetree, linux-kernel The Qualcomm socinfo driver has eight more PMICs described, add these to the SPMI PMIC driver as well. Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org> --- drivers/mfd/qcom-spmi-pmic.c | 17 +++++++++++++++++ 1 file changed, 17 insertions(+) diff --git a/drivers/mfd/qcom-spmi-pmic.c b/drivers/mfd/qcom-spmi-pmic.c index a35d5cf16faa..0920d7aa43a7 100644 --- a/drivers/mfd/qcom-spmi-pmic.c +++ b/drivers/mfd/qcom-spmi-pmic.c @@ -31,6 +31,8 @@ #define PM8916_SUBTYPE 0x0b #define PM8004_SUBTYPE 0x0c #define PM8909_SUBTYPE 0x0d +#define PM8028_SUBTYPE 0x0e +#define PM8901_SUBTYPE 0x0f #define PM8950_SUBTYPE 0x10 #define PMI8950_SUBTYPE 0x11 #define PM8998_SUBTYPE 0x14 @@ -38,6 +40,13 @@ #define PM8005_SUBTYPE 0x18 #define PM660L_SUBTYPE 0x1A #define PM660_SUBTYPE 0x1B +#define PM8150_SUBTYPE 0x1E +#define PM8150L_SUBTYPE 0x1f +#define PM8150B_SUBTYPE 0x20 +#define PMK8002_SUBTYPE 0x21 +#define PM8009_SUBTYPE 0x24 +#define PM8150C_SUBTYPE 0x26 +#define SMB2351_SUBTYPE 0x29 static const struct of_device_id pmic_spmi_id_table[] = { { .compatible = "qcom,spmi-pmic", .data = (void *)COMMON_SUBTYPE }, @@ -54,6 +63,8 @@ static const struct of_device_id pmic_spmi_id_table[] = { { .compatible = "qcom,pm8916", .data = (void *)PM8916_SUBTYPE }, { .compatible = "qcom,pm8004", .data = (void *)PM8004_SUBTYPE }, { .compatible = "qcom,pm8909", .data = (void *)PM8909_SUBTYPE }, + { .compatible = "qcom,pm8028", .data = (void *)PM8028_SUBTYPE }, + { .compatible = "qcom,pm8901", .data = (void *)PM8901_SUBTYPE }, { .compatible = "qcom,pm8950", .data = (void *)PM8950_SUBTYPE }, { .compatible = "qcom,pmi8950", .data = (void *)PMI8950_SUBTYPE }, { .compatible = "qcom,pm8998", .data = (void *)PM8998_SUBTYPE }, @@ -61,6 +72,12 @@ static const struct of_device_id pmic_spmi_id_table[] = { { .compatible = "qcom,pm8005", .data = (void *)PM8005_SUBTYPE }, { .compatible = "qcom,pm660l", .data = (void *)PM660L_SUBTYPE }, { .compatible = "qcom,pm660", .data = (void *)PM660_SUBTYPE }, + { .compatible = "qcom,pm8150", .data = (void *)PM8150_SUBTYPE }, + { .compatible = "qcom,pm8150l", .data = (void *)PM8150L_SUBTYPE }, + { .compatible = "qcom,pm8150b", .data = (void *)PM8150B_SUBTYPE }, + { .compatible = "qcom,pmk8002", .data = (void *)PMK8002_SUBTYPE }, + { .compatible = "qcom,pm8150c", .data = (void *)PM8150C_SUBTYPE }, + { .compatible = "qcom,smb2351", .data = (void *)SMB2351_SUBTYPE }, { } }; -- 2.29.2 ^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH 1/2] mfd: qcom-spmi-pmic: Document eight more PMICs to binding 2021-10-05 2:48 [PATCH 1/2] mfd: qcom-spmi-pmic: Document eight more PMICs to binding Bjorn Andersson 2021-10-05 2:48 ` [PATCH 2/2] mfd: qcom-spmi-pmic: Add missing PMICs supported by socinfo Bjorn Andersson @ 2021-10-12 14:46 ` Lee Jones 2021-10-12 17:04 ` Bjorn Andersson 1 sibling, 1 reply; 5+ messages in thread From: Lee Jones @ 2021-10-12 14:46 UTC (permalink / raw) To: Bjorn Andersson Cc: Andy Gross, Rob Herring, linux-arm-msm, devicetree, linux-kernel On Mon, 04 Oct 2021, Bjorn Andersson wrote: > Update the binding with eitght more SPMI PMIC compatibles found in the Spell check. > PMIC info list in the Qualcomm socinfo driver. > > Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org> > --- > Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.txt | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.txt b/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.txt > index 5ef79bf3d035..1d2b5f067556 100644 > --- a/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.txt > +++ b/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.txt > @@ -29,6 +29,8 @@ Required properties: > "qcom,pm8916", > "qcom,pm8004", > "qcom,pm8909", > + "qcom,pm8028", > + "qcom,pm8901", > "qcom,pm8950", > "qcom,pmi8950", > "qcom,pm8998", > @@ -38,6 +40,12 @@ Required properties: > "qcom,pmk8350", > "qcom,pm7325", > "qcom,pmr735a", > + "qcom,pm8150", > + "qcom,pm8150l", > + "qcom,pm8150b", > + "qcom,pmk8002", > + "qcom,pm8150c", > + "qcom,smb2351", > or generalized "qcom,spmi-pmic". > - reg: Specifies the SPMI USID slave address for this device. > For more information see: Is there any reason why these can't be in lexicographical order? -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 1/2] mfd: qcom-spmi-pmic: Document eight more PMICs to binding 2021-10-12 14:46 ` [PATCH 1/2] mfd: qcom-spmi-pmic: Document eight more PMICs to binding Lee Jones @ 2021-10-12 17:04 ` Bjorn Andersson 2021-10-12 18:33 ` Lee Jones 0 siblings, 1 reply; 5+ messages in thread From: Bjorn Andersson @ 2021-10-12 17:04 UTC (permalink / raw) To: Lee Jones Cc: Andy Gross, Rob Herring, linux-arm-msm, devicetree, linux-kernel On Tue 12 Oct 09:46 CDT 2021, Lee Jones wrote: > On Mon, 04 Oct 2021, Bjorn Andersson wrote: > > > Update the binding with eitght more SPMI PMIC compatibles found in the > > Spell check. > Bummer... > > PMIC info list in the Qualcomm socinfo driver. > > > > Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org> > > --- > > Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.txt | 8 ++++++++ > > 1 file changed, 8 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.txt b/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.txt > > index 5ef79bf3d035..1d2b5f067556 100644 > > --- a/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.txt > > +++ b/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.txt > > @@ -29,6 +29,8 @@ Required properties: > > "qcom,pm8916", > > "qcom,pm8004", > > "qcom,pm8909", > > + "qcom,pm8028", > > + "qcom,pm8901", > > "qcom,pm8950", > > "qcom,pmi8950", > > "qcom,pm8998", > > @@ -38,6 +40,12 @@ Required properties: > > "qcom,pmk8350", > > "qcom,pm7325", > > "qcom,pmr735a", > > + "qcom,pm8150", > > + "qcom,pm8150l", > > + "qcom,pm8150b", > > + "qcom,pmk8002", > > + "qcom,pm8150c", > > + "qcom,smb2351", > > or generalized "qcom,spmi-pmic". > > - reg: Specifies the SPMI USID slave address for this device. > > For more information see: > > Is there any reason why these can't be in lexicographical order? > Definitely not, both this list and the list compatible list in the driver would be better of sorted. I just didn't want to sort and add the entries in a single commit. Do you want me to respin this, adding two patches that sort the elements? Or will you fix my awesome spelling of 8 above and I send you the patches that shuffles the entries? Thanks, Bjorn > -- > Lee Jones [?????????] > Senior Technical Lead - Developer Services > Linaro.org ??? Open source software for Arm SoCs > Follow Linaro: Facebook | Twitter | Blog ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 1/2] mfd: qcom-spmi-pmic: Document eight more PMICs to binding 2021-10-12 17:04 ` Bjorn Andersson @ 2021-10-12 18:33 ` Lee Jones 0 siblings, 0 replies; 5+ messages in thread From: Lee Jones @ 2021-10-12 18:33 UTC (permalink / raw) To: Bjorn Andersson Cc: Andy Gross, Rob Herring, linux-arm-msm, devicetree, linux-kernel On Tue, 12 Oct 2021, Bjorn Andersson wrote: > On Tue 12 Oct 09:46 CDT 2021, Lee Jones wrote: > > > On Mon, 04 Oct 2021, Bjorn Andersson wrote: > > > > > Update the binding with eitght more SPMI PMIC compatibles found in the > > > > Spell check. > > > > Bummer... > > > > PMIC info list in the Qualcomm socinfo driver. > > > > > > Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org> > > > --- > > > Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.txt | 8 ++++++++ > > > 1 file changed, 8 insertions(+) > > > > > > diff --git a/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.txt b/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.txt > > > index 5ef79bf3d035..1d2b5f067556 100644 > > > --- a/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.txt > > > +++ b/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.txt > > > @@ -29,6 +29,8 @@ Required properties: > > > "qcom,pm8916", > > > "qcom,pm8004", > > > "qcom,pm8909", > > > + "qcom,pm8028", > > > + "qcom,pm8901", > > > "qcom,pm8950", > > > "qcom,pmi8950", > > > "qcom,pm8998", > > > @@ -38,6 +40,12 @@ Required properties: > > > "qcom,pmk8350", > > > "qcom,pm7325", > > > "qcom,pmr735a", > > > + "qcom,pm8150", > > > + "qcom,pm8150l", > > > + "qcom,pm8150b", > > > + "qcom,pmk8002", > > > + "qcom,pm8150c", > > > + "qcom,smb2351", > > > or generalized "qcom,spmi-pmic". > > > - reg: Specifies the SPMI USID slave address for this device. > > > For more information see: > > > > Is there any reason why these can't be in lexicographical order? > > > > Definitely not, both this list and the list compatible list in the > driver would be better of sorted. I just didn't want to sort and add the > entries in a single commit. > > Do you want me to respin this, adding two patches that sort the > elements? Or will you fix my awesome spelling of 8 above and I send you > the patches that shuffles the entries? If you can fix the spelling and send the whole set, I'll apply it in one go. -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2021-10-12 18:39 UTC | newest] Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2021-10-05 2:48 [PATCH 1/2] mfd: qcom-spmi-pmic: Document eight more PMICs to binding Bjorn Andersson 2021-10-05 2:48 ` [PATCH 2/2] mfd: qcom-spmi-pmic: Add missing PMICs supported by socinfo Bjorn Andersson 2021-10-12 14:46 ` [PATCH 1/2] mfd: qcom-spmi-pmic: Document eight more PMICs to binding Lee Jones 2021-10-12 17:04 ` Bjorn Andersson 2021-10-12 18:33 ` Lee Jones
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).