From: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
andersson@kernel.org, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org
Cc: johan+linaro@kernel.org, agross@kernel.org,
konrad.dybcio@linaro.org, mturquette@baylibre.com,
sboyd@kernel.org, conor+dt@kernel.org,
linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 5/6] arm64: dts: qcom: sc8280xp: add resets for soundwire controllers
Date: Wed, 7 Jun 2023 14:31:16 +0100 [thread overview]
Message-ID: <fea749a7-ef17-097b-847a-d73f965c841b@linaro.org> (raw)
In-Reply-To: <542a67da-5870-dda0-3604-9367a438e51b@linaro.org>
On 31/05/2023 21:03, Krzysztof Kozlowski wrote:
> On 25/05/2023 14:29, Srinivas Kandagatla wrote:
>> Soundwire controllers on sc8280xp needs an explicit reset, add
>> support for this.
>>
>> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
>> ---
>> arch/arm64/boot/dts/qcom/sc8280xp.dtsi | 23 +++++++++++++++++++++++
>> 1 file changed, 23 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi
>> index 6730349e34f4..39be2e89ce05 100644
>> --- a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi
>> @@ -6,6 +6,7 @@
>>
>> #include <dt-bindings/clock/qcom,dispcc-sc8280xp.h>
>> #include <dt-bindings/clock/qcom,gcc-sc8280xp.h>
>> +#include <dt-bindings/clock/qcom,lpasscc-sc8280xp.h>
>> #include <dt-bindings/clock/qcom,rpmh.h>
>> #include <dt-bindings/interconnect/qcom,osm-l3.h>
>> #include <dt-bindings/interconnect/qcom,sc8280xp.h>
>> @@ -2560,6 +2561,8 @@
>> interrupts = <GIC_SPI 155 IRQ_TYPE_LEVEL_HIGH>;
>> clocks = <&rxmacro>;
>> clock-names = "iface";
>> + resets = <&lpass_audiocc LPASS_AUDIO_SWR_RX_CGCR>;
>> + reset-names = "swr_audio_cgcr";
>> label = "RX";
>>
>> qcom,din-ports = <0>;
>> @@ -2634,6 +2637,8 @@
>> interrupts = <GIC_SPI 170 IRQ_TYPE_LEVEL_HIGH>;
>> clocks = <&wsamacro>;
>> clock-names = "iface";
>> + resets = <&lpass_audiocc LPASS_AUDIO_SWR_WSA_CGCR>;
>> + reset-names = "swr_audio_cgcr";
>> label = "WSA";
>>
>> qcom,din-ports = <2>;
>> @@ -2656,6 +2661,14 @@
>> status = "disabled";
>> };
>>
>> + lpass_audiocc: clock-controller@32a9000 {
>> + compatible = "qcom,sc8280xp-lpassaudiocc";
>> + reg = <0 0x032a9000 0 0x1000>;
>> + qcom,adsp-pil-mode;
>
> Here and...
>
>> + #clock-cells = <1>;
>> + #reset-cells = <1>;
>> + };
>> +
>> swr2: soundwire-controller@3330000 {
>> compatible = "qcom,soundwire-v1.6.0";
>> reg = <0 0x03330000 0 0x2000>;
>> @@ -2665,6 +2678,8 @@
>>
>> clocks = <&txmacro>;
>> clock-names = "iface";
>> + resets = <&lpasscc LPASS_AUDIO_SWR_TX_CGCR>;
>> + reset-names = "swr_audio_cgcr";
>> label = "TX";
>> #sound-dai-cells = <1>;
>> #address-cells = <2>;
>> @@ -2901,6 +2916,14 @@
>> };
>> };
>>
>> + lpasscc: clock-controller@33e0000 {
>> + compatible = "qcom,sc8280xp-lpasscc";
>> + reg = <0 0x033e0000 0 0x12000>;
>> + qcom,adsp-pil-mode;
>
> ... here - where do you use these properties? Driver ignores them.
Wil add a check in driver.
>
> AFAIR, these were only for sc7280 where we supported two variants for audio.
>
we can drop this property altogether, But having this flag will make
sure that the bindings are in a ready state to accommodate a new variant
of sc8280xp with dsp bypass.
--srini
> Best regards,
> Krzysztof
>
next prev parent reply other threads:[~2023-06-07 13:31 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-25 12:29 [PATCH v2 0/6] clk: qcom: sc8280xp: add lpasscc reset control Srinivas Kandagatla
2023-05-25 12:29 ` [PATCH v2 1/6] dt-bindings: clock: Add YAML schemas for LPASSCC and reset on SC8280XP Srinivas Kandagatla
2023-05-26 12:04 ` Johan Hovold
2023-06-02 13:17 ` Krzysztof Kozlowski
2023-05-25 12:29 ` [PATCH v2 2/6] dt-bindings: clock: Add YAML schemas for LPASS AUDIOCC " Srinivas Kandagatla
2023-05-26 12:08 ` Johan Hovold
[not found] ` <ebe8dc00-d937-240f-e9a5-e9049fd278ad@linaro.org>
2023-06-07 13:15 ` Srinivas Kandagatla
2023-05-25 12:29 ` [PATCH v2 3/6] clk: qcom: Add lpass clock controller driver for SC8280XP Srinivas Kandagatla
2023-05-26 12:12 ` Johan Hovold
2023-06-02 13:17 ` Krzysztof Kozlowski
[not found] ` <098883dd-f517-d541-de00-1a7fc0ada017@linaro.org>
2023-06-07 13:19 ` Srinivas Kandagatla
2023-05-25 12:29 ` [PATCH v2 4/6] clk: qcom: Add lpass audio " Srinivas Kandagatla
2023-05-26 12:14 ` Johan Hovold
2023-05-25 12:29 ` [PATCH v2 5/6] arm64: dts: qcom: sc8280xp: add resets for soundwire controllers Srinivas Kandagatla
2023-05-26 12:16 ` Johan Hovold
2023-06-02 13:18 ` Krzysztof Kozlowski
[not found] ` <542a67da-5870-dda0-3604-9367a438e51b@linaro.org>
2023-06-07 13:31 ` Srinivas Kandagatla [this message]
2023-05-25 12:29 ` [PATCH v2 6/6] arm64: defconfig: Enable sc828x0xp lpasscc clock controller Srinivas Kandagatla
2023-05-26 12:17 ` Johan Hovold
2023-06-02 13:18 ` Krzysztof Kozlowski
2023-06-02 13:39 ` Konrad Dybcio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fea749a7-ef17-097b-847a-d73f965c841b@linaro.org \
--to=srinivas.kandagatla@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=johan+linaro@kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).