From: Christoph Hellwig <hch@lst.de>
To: Jens Axboe <axboe@kernel.dk>
Cc: linux-raid@vger.kernel.org, linux-mm@kvack.org,
linux-bcache@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-block@vger.kernel.org, drbd-dev@tron.linbit.com,
dm-devel@redhat.com, Tejun Heo <tj@kernel.org>,
cgroups@vger.kernel.org, linux-btrfs@vger.kernel.org
Subject: [PATCH 1/4] drbd: remove a bogus bdi_rw_congested call
Date: Wed, 1 Jul 2020 11:06:19 +0200 [thread overview]
Message-ID: <20200701090622.3354860-2-hch@lst.de> (raw)
In-Reply-To: <20200701090622.3354860-1-hch@lst.de>
bdi_rw_congested returns congestion state, so calling it without
looking at the return value doesn't make much sense.
Signed-off-by: Christoph Hellwig <hch@lst.de>
---
drivers/block/drbd/drbd_proc.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/block/drbd/drbd_proc.c b/drivers/block/drbd/drbd_proc.c
index 1c41cd9982a257..3c0193de249830 100644
--- a/drivers/block/drbd/drbd_proc.c
+++ b/drivers/block/drbd/drbd_proc.c
@@ -265,7 +265,6 @@ int drbd_seq_show(struct seq_file *seq, void *v)
seq_printf(seq, "%2d: cs:Unconfigured\n", i);
} else {
/* reset device->congestion_reason */
- bdi_rw_congested(device->rq_queue->backing_dev_info);
nc = rcu_dereference(first_peer_device(device)->connection->net_conf);
wp = nc ? nc->wire_protocol - DRBD_PROT_A + 'A' : ' ';
--
2.26.2
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de>
To: Jens Axboe <axboe@kernel.dk>
Cc: Tejun Heo <tj@kernel.org>,
dm-devel@redhat.com, cgroups@vger.kernel.org,
linux-block@vger.kernel.org, drbd-dev@lists.linbit.com,
linux-bcache@vger.kernel.org, linux-raid@vger.kernel.org,
linux-btrfs@vger.kernel.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: [PATCH 1/4] drbd: remove a bogus bdi_rw_congested call
Date: Wed, 1 Jul 2020 11:06:19 +0200 [thread overview]
Message-ID: <20200701090622.3354860-2-hch@lst.de> (raw)
Message-ID: <20200701090619.CipGFBMvpsGT8SuSxLXbitegce_kzGQrxFTaOM3FrZI@z> (raw)
In-Reply-To: <20200701090622.3354860-1-hch@lst.de>
bdi_rw_congested returns congestion state, so calling it without
looking at the return value doesn't make much sense.
Signed-off-by: Christoph Hellwig <hch@lst.de>
---
drivers/block/drbd/drbd_proc.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/block/drbd/drbd_proc.c b/drivers/block/drbd/drbd_proc.c
index 1c41cd9982a257..3c0193de249830 100644
--- a/drivers/block/drbd/drbd_proc.c
+++ b/drivers/block/drbd/drbd_proc.c
@@ -265,7 +265,6 @@ int drbd_seq_show(struct seq_file *seq, void *v)
seq_printf(seq, "%2d: cs:Unconfigured\n", i);
} else {
/* reset device->congestion_reason */
- bdi_rw_congested(device->rq_queue->backing_dev_info);
nc = rcu_dereference(first_peer_device(device)->connection->net_conf);
wp = nc ? nc->wire_protocol - DRBD_PROT_A + 'A' : ' ';
--
2.26.2
next prev parent reply other threads:[~2020-07-01 9:06 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-01 9:06 remove dead bdi congestion leftovers Christoph Hellwig
2020-07-01 9:06 ` Christoph Hellwig
2020-07-01 9:06 ` Christoph Hellwig [this message]
2020-07-01 9:06 ` [PATCH 1/4] drbd: remove a bogus bdi_rw_congested call Christoph Hellwig
2020-07-01 9:06 ` [PATCH 2/4] writeback: remove {set,clear}_wb_congested Christoph Hellwig
2020-07-01 9:06 ` Christoph Hellwig
[not found] ` <20200701090622.3354860-1-hch-jcswGhMUV9g@public.gmane.org>
2020-07-01 9:06 ` [PATCH 3/4] writeback: remove struct bdi_writeback_congested Christoph Hellwig
2020-07-01 9:06 ` Christoph Hellwig
2020-07-01 16:38 ` remove dead bdi congestion leftovers Tejun Heo
2020-07-01 16:38 ` Tejun Heo
2020-07-08 23:14 ` Jens Axboe
2020-07-08 23:14 ` Jens Axboe
[not found] ` <b5d6df17-68af-d535-79e4-f95e16dd5632-tSWWG44O7X1aa/9Udqfwiw@public.gmane.org>
2020-07-09 5:32 ` Christoph Hellwig
2020-07-09 5:32 ` Christoph Hellwig
[not found] ` <20200709053233.GA3243-jcswGhMUV9g@public.gmane.org>
2020-07-09 13:58 ` Jens Axboe
2020-07-09 13:58 ` Jens Axboe
[not found] ` <82e2785d-2091-1986-0014-3b7cea7cd0d8-tSWWG44O7X1aa/9Udqfwiw@public.gmane.org>
2020-07-09 14:01 ` Christoph Hellwig
2020-07-09 14:01 ` Christoph Hellwig
2020-07-01 9:06 ` [PATCH 4/4] writeback: remove bdi->congested_fn Christoph Hellwig
2020-07-01 9:06 ` Christoph Hellwig
2020-07-01 14:48 ` David Sterba
2020-07-02 0:38 ` Coly Li
2020-07-02 0:38 ` Coly Li
[not found] ` <20200701090622.3354860-5-hch-jcswGhMUV9g@public.gmane.org>
2020-07-02 5:36 ` Song Liu
2020-07-02 5:36 ` Song Liu
2020-07-01 16:41 ` remove dead bdi congestion leftovers Mike Snitzer
2020-07-01 16:41 ` Mike Snitzer
2020-07-01 17:57 ` Matthew Wilcox
2020-07-01 17:57 ` Matthew Wilcox
2020-07-01 18:25 ` Matthew Wilcox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200701090622.3354860-2-hch@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=cgroups@vger.kernel.org \
--cc=dm-devel@redhat.com \
--cc=drbd-dev@tron.linbit.com \
--cc=linux-bcache@vger.kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-raid@vger.kernel.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).