From: Jens Axboe <axboe-tSWWG44O7X1aa/9Udqfwiw@public.gmane.org>
To: Christoph Hellwig <hch-jcswGhMUV9g@public.gmane.org>
Cc: linux-raid-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-bcache-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-block-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org,
dm-devel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org,
Tejun Heo <tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-btrfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
drbd-dev-cunTk1MwBs8qoQakbn7OcQ@public.gmane.org
Subject: Re: remove dead bdi congestion leftovers
Date: Wed, 8 Jul 2020 17:14:29 -0600 [thread overview]
Message-ID: <b5d6df17-68af-d535-79e4-f95e16dd5632@kernel.dk> (raw)
In-Reply-To: <20200701090622.3354860-1-hch-jcswGhMUV9g@public.gmane.org>
On 7/1/20 3:06 AM, Christoph Hellwig wrote:
> Hi Jens,
>
> we have a lot of bdi congestion related code that is left around without
> any use. This series removes it in preparation of sorting out the bdi
> lifetime rules properly.
Please run series like this through a full compilation, for both this one
and the previous series I had to fix up issues like this:
drivers/md/bcache/request.c: In function ‘bch_cached_dev_request_init’:
drivers/md/bcache/request.c:1233:18: warning: unused variable ‘g’ [-Wunused-variable]
1233 | struct gendisk *g = dc->disk.disk;
| ^
drivers/md/bcache/request.c: In function ‘bch_flash_dev_request_init’:
drivers/md/bcache/request.c:1320:18: warning: unused variable ‘g’ [-Wunused-variable]
1320 | struct gendisk *g = d->disk;
| ^
Did the same here, applied it.
--
Jens Axboe
_______________________________________________
drbd-dev mailing list
drbd-dev@lists.linbit.com
https://lists.linbit.com/mailman/listinfo/drbd-dev
WARNING: multiple messages have this Message-ID (diff)
From: Jens Axboe <axboe@kernel.dk>
To: Christoph Hellwig <hch@lst.de>
Cc: Tejun Heo <tj@kernel.org>,
dm-devel@redhat.com, cgroups@vger.kernel.org,
linux-block@vger.kernel.org, drbd-dev@lists.linbit.com,
linux-bcache@vger.kernel.org, linux-raid@vger.kernel.org,
linux-btrfs@vger.kernel.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: remove dead bdi congestion leftovers
Date: Wed, 8 Jul 2020 17:14:29 -0600 [thread overview]
Message-ID: <b5d6df17-68af-d535-79e4-f95e16dd5632@kernel.dk> (raw)
Message-ID: <20200708231429.mALefnisdWLYRPm77bflbcd6euMVQ1szP2UgzJ9RufY@z> (raw)
In-Reply-To: <20200701090622.3354860-1-hch@lst.de>
On 7/1/20 3:06 AM, Christoph Hellwig wrote:
> Hi Jens,
>
> we have a lot of bdi congestion related code that is left around without
> any use. This series removes it in preparation of sorting out the bdi
> lifetime rules properly.
Please run series like this through a full compilation, for both this one
and the previous series I had to fix up issues like this:
drivers/md/bcache/request.c: In function ‘bch_cached_dev_request_init’:
drivers/md/bcache/request.c:1233:18: warning: unused variable ‘g’ [-Wunused-variable]
1233 | struct gendisk *g = dc->disk.disk;
| ^
drivers/md/bcache/request.c: In function ‘bch_flash_dev_request_init’:
drivers/md/bcache/request.c:1320:18: warning: unused variable ‘g’ [-Wunused-variable]
1320 | struct gendisk *g = d->disk;
| ^
Did the same here, applied it.
--
Jens Axboe
next prev parent reply other threads:[~2020-07-08 23:14 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-01 9:06 remove dead bdi congestion leftovers Christoph Hellwig
2020-07-01 9:06 ` Christoph Hellwig
2020-07-01 9:06 ` [PATCH 1/4] drbd: remove a bogus bdi_rw_congested call Christoph Hellwig
2020-07-01 9:06 ` Christoph Hellwig
2020-07-01 9:06 ` [PATCH 2/4] writeback: remove {set,clear}_wb_congested Christoph Hellwig
2020-07-01 9:06 ` Christoph Hellwig
[not found] ` <20200701090622.3354860-1-hch-jcswGhMUV9g@public.gmane.org>
2020-07-01 9:06 ` [PATCH 3/4] writeback: remove struct bdi_writeback_congested Christoph Hellwig
2020-07-01 9:06 ` Christoph Hellwig
2020-07-01 16:38 ` remove dead bdi congestion leftovers Tejun Heo
2020-07-01 16:38 ` Tejun Heo
2020-07-08 23:14 ` Jens Axboe [this message]
2020-07-08 23:14 ` Jens Axboe
[not found] ` <b5d6df17-68af-d535-79e4-f95e16dd5632-tSWWG44O7X1aa/9Udqfwiw@public.gmane.org>
2020-07-09 5:32 ` Christoph Hellwig
2020-07-09 5:32 ` Christoph Hellwig
[not found] ` <20200709053233.GA3243-jcswGhMUV9g@public.gmane.org>
2020-07-09 13:58 ` Jens Axboe
2020-07-09 13:58 ` Jens Axboe
[not found] ` <82e2785d-2091-1986-0014-3b7cea7cd0d8-tSWWG44O7X1aa/9Udqfwiw@public.gmane.org>
2020-07-09 14:01 ` Christoph Hellwig
2020-07-09 14:01 ` Christoph Hellwig
2020-07-01 9:06 ` [PATCH 4/4] writeback: remove bdi->congested_fn Christoph Hellwig
2020-07-01 9:06 ` Christoph Hellwig
2020-07-01 14:48 ` David Sterba
2020-07-02 0:38 ` Coly Li
2020-07-02 0:38 ` Coly Li
[not found] ` <20200701090622.3354860-5-hch-jcswGhMUV9g@public.gmane.org>
2020-07-02 5:36 ` Song Liu
2020-07-02 5:36 ` Song Liu
2020-07-01 16:41 ` remove dead bdi congestion leftovers Mike Snitzer
2020-07-01 16:41 ` Mike Snitzer
2020-07-01 17:57 ` Matthew Wilcox
2020-07-01 17:57 ` Matthew Wilcox
2020-07-01 18:25 ` Matthew Wilcox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b5d6df17-68af-d535-79e4-f95e16dd5632@kernel.dk \
--to=axboe-tswwg44o7x1aa/9udqfwiw@public.gmane.org \
--cc=cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=dm-devel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=drbd-dev-cunTk1MwBs8qoQakbn7OcQ@public.gmane.org \
--cc=hch-jcswGhMUV9g@public.gmane.org \
--cc=linux-bcache-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-block-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-btrfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org \
--cc=linux-raid-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).