From: Hannes Reinecke <hare@suse.de>
To: colyli@suse.de, axboe@kernel.dk
Cc: linux-bcache@vger.kernel.org, linux-block@vger.kernel.org
Subject: Re: [PATCH 3/4] bcache: use delayed kworker fo asynchronous devices registration
Date: Mon, 15 Jun 2020 08:12:46 +0200 [thread overview]
Message-ID: <9bd21fc5-2666-e239-3da1-dc51c3ca2e49@suse.de> (raw)
In-Reply-To: <20200614165333.124999-4-colyli@suse.de>
On 6/14/20 6:53 PM, colyli@suse.de wrote:
> From: Coly Li <colyli@suse.de>
>
> This patch changes the asynchronous registration kworker to a delayed
> kworker. There is probability queue_work() queues the async registration
> kworker to the same CPU (even though very little), then the process
> which writing sysfs interface to reigster bcache device may won't return
> immeidately. queue_delayed_work() in this patch will delay 10 jiffies
> before insert the kworker to run queue, which makes sure the registering
> process may always returns to user space in time.
>
> Fixes: 9e23ccf8f0a22 ("bcache: asynchronous devices registration")
> Signed-off-by: Coly Li <colyli@suse.de>
> Cc: Hannes Reinecke <hare@suse.de>
> ---
> drivers/md/bcache/super.c | 14 ++++++++------
> 1 file changed, 8 insertions(+), 6 deletions(-)
>
Reviewed-by: Hannes Reinecke <hare@suse.de>
Cheers,
Hannes
--
Dr. Hannes Reinecke Teamlead Storage & Networking
hare@suse.de +49 911 74053 688
SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg
HRB 36809 (AG Nürnberg), Geschäftsführer: Felix Imendörffer
next prev parent reply other threads:[~2020-06-15 6:12 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-14 16:53 [PATCH 0/4] bcache: more fixes for v5.8-rc1 colyli
2020-06-14 16:53 ` colyli
2020-06-14 16:53 ` [PATCH 1/4] bcache: fix potential deadlock problem in btree_gc_coalesce colyli
2020-06-14 16:53 ` [PATCH 2/4] bcache: check and adjust logical block size for backing devices colyli
2020-06-14 16:53 ` [PATCH 3/4] bcache: use delayed kworker fo asynchronous devices registration colyli
2020-06-14 16:53 ` colyli
2020-06-15 6:12 ` Hannes Reinecke [this message]
2020-06-15 6:12 ` Hannes Reinecke
2020-06-14 16:53 ` [PATCH 4/4] bcache: pr_info() format clean up in bcache_device_init() colyli
2020-06-14 16:53 ` colyli
2020-06-14 22:48 ` [PATCH 0/4] bcache: more fixes for v5.8-rc1 Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9bd21fc5-2666-e239-3da1-dc51c3ca2e49@suse.de \
--to=hare@suse.de \
--cc=axboe@kernel.dk \
--cc=colyli@suse.de \
--cc=linux-bcache@vger.kernel.org \
--cc=linux-block@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).