From: colyli@suse.de
To: axboe@kernel.dk
Cc: linux-bcache@vger.kernel.org, linux-block@vger.kernel.org,
Coly Li <colyli@suse.de>
Subject: [PATCH 4/4] bcache: pr_info() format clean up in bcache_device_init()
Date: Mon, 15 Jun 2020 00:53:33 +0800 [thread overview]
Message-ID: <20200614165333.124999-5-colyli@suse.de> (raw)
Message-ID: <20200614165333.0OfLxloCkasmDVz-xJcYWNY1Md3oX-YTUxmCiKUAndA@z> (raw)
In-Reply-To: <20200614165333.124999-1-colyli@suse.de>
From: Coly Li <colyli@suse.de>
scripts/checkpatch.pl reports following warning for patch
("bcache: check and adjust logical block size for backing devices"),
WARNING: quoted string split across lines
#146: FILE: drivers/md/bcache/super.c:896:
+ pr_info("%s: sb/logical block size (%u) greater than page size "
+ "(%lu) falling back to device logical block size (%u)",
There are two things to fix up,
- The kernel message print should be in a single line.
- pr_info() won't automatically add new line since v5.8, a '\n' should
be added.
This patch just does the above cleanup in bcache_device_init().
Signed-off-by: Coly Li <colyli@suse.de>
---
drivers/md/bcache/super.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/md/bcache/super.c b/drivers/md/bcache/super.c
index a6e79083010a..2014016f9a60 100644
--- a/drivers/md/bcache/super.c
+++ b/drivers/md/bcache/super.c
@@ -893,8 +893,7 @@ static int bcache_device_init(struct bcache_device *d, unsigned int block_size,
* This should only happen with BCACHE_SB_VERSION_BDEV.
* Block/page size is checked for BCACHE_SB_VERSION_CDEV.
*/
- pr_info("%s: sb/logical block size (%u) greater than page size "
- "(%lu) falling back to device logical block size (%u)",
+ pr_info("%s: sb/logical block size (%u) greater than page size (%lu) falling back to device logical block size (%u)\n",
d->disk->disk_name, q->limits.logical_block_size,
PAGE_SIZE, bdev_logical_block_size(cached_bdev));
--
2.25.0
next prev parent reply other threads:[~2020-06-14 16:53 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-14 16:53 [PATCH 0/4] bcache: more fixes for v5.8-rc1 colyli
2020-06-14 16:53 ` colyli
2020-06-14 16:53 ` [PATCH 1/4] bcache: fix potential deadlock problem in btree_gc_coalesce colyli
2020-06-14 16:53 ` [PATCH 2/4] bcache: check and adjust logical block size for backing devices colyli
2020-06-14 16:53 ` [PATCH 3/4] bcache: use delayed kworker fo asynchronous devices registration colyli
2020-06-14 16:53 ` colyli
2020-06-15 6:12 ` Hannes Reinecke
2020-06-15 6:12 ` Hannes Reinecke
2020-06-14 16:53 ` colyli [this message]
2020-06-14 16:53 ` [PATCH 4/4] bcache: pr_info() format clean up in bcache_device_init() colyli
2020-06-14 22:48 ` [PATCH 0/4] bcache: more fixes for v5.8-rc1 Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200614165333.124999-5-colyli@suse.de \
--to=colyli@suse.de \
--cc=axboe@kernel.dk \
--cc=linux-bcache@vger.kernel.org \
--cc=linux-block@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).