From: Theodore Ts'o <tytso@mit.edu>
To: Dave Chinner <david@fromorbit.com>
Cc: "Luis R. Rodriguez" <mcgrof@kernel.org>,
viro@zeniv.linux.org.uk, bart.vanassche@wdc.com,
ming.lei@redhat.com, darrick.wong@oracle.com, jikos@kernel.org,
rjw@rjwysocki.net, pavel@ucw.cz, len.brown@intel.com,
linux-fsdevel@vger.kernel.org, boris.ostrovsky@oracle.com,
jgross@suse.com, todd.e.brandt@linux.intel.com,
nborisov@suse.com, jack@suse.cz, martin.petersen@oracle.com,
ONeukum@suse.com, oleksandr@natalenko.name,
oleg.b.antonyan@gmail.com, linux-pm@vger.kernel.org,
linux-block@vger.kernel.org, linux-xfs@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [RFC 4/5] ext4: add fs freezing support on suspend/hibernation
Date: Wed, 4 Oct 2017 12:48:39 -0400 [thread overview]
Message-ID: <20171004164839.zyfpx64qmmfv2jtx@thunk.org> (raw)
In-Reply-To: <20171004070523.GE3666@dastard>
On Wed, Oct 04, 2017 at 06:05:23PM +1100, Dave Chinner wrote:
> Basically, before thawing filesystems the rest of the kernel
> infrastructure needs to have been restarted. i.e. the order
> needs to be:
>
> freeze userspace
> freeze filesystems
> freeze kernel threads
> freeze workqueues
>
> thaw workqueues
> thaw kernel threads
> thaw filesystems
> thaw userspace
>
> and it should end up that way.
>
> > Or if we have a network block device, or
> > something else in the storage stack that needs to run a kernel thread
> > context (or a workqueue, etc.) --- is the fact that userspace is
> > frozen mean the scheduler is going to refuse to schedule()?
>
> No.
Well, that's what the answer *should* be. I was asking what this
patch series does, and given that Luis reported that with this patch
series ext4_commit_super(sb, 1) is hanging, I have my suspicions about
what the answer might be with this patch set. (Especially since the
claimed goal of the patch set is, "kthread freezing with filesystem
freeze/thaw".
Cheers,
- Ted
next prev parent reply other threads:[~2017-10-04 16:48 UTC|newest]
Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-03 18:53 [RFC 0/5] fs: replace kthread freezing with filesystem freeze/thaw Luis R. Rodriguez
2017-10-03 18:53 ` [RFC 1/5] fs: add iterate_supers_reverse() Luis R. Rodriguez
2017-10-03 18:53 ` [RFC 2/5] fs: freeze on suspend and thaw on resume Luis R. Rodriguez
2017-10-03 20:02 ` Bart Van Assche
2017-10-03 20:23 ` Luis R. Rodriguez
2017-10-03 20:32 ` Bart Van Assche
2017-10-03 20:39 ` Luis R. Rodriguez
2017-10-03 20:06 ` Jiri Kosina
2017-10-03 20:58 ` Dave Chinner
2017-10-03 21:16 ` Luis R. Rodriguez
2017-10-03 18:53 ` [RFC 3/5] xfs: allow fs freeze on suspend/hibernation Luis R. Rodriguez
2017-10-03 18:53 ` [RFC 4/5] ext4: add fs freezing support " Luis R. Rodriguez
2017-10-03 19:59 ` Theodore Ts'o
2017-10-03 20:13 ` Luis R. Rodriguez
2017-10-04 1:42 ` Theodore Ts'o
2017-10-04 7:05 ` Dave Chinner
2017-10-04 15:25 ` Bart Van Assche
2017-10-04 16:48 ` Theodore Ts'o [this message]
2017-10-04 22:22 ` Dave Chinner
2017-10-03 18:53 ` [RFC 5/5] pm: remove kernel thread freezing Luis R. Rodriguez
2017-10-03 18:59 ` Rafael J. Wysocki
2017-10-03 21:15 ` Rafael J. Wysocki
2017-10-04 0:47 ` Luis R. Rodriguez
2017-10-04 1:03 ` Bart Van Assche
2017-11-29 23:05 ` Luis R. Rodriguez
2017-10-04 7:18 ` Dave Chinner
2017-10-03 20:12 ` Pavel Machek
2017-10-03 20:15 ` Jiri Kosina
2017-10-03 20:21 ` Pavel Machek
2017-10-03 20:38 ` Jiri Kosina
2017-10-03 20:41 ` Rafael J. Wysocki
2017-10-03 20:57 ` Pavel Machek
2017-10-03 21:00 ` Jiri Kosina
2017-10-03 21:09 ` Shuah Khan
2017-10-03 21:18 ` Luis R. Rodriguez
2017-10-03 20:49 ` Luis R. Rodriguez
2017-10-06 12:07 ` Pavel Machek
2017-10-06 12:54 ` Theodore Ts'o
2017-10-03 20:13 ` Bart Van Assche
2017-10-03 20:17 ` Jiri Kosina
2017-10-03 20:21 ` Bart Van Assche
2017-10-03 20:24 ` Jiri Kosina
2017-10-03 20:27 ` Luis R. Rodriguez
2017-10-03 20:51 ` Jiri Kosina
2017-10-03 21:04 ` Dave Chinner
2017-10-03 21:07 ` Luis R. Rodriguez
2017-10-04 6:07 ` Hannes Reinecke
2017-10-03 19:33 ` [RFC 0/5] fs: replace kthread freezing with filesystem freeze/thaw Ming Lei
2017-10-03 20:05 ` Luis R. Rodriguez
2017-10-03 20:47 ` Matthew Wilcox
2017-10-03 20:54 ` Luis R. Rodriguez
2017-10-03 20:59 ` Bart Van Assche
2017-10-04 15:43 ` Ming Lei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171004164839.zyfpx64qmmfv2jtx@thunk.org \
--to=tytso@mit.edu \
--cc=ONeukum@suse.com \
--cc=bart.vanassche@wdc.com \
--cc=boris.ostrovsky@oracle.com \
--cc=darrick.wong@oracle.com \
--cc=david@fromorbit.com \
--cc=jack@suse.cz \
--cc=jgross@suse.com \
--cc=jikos@kernel.org \
--cc=len.brown@intel.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=mcgrof@kernel.org \
--cc=ming.lei@redhat.com \
--cc=nborisov@suse.com \
--cc=oleg.b.antonyan@gmail.com \
--cc=oleksandr@natalenko.name \
--cc=pavel@ucw.cz \
--cc=rjw@rjwysocki.net \
--cc=todd.e.brandt@linux.intel.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).