* [PATCH] block: Move tag field position in struct request
@ 2019-04-28 7:48 Minwoo Im
2019-04-28 12:03 ` Christoph Hellwig
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Minwoo Im @ 2019-04-28 7:48 UTC (permalink / raw)
To: linux-block; +Cc: Jens Axboe, Minwoo Im
__data_len and __sector are internal fields which should not be accessed
directly in driver-level like the comment above it. But, tag field can
be accessed by driver level directly so that we need to make the comment
right by moving it to some other place.
Signed-off-by: Minwoo Im <minwoo.im.dev@gmail.com>
---
include/linux/blkdev.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/linux/blkdev.h b/include/linux/blkdev.h
index 317ab30d2904..639ca948d644 100644
--- a/include/linux/blkdev.h
+++ b/include/linux/blkdev.h
@@ -137,11 +137,11 @@ struct request {
unsigned int cmd_flags; /* op and common flags */
req_flags_t rq_flags;
+ int tag;
int internal_tag;
/* the following two fields are internal, NEVER access directly */
unsigned int __data_len; /* total data len */
- int tag;
sector_t __sector; /* sector cursor */
struct bio *bio;
--
2.17.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] block: Move tag field position in struct request
2019-04-28 7:48 [PATCH] block: Move tag field position in struct request Minwoo Im
@ 2019-04-28 12:03 ` Christoph Hellwig
2019-04-29 3:16 ` Chaitanya Kulkarni
2019-05-13 16:55 ` Minwoo Im
2 siblings, 0 replies; 4+ messages in thread
From: Christoph Hellwig @ 2019-04-28 12:03 UTC (permalink / raw)
To: Minwoo Im; +Cc: linux-block, Jens Axboe
Looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] block: Move tag field position in struct request
2019-04-28 7:48 [PATCH] block: Move tag field position in struct request Minwoo Im
2019-04-28 12:03 ` Christoph Hellwig
@ 2019-04-29 3:16 ` Chaitanya Kulkarni
2019-05-13 16:55 ` Minwoo Im
2 siblings, 0 replies; 4+ messages in thread
From: Chaitanya Kulkarni @ 2019-04-29 3:16 UTC (permalink / raw)
To: Minwoo Im, linux-block; +Cc: Jens Axboe
If Jens is okay with this change then :-
Reviewed-by : Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>.
On 4/28/19 12:48 AM, Minwoo Im wrote:
> __data_len and __sector are internal fields which should not be accessed
> directly in driver-level like the comment above it. But, tag field can
> be accessed by driver level directly so that we need to make the comment
> right by moving it to some other place.
>
> Signed-off-by: Minwoo Im <minwoo.im.dev@gmail.com>
> ---
> include/linux/blkdev.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/linux/blkdev.h b/include/linux/blkdev.h
> index 317ab30d2904..639ca948d644 100644
> --- a/include/linux/blkdev.h
> +++ b/include/linux/blkdev.h
> @@ -137,11 +137,11 @@ struct request {
> unsigned int cmd_flags; /* op and common flags */
> req_flags_t rq_flags;
>
> + int tag;
> int internal_tag;
>
> /* the following two fields are internal, NEVER access directly */
> unsigned int __data_len; /* total data len */
> - int tag;
> sector_t __sector; /* sector cursor */
>
> struct bio *bio;
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] block: Move tag field position in struct request
2019-04-28 7:48 [PATCH] block: Move tag field position in struct request Minwoo Im
2019-04-28 12:03 ` Christoph Hellwig
2019-04-29 3:16 ` Chaitanya Kulkarni
@ 2019-05-13 16:55 ` Minwoo Im
2 siblings, 0 replies; 4+ messages in thread
From: Minwoo Im @ 2019-05-13 16:55 UTC (permalink / raw)
To: linux-block; +Cc: Jens Axboe
On 19-04-28 16:48:03, Minwoo Im wrote:
> __data_len and __sector are internal fields which should not be accessed
> directly in driver-level like the comment above it. But, tag field can
> be accessed by driver level directly so that we need to make the comment
> right by moving it to some other place.
>
> Signed-off-by: Minwoo Im <minwoo.im.dev@gmail.com>
Ping here :)
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-05-13 16:55 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-04-28 7:48 [PATCH] block: Move tag field position in struct request Minwoo Im
2019-04-28 12:03 ` Christoph Hellwig
2019-04-29 3:16 ` Chaitanya Kulkarni
2019-05-13 16:55 ` Minwoo Im
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).