From: Fam Zheng <fam@euphon.net>
To: Jens Axboe <axboe@kernel.dk>
Cc: Paolo Valente <paolo.valente@linaro.org>,
Tejun Heo <tj@kernel.org>, Fam Zheng <zhengfeiran@bytedance.com>,
linux-kernel <linux-kernel@vger.kernel.org>,
duanxiongchun@bytedance.com, linux-block@vger.kernel.org,
cgroups@vger.kernel.org, zhangjiachen.jc@bytedance.com
Subject: Re: [PATCH v2 3/3] bfq: Add per-device weight
Date: Wed, 28 Aug 2019 11:50:55 +0800 [thread overview]
Message-ID: <20190828035055.GA16893@magic> (raw)
In-Reply-To: <fff76a58-65e7-7060-0329-aef15c422639@kernel.dk>
On Mon, 08/26 07:59, Jens Axboe wrote:
> On 8/26/19 12:36 AM, Paolo Valente wrote:
> > Hi Jens,
> > do you think this series could now be queued for 5.4?
>
> The most glaring oversight in this series, is that the meat of it,
> patch #3, doesn't even have a commit message. The cover letter
> essentially looks like it should have been the commit message for
> that patch.
>
> Please resend with acks/reviews collected, and ensure that all
> patches have a reasonable commit message.
Will do. Thanks!
Fam
next prev parent reply other threads:[~2019-08-28 4:06 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-05 6:38 [PATCH v2 0/3] Implement BFQ per-device weight interface Fam Zheng
2019-08-05 6:38 ` [PATCH v2 1/3] bfq: Fix the missing barrier in __bfq_entity_update_weight_prio Fam Zheng
2019-08-05 6:38 ` [PATCH v2 2/3] bfq: Extract bfq_group_set_weight from bfq_io_set_weight_legacy Fam Zheng
2019-08-05 6:38 ` [PATCH v2 3/3] bfq: Add per-device weight Fam Zheng
2019-08-21 15:44 ` Tejun Heo
2019-08-26 6:36 ` Paolo Valente
2019-08-26 13:59 ` Jens Axboe
2019-08-28 3:50 ` Fam Zheng [this message]
2019-08-05 15:08 ` [PATCH v2 0/3] Implement BFQ per-device weight interface Paolo Valente
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190828035055.GA16893@magic \
--to=fam@euphon.net \
--cc=axboe@kernel.dk \
--cc=cgroups@vger.kernel.org \
--cc=duanxiongchun@bytedance.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=paolo.valente@linaro.org \
--cc=tj@kernel.org \
--cc=zhangjiachen.jc@bytedance.com \
--cc=zhengfeiran@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).