From: Paolo Valente <paolo.valente@linaro.org>
To: Fam Zheng <zhengfeiran@bytedance.com>
Cc: kernel list <linux-kernel@vger.kernel.org>,
Jens Axboe <axboe@kernel.dk>, Fam Zheng <fam@euphon.net>,
duanxiongchun@bytedance.com,
linux-block <linux-block@vger.kernel.org>,
tj@kernel.org, cgroups@vger.kernel.org,
zhangjiachen.jc@bytedance.com
Subject: Re: [PATCH v2 0/3] Implement BFQ per-device weight interface
Date: Mon, 5 Aug 2019 17:08:36 +0200 [thread overview]
Message-ID: <A6E36505-16B1-4E6D-BCA8-53E5FD4AEE98@linaro.org> (raw)
In-Reply-To: <20190805063807.9494-1-zhengfeiran@bytedance.com>
Thank you very much, Fam, for this extension.
Reviewed-by: Paolo Valente <paolo.valente@linaro.org>
> Il giorno 5 ago 2019, alle ore 08:38, Fam Zheng <zhengfeiran@bytedance.com> ha scritto:
>
> (Revision starting from v2 since v1 was used off-list)
>
> Hi Paolo and others,
>
> This adds to BFQ the missing per-device weight interfaces:
> blkio.bfq.weight_device on legacy and io.bfq.weight on unified. The
> implementation pretty closely resembles what we had in CFQ and the parsing code
> is basically reused.
>
> Tests
> =====
>
> Using two cgroups and three block devices, having weights setup as:
>
> Cgroup test1 test2
> ============================================
> default 100 500
> sda 500 100
> sdb default default
> sdc 200 200
>
> cgroup v1 runs
> --------------
>
> sda.test1.out: READ: bw=913MiB/s
> sda.test2.out: READ: bw=183MiB/s
>
> sdb.test1.out: READ: bw=213MiB/s
> sdb.test2.out: READ: bw=1054MiB/s
>
> sdc.test1.out: READ: bw=650MiB/s
> sdc.test2.out: READ: bw=650MiB/s
>
> cgroup v2 runs
> --------------
>
> sda.test1.out: READ: bw=915MiB/s
> sda.test2.out: READ: bw=184MiB/s
>
> sdb.test1.out: READ: bw=216MiB/s
> sdb.test2.out: READ: bw=1069MiB/s
>
> sdc.test1.out: READ: bw=621MiB/s
> sdc.test2.out: READ: bw=622MiB/s
>
> Fam Zheng (3):
> bfq: Fix the missing barrier in __bfq_entity_update_weight_prio
> bfq: Extract bfq_group_set_weight from bfq_io_set_weight_legacy
> bfq: Add per-device weight
>
> block/bfq-cgroup.c | 151 +++++++++++++++++++++++++++++++++++++++-------------
> block/bfq-iosched.h | 3 ++
> block/bfq-wf2q.c | 2 +
> 3 files changed, 119 insertions(+), 37 deletions(-)
>
> --
> 2.11.0
>
prev parent reply other threads:[~2019-08-05 15:08 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-05 6:38 [PATCH v2 0/3] Implement BFQ per-device weight interface Fam Zheng
2019-08-05 6:38 ` [PATCH v2 1/3] bfq: Fix the missing barrier in __bfq_entity_update_weight_prio Fam Zheng
2019-08-05 6:38 ` [PATCH v2 2/3] bfq: Extract bfq_group_set_weight from bfq_io_set_weight_legacy Fam Zheng
2019-08-05 6:38 ` [PATCH v2 3/3] bfq: Add per-device weight Fam Zheng
2019-08-21 15:44 ` Tejun Heo
2019-08-26 6:36 ` Paolo Valente
2019-08-26 13:59 ` Jens Axboe
2019-08-28 3:50 ` Fam Zheng
2019-08-05 15:08 ` Paolo Valente [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=A6E36505-16B1-4E6D-BCA8-53E5FD4AEE98@linaro.org \
--to=paolo.valente@linaro.org \
--cc=axboe@kernel.dk \
--cc=cgroups@vger.kernel.org \
--cc=duanxiongchun@bytedance.com \
--cc=fam@euphon.net \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tj@kernel.org \
--cc=zhangjiachen.jc@bytedance.com \
--cc=zhengfeiran@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).