[PATCH] bfq: don't duplicate code for different paths

[PATCH] bfq: don't duplicate code for different paths

[huhai]

As we can see, returns parent_sched_may_change whether
sd->next_in_service changes or not, so remove this judgment.

Signed-off-by: huhai <huhai@tj.kylinos.cn>
---
 block/bfq-wf2q.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/block/bfq-wf2q.c b/block/bfq-wf2q.c
index 26776bdbdf36..070e34a7feb1 100644
--- a/block/bfq-wf2q.c
+++ b/block/bfq-wf2q.c
@@ -137,9 +137,6 @@ static bool bfq_update_next_in_service(struct bfq_sched_data *sd,
 
 	sd->next_in_service = next_in_service;
 
-	if (!next_in_service)
-		return parent_sched_may_change;
-
 	return parent_sched_may_change;
 }
 
-- 
2.20.1

Re: [PATCH] bfq: don't duplicate code for different paths

[Paolo Valente]

> Il giorno 25 dic 2020, alle ore 14:00, huhai <huhai@tj.kylinos.cn> ha scritto:
> 
> As we can see, returns parent_sched_may_change whether
> sd->next_in_service changes or not, so remove this judgment.
> 

Thank you very much for spotting this mistake!

Acked-by: Paolo Valente <paolo.valente@linaro.org>

> Signed-off-by: huhai <huhai@tj.kylinos.cn>
> ---
> block/bfq-wf2q.c | 3 ---
> 1 file changed, 3 deletions(-)
> 
> diff --git a/block/bfq-wf2q.c b/block/bfq-wf2q.c
> index 26776bdbdf36..070e34a7feb1 100644
> --- a/block/bfq-wf2q.c
> +++ b/block/bfq-wf2q.c
> @@ -137,9 +137,6 @@ static bool bfq_update_next_in_service(struct bfq_sched_data *sd,
> 
> 	sd->next_in_service = next_in_service;
> 
> -	if (!next_in_service)
> -		return parent_sched_may_change;
> -
> 	return parent_sched_may_change;
> }
> 
> -- 
> 2.20.1
> 
> 
> 

Re: [PATCH] bfq: don't duplicate code for different paths

[Jens Axboe]

On 12/25/20 6:00 AM, huhai wrote:
> As we can see, returns parent_sched_may_change whether
> sd->next_in_service changes or not, so remove this judgment.

Applied, thanks.

-- 
Jens Axboe