* [PATCH] bfq: don't duplicate code for different paths
@ 2020-12-25 13:00 huhai
2021-01-22 9:56 ` Paolo Valente
2021-01-25 1:20 ` Jens Axboe
0 siblings, 2 replies; 3+ messages in thread
From: huhai @ 2020-12-25 13:00 UTC (permalink / raw)
To: axboe, paolo.valente; +Cc: linux-block, huhai
As we can see, returns parent_sched_may_change whether
sd->next_in_service changes or not, so remove this judgment.
Signed-off-by: huhai <huhai@tj.kylinos.cn>
---
block/bfq-wf2q.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/block/bfq-wf2q.c b/block/bfq-wf2q.c
index 26776bdbdf36..070e34a7feb1 100644
--- a/block/bfq-wf2q.c
+++ b/block/bfq-wf2q.c
@@ -137,9 +137,6 @@ static bool bfq_update_next_in_service(struct bfq_sched_data *sd,
sd->next_in_service = next_in_service;
- if (!next_in_service)
- return parent_sched_may_change;
-
return parent_sched_may_change;
}
--
2.20.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] bfq: don't duplicate code for different paths
2020-12-25 13:00 [PATCH] bfq: don't duplicate code for different paths huhai
@ 2021-01-22 9:56 ` Paolo Valente
2021-01-25 1:20 ` Jens Axboe
1 sibling, 0 replies; 3+ messages in thread
From: Paolo Valente @ 2021-01-22 9:56 UTC (permalink / raw)
To: huhai; +Cc: axboe, linux-block
> Il giorno 25 dic 2020, alle ore 14:00, huhai <huhai@tj.kylinos.cn> ha scritto:
>
> As we can see, returns parent_sched_may_change whether
> sd->next_in_service changes or not, so remove this judgment.
>
Thank you very much for spotting this mistake!
Acked-by: Paolo Valente <paolo.valente@linaro.org>
> Signed-off-by: huhai <huhai@tj.kylinos.cn>
> ---
> block/bfq-wf2q.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/block/bfq-wf2q.c b/block/bfq-wf2q.c
> index 26776bdbdf36..070e34a7feb1 100644
> --- a/block/bfq-wf2q.c
> +++ b/block/bfq-wf2q.c
> @@ -137,9 +137,6 @@ static bool bfq_update_next_in_service(struct bfq_sched_data *sd,
>
> sd->next_in_service = next_in_service;
>
> - if (!next_in_service)
> - return parent_sched_may_change;
> -
> return parent_sched_may_change;
> }
>
> --
> 2.20.1
>
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] bfq: don't duplicate code for different paths
2020-12-25 13:00 [PATCH] bfq: don't duplicate code for different paths huhai
2021-01-22 9:56 ` Paolo Valente
@ 2021-01-25 1:20 ` Jens Axboe
1 sibling, 0 replies; 3+ messages in thread
From: Jens Axboe @ 2021-01-25 1:20 UTC (permalink / raw)
To: huhai, paolo.valente; +Cc: linux-block
On 12/25/20 6:00 AM, huhai wrote:
> As we can see, returns parent_sched_may_change whether
> sd->next_in_service changes or not, so remove this judgment.
Applied, thanks.
--
Jens Axboe
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-01-25 1:25 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-12-25 13:00 [PATCH] bfq: don't duplicate code for different paths huhai
2021-01-22 9:56 ` Paolo Valente
2021-01-25 1:20 ` Jens Axboe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).