From: Oleksandr Natalenko <oleksandr@natalenko.name>
To: Paolo Valente <paolo.valente@linaro.org>
Cc: Chunguang Xu <brookxu.cn@gmail.com>,
axboe@kernel.dk, linux-block@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] bfq: remove some useless logic of bfq_update_next_in_service()
Date: Wed, 10 Feb 2021 16:20:34 +0100 [thread overview]
Message-ID: <20210210152034.puimoewzgtnnp2zl@spock.localdomain> (raw)
In-Reply-To: <B4751549-78D9-4A84-8FB2-5DAA86ED39C8@linaro.org>
On Wed, Feb 10, 2021 at 12:13:29PM +0100, Paolo Valente wrote:
>
>
> > Il giorno 29 gen 2021, alle ore 11:51, Chunguang Xu <brookxu.cn@gmail.com> ha scritto:
> >
> > From: Chunguang Xu <brookxu@tencent.com>
> >
> > The if statement at the end of the function is obviously useless,
> > maybe we can delete it.
> >
>
> Thanks for spotting this mistake.
>
> Acked-by: Paolo Valente <paolo.valente@linaro.org>
>
> > Signed-off-by: Chunguang Xu <brookxu@tencent.com>
> > ---
> > block/bfq-wf2q.c | 3 ---
> > 1 file changed, 3 deletions(-)
> >
> > diff --git a/block/bfq-wf2q.c b/block/bfq-wf2q.c
> > index 26776bd..070e34a 100644
> > --- a/block/bfq-wf2q.c
> > +++ b/block/bfq-wf2q.c
> > @@ -137,9 +137,6 @@ static bool bfq_update_next_in_service(struct bfq_sched_data *sd,
> >
> > sd->next_in_service = next_in_service;
> >
> > - if (!next_in_service)
> > - return parent_sched_may_change;
> > -
Unless I'm missing something, this has already been fixed here:
https://git.kernel.dk/cgit/linux-block/commit/?h=for-5.12/block&id=1a23e06cdab2be07cbda460c6417d7de564c48e6
> > return parent_sched_may_change;
> > }
> >
> > --
> > 1.8.3.1
> >
>
--
Oleksandr Natalenko (post-factum)
next prev parent reply other threads:[~2021-02-10 15:21 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1611917485-584-1-git-send-email-brookxu@tencent.com>
2021-02-10 11:13 ` [PATCH 1/2] bfq: remove some useless logic of bfq_update_next_in_service() Paolo Valente
2021-02-10 15:20 ` Oleksandr Natalenko [this message]
2021-02-10 15:21 ` Jens Axboe
2021-02-10 15:54 ` Paolo Valente
[not found] ` <1611917485-584-2-git-send-email-brookxu@tencent.com>
2021-02-10 11:13 ` [PATCH 2/2] bfq: amend the function name of bfq_may_expire_for_budg_timeout() Paolo Valente
2021-02-10 15:37 ` Oleksandr Natalenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210210152034.puimoewzgtnnp2zl@spock.localdomain \
--to=oleksandr@natalenko.name \
--cc=axboe@kernel.dk \
--cc=brookxu.cn@gmail.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=paolo.valente@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).