linux-block.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Paolo Valente <paolo.valente@linaro.org>
To: Chunguang Xu <brookxu.cn@gmail.com>
Cc: axboe@kernel.dk, linux-block@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] bfq: remove some useless logic of bfq_update_next_in_service()
Date: Wed, 10 Feb 2021 12:13:29 +0100	[thread overview]
Message-ID: <B4751549-78D9-4A84-8FB2-5DAA86ED39C8@linaro.org> (raw)
In-Reply-To: <1611917485-584-1-git-send-email-brookxu@tencent.com>



> Il giorno 29 gen 2021, alle ore 11:51, Chunguang Xu <brookxu.cn@gmail.com> ha scritto:
> 
> From: Chunguang Xu <brookxu@tencent.com>
> 
> The if statement at the end of the function is obviously useless,
> maybe we can delete it.
> 

Thanks for spotting this mistake.

Acked-by: Paolo Valente <paolo.valente@linaro.org>

> Signed-off-by: Chunguang Xu <brookxu@tencent.com>
> ---
> block/bfq-wf2q.c | 3 ---
> 1 file changed, 3 deletions(-)
> 
> diff --git a/block/bfq-wf2q.c b/block/bfq-wf2q.c
> index 26776bd..070e34a 100644
> --- a/block/bfq-wf2q.c
> +++ b/block/bfq-wf2q.c
> @@ -137,9 +137,6 @@ static bool bfq_update_next_in_service(struct bfq_sched_data *sd,
> 
> 	sd->next_in_service = next_in_service;
> 
> -	if (!next_in_service)
> -		return parent_sched_may_change;
> -
> 	return parent_sched_may_change;
> }
> 
> -- 
> 1.8.3.1
> 


       reply	other threads:[~2021-02-10 11:15 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1611917485-584-1-git-send-email-brookxu@tencent.com>
2021-02-10 11:13 ` Paolo Valente [this message]
2021-02-10 15:20   ` [PATCH 1/2] bfq: remove some useless logic of bfq_update_next_in_service() Oleksandr Natalenko
2021-02-10 15:21     ` Jens Axboe
2021-02-10 15:54       ` Paolo Valente
     [not found] ` <1611917485-584-2-git-send-email-brookxu@tencent.com>
2021-02-10 11:13   ` [PATCH 2/2] bfq: amend the function name of bfq_may_expire_for_budg_timeout() Paolo Valente
2021-02-10 15:37     ` Oleksandr Natalenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=B4751549-78D9-4A84-8FB2-5DAA86ED39C8@linaro.org \
    --to=paolo.valente@linaro.org \
    --cc=axboe@kernel.dk \
    --cc=brookxu.cn@gmail.com \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).