linux-block.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Oleksandr Natalenko <oleksandr@natalenko.name>
To: Paolo Valente <paolo.valente@linaro.org>
Cc: Chunguang Xu <brookxu.cn@gmail.com>,
	axboe@kernel.dk, linux-block@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] bfq: amend the function name of bfq_may_expire_for_budg_timeout()
Date: Wed, 10 Feb 2021 16:37:38 +0100	[thread overview]
Message-ID: <20210210153738.pdsiqnmucq5v5cck@spock.localdomain> (raw)
In-Reply-To: <0A676DC9-E730-460A-8C39-9E1851343339@linaro.org>

On Wed, Feb 10, 2021 at 12:13:59PM +0100, Paolo Valente wrote:
> 
> 
> > Il giorno 29 gen 2021, alle ore 11:51, Chunguang Xu <brookxu.cn@gmail.com> ha scritto:
> > 
> > From: Chunguang Xu <brookxu@tencent.com>
> > 
> > The function name bfq_may_expire_for_budg_timeout() may be misspelled,
> > try to fix it.
> > 
> 
> Ok for me to make this name longer.
> 
> Thanks,
> Paolo
> 
> > Signed-off-by: Chunguang Xu <brookxu@tencent.com>
> > ---
> > block/bfq-iosched.c | 6 +++---
> > 1 file changed, 3 insertions(+), 3 deletions(-)
> > 
> > diff --git a/block/bfq-iosched.c b/block/bfq-iosched.c
> > index 9e4eb0f..4f40c61 100644
> > --- a/block/bfq-iosched.c
> > +++ b/block/bfq-iosched.c
> > @@ -4061,7 +4061,7 @@ static bool bfq_bfqq_budget_timeout(struct bfq_queue *bfqq)
> >  * condition does not hold, or if the queue is slow enough to deserve
> >  * only to be kicked off for preserving a high throughput.
> >  */
> > -static bool bfq_may_expire_for_budg_timeout(struct bfq_queue *bfqq)
> > +static bool bfq_may_expire_for_budget_timeout(struct bfq_queue *bfqq)
> > {
> > 	bfq_log_bfqq(bfqq->bfqd, bfqq,
> > 		"may_budget_timeout: wait_request %d left %d timeout %d",
> > @@ -4350,7 +4350,7 @@ static struct bfq_queue *bfq_select_queue(struct bfq_data *bfqd)
> > 	 * on the case where bfq_bfqq_must_idle() returns true, in
> > 	 * bfq_completed_request().
> > 	 */
> > -	if (bfq_may_expire_for_budg_timeout(bfqq) &&
> > +	if (bfq_may_expire_for_budget_timeout(bfqq) &&
> > 	    !bfq_bfqq_must_idle(bfqq))
> > 		goto expire;
> > 
> > @@ -5706,7 +5706,7 @@ static void bfq_completed_request(struct bfq_queue *bfqq, struct bfq_data *bfqd)
> > 			 * of its reserved service guarantees.
> > 			 */
> > 			return;
> > -		} else if (bfq_may_expire_for_budg_timeout(bfqq))
> > +		} else if (bfq_may_expire_for_budget_timeout(bfqq))
> > 			bfq_bfqq_expire(bfqd, bfqq, false,
> > 					BFQQE_BUDGET_TIMEOUT);
> > 		else if (RB_EMPTY_ROOT(&bfqq->sort_list) &&
> > -- 
> > 1.8.3.1
> > 
> 

Was this sent to some mailing list? I don't see an original email with
this patch.

-- 
  Oleksandr Natalenko (post-factum)

      reply	other threads:[~2021-02-10 15:38 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1611917485-584-1-git-send-email-brookxu@tencent.com>
2021-02-10 11:13 ` [PATCH 1/2] bfq: remove some useless logic of bfq_update_next_in_service() Paolo Valente
2021-02-10 15:20   ` Oleksandr Natalenko
2021-02-10 15:21     ` Jens Axboe
2021-02-10 15:54       ` Paolo Valente
     [not found] ` <1611917485-584-2-git-send-email-brookxu@tencent.com>
2021-02-10 11:13   ` [PATCH 2/2] bfq: amend the function name of bfq_may_expire_for_budg_timeout() Paolo Valente
2021-02-10 15:37     ` Oleksandr Natalenko [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210210153738.pdsiqnmucq5v5cck@spock.localdomain \
    --to=oleksandr@natalenko.name \
    --cc=axboe@kernel.dk \
    --cc=brookxu.cn@gmail.com \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=paolo.valente@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).