From: Christoph Hellwig <hch@lst.de>
To: axboe@kernel.dk
Cc: linux-block@vger.kernel.org, Guenter Roeck <linux@roeck-us.net>
Subject: [PATCH] block: remove an incorrect check from blk_rq_append_bio
Date: Fri, 9 Apr 2021 17:04:46 +0200 [thread overview]
Message-ID: <20210409150447.1977410-1-hch@lst.de> (raw)
blk_rq_append_bio is also used for the copy case, not just the map case,
so tis debug check is not correct.
Fixes: 393bb12e0058 ("block: stop calling blk_queue_bounce for passthrough requests")
Reported-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Christoph Hellwig <hch@lst.de>
Tested-by: Guenter Roeck <linux@roeck-us.net>
---
block/blk-map.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/block/blk-map.c b/block/blk-map.c
index dac78376acc899..3743158ddaeb76 100644
--- a/block/blk-map.c
+++ b/block/blk-map.c
@@ -485,9 +485,6 @@ int blk_rq_append_bio(struct request *rq, struct bio *bio)
struct bio_vec bv;
unsigned int nr_segs = 0;
- if (WARN_ON_ONCE(rq->q->limits.bounce != BLK_BOUNCE_NONE))
- return -EINVAL;
-
bio_for_each_bvec(bv, bio, iter)
nr_segs++;
--
2.30.1
next reply other threads:[~2021-04-09 15:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-09 15:04 Christoph Hellwig [this message]
2021-04-09 15:27 ` [PATCH] block: remove an incorrect check from blk_rq_append_bio Himanshu Madhani
2021-04-09 21:05 ` Chaitanya Kulkarni
2021-04-12 12:45 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210409150447.1977410-1-hch@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=linux-block@vger.kernel.org \
--cc=linux@roeck-us.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).