From: Himanshu Madhani <himanshu.madhani@oracle.com>
To: Christoph Hellwig <hch@lst.de>
Cc: Jens Axboe <axboe@kernel.dk>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
Guenter Roeck <linux@roeck-us.net>
Subject: Re: [PATCH] block: remove an incorrect check from blk_rq_append_bio
Date: Fri, 9 Apr 2021 15:27:44 +0000 [thread overview]
Message-ID: <C9C2D5AE-3E66-45C5-BC2F-BDF79BB14FD8@oracle.com> (raw)
In-Reply-To: <20210409150447.1977410-1-hch@lst.de>
> On Apr 9, 2021, at 10:04 AM, Christoph Hellwig <hch@lst.de> wrote:
>
> blk_rq_append_bio is also used for the copy case, not just the map case,
> so tis debug check is not correct.
>
Small nit.. “this” spelled incorrectly above
> Fixes: 393bb12e0058 ("block: stop calling blk_queue_bounce for passthrough requests")
> Reported-by: Guenter Roeck <linux@roeck-us.net>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> Tested-by: Guenter Roeck <linux@roeck-us.net>
> ---
> block/blk-map.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/block/blk-map.c b/block/blk-map.c
> index dac78376acc899..3743158ddaeb76 100644
> --- a/block/blk-map.c
> +++ b/block/blk-map.c
> @@ -485,9 +485,6 @@ int blk_rq_append_bio(struct request *rq, struct bio *bio)
> struct bio_vec bv;
> unsigned int nr_segs = 0;
>
> - if (WARN_ON_ONCE(rq->q->limits.bounce != BLK_BOUNCE_NONE))
> - return -EINVAL;
> -
> bio_for_each_bvec(bv, bio, iter)
> nr_segs++;
>
> --
> 2.30.1
>
Looks good otherwise.
Reviewed-by: Himanshu Madhani <himanshu.madhani@oracle.com>
--
Himanshu Madhani Oracle Linux Engineering
next prev parent reply other threads:[~2021-04-09 15:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-09 15:04 [PATCH] block: remove an incorrect check from blk_rq_append_bio Christoph Hellwig
2021-04-09 15:27 ` Himanshu Madhani [this message]
2021-04-09 21:05 ` Chaitanya Kulkarni
2021-04-12 12:45 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=C9C2D5AE-3E66-45C5-BC2F-BDF79BB14FD8@oracle.com \
--to=himanshu.madhani@oracle.com \
--cc=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
--cc=linux@roeck-us.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).