linux-block.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Chaitanya Kulkarni <Chaitanya.Kulkarni@wdc.com>
To: Christoph Hellwig <hch@lst.de>, "axboe@kernel.dk" <axboe@kernel.dk>
Cc: "linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
	Guenter Roeck <linux@roeck-us.net>
Subject: Re: [PATCH] block: remove an incorrect check from blk_rq_append_bio
Date: Fri, 9 Apr 2021 21:05:41 +0000	[thread overview]
Message-ID: <BYAPR04MB49650B2BA566ADC01F4323BE86739@BYAPR04MB4965.namprd04.prod.outlook.com> (raw)
In-Reply-To: 20210409150447.1977410-1-hch@lst.de

On 4/9/21 08:08, Christoph Hellwig wrote:
> blk_rq_append_bio is also used for the copy case, not just the map case,
> so tis debug check is not correct.
>
> Fixes: 393bb12e0058 ("block: stop calling blk_queue_bounce for passthrough requests")
> Reported-by: Guenter Roeck <linux@roeck-us.net>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> Tested-by: Guenter Roeck <linux@roeck-us.net>

With 's/tis/this/' can be done at the time of applying patch.

The commit 393bb12e0058 does add check in question here.

Looks good.

Reviewed-by: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>



  parent reply	other threads:[~2021-04-09 21:05 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-09 15:04 [PATCH] block: remove an incorrect check from blk_rq_append_bio Christoph Hellwig
2021-04-09 15:27 ` Himanshu Madhani
2021-04-09 21:05 ` Chaitanya Kulkarni [this message]
2021-04-12 12:45 ` Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=BYAPR04MB49650B2BA566ADC01F4323BE86739@BYAPR04MB4965.namprd04.prod.outlook.com \
    --to=chaitanya.kulkarni@wdc.com \
    --cc=axboe@kernel.dk \
    --cc=hch@lst.de \
    --cc=linux-block@vger.kernel.org \
    --cc=linux@roeck-us.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).