[PATCH] blk-mq: cleanup redundant nr_hw_queues assignement

[PATCH] blk-mq: cleanup redundant nr_hw_queues assignement

[Jeffle Xu]

'set->nr_hw_queues' has already been assigneid to nr_hw_queues in
blk_mq_realloc_tag_set_tags().

Signed-off-by: Jeffle Xu <jefflexu@linux.alibaba.com>
---
 block/blk-mq.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/block/blk-mq.c b/block/blk-mq.c
index 55ef6b975169..c7d1613e7514 100644
--- a/block/blk-mq.c
+++ b/block/blk-mq.c
@@ -3672,7 +3672,6 @@ static void __blk_mq_update_nr_hw_queues(struct blk_mq_tag_set *set,
 	    0)
 		goto reregister;
 
-	set->nr_hw_queues = nr_hw_queues;
 fallback:
 	blk_mq_update_queue_map(set);
 	list_for_each_entry(q, &set->tag_list, tag_set_list) {
-- 
2.27.0

Re: [PATCH] blk-mq: cleanup redundant nr_hw_queues assignement

[Jens Axboe]

On 4/16/21 1:53 AM, Jeffle Xu wrote:
> 'set->nr_hw_queues' has already been assigneid to nr_hw_queues in
> blk_mq_realloc_tag_set_tags().
> 
> Signed-off-by: Jeffle Xu <jefflexu@linux.alibaba.com>
> ---
>  block/blk-mq.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/block/blk-mq.c b/block/blk-mq.c
> index 55ef6b975169..c7d1613e7514 100644
> --- a/block/blk-mq.c
> +++ b/block/blk-mq.c
> @@ -3672,7 +3672,6 @@ static void __blk_mq_update_nr_hw_queues(struct blk_mq_tag_set *set,
>  	    0)
>  		goto reregister;
>  
> -	set->nr_hw_queues = nr_hw_queues;

This isn't an equivalent transformation if nr_hw_queues >
set->nr_hw_queues.

-- 
Jens Axboe