* [PATCH] blk-mq: cleanup redundant nr_hw_queues assignement
@ 2021-04-16 7:53 Jeffle Xu
2021-04-16 12:12 ` Jens Axboe
0 siblings, 1 reply; 2+ messages in thread
From: Jeffle Xu @ 2021-04-16 7:53 UTC (permalink / raw)
To: axboe; +Cc: linux-block
'set->nr_hw_queues' has already been assigneid to nr_hw_queues in
blk_mq_realloc_tag_set_tags().
Signed-off-by: Jeffle Xu <jefflexu@linux.alibaba.com>
---
block/blk-mq.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/block/blk-mq.c b/block/blk-mq.c
index 55ef6b975169..c7d1613e7514 100644
--- a/block/blk-mq.c
+++ b/block/blk-mq.c
@@ -3672,7 +3672,6 @@ static void __blk_mq_update_nr_hw_queues(struct blk_mq_tag_set *set,
0)
goto reregister;
- set->nr_hw_queues = nr_hw_queues;
fallback:
blk_mq_update_queue_map(set);
list_for_each_entry(q, &set->tag_list, tag_set_list) {
--
2.27.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] blk-mq: cleanup redundant nr_hw_queues assignement
2021-04-16 7:53 [PATCH] blk-mq: cleanup redundant nr_hw_queues assignement Jeffle Xu
@ 2021-04-16 12:12 ` Jens Axboe
0 siblings, 0 replies; 2+ messages in thread
From: Jens Axboe @ 2021-04-16 12:12 UTC (permalink / raw)
To: Jeffle Xu; +Cc: linux-block
On 4/16/21 1:53 AM, Jeffle Xu wrote:
> 'set->nr_hw_queues' has already been assigneid to nr_hw_queues in
> blk_mq_realloc_tag_set_tags().
>
> Signed-off-by: Jeffle Xu <jefflexu@linux.alibaba.com>
> ---
> block/blk-mq.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/block/blk-mq.c b/block/blk-mq.c
> index 55ef6b975169..c7d1613e7514 100644
> --- a/block/blk-mq.c
> +++ b/block/blk-mq.c
> @@ -3672,7 +3672,6 @@ static void __blk_mq_update_nr_hw_queues(struct blk_mq_tag_set *set,
> 0)
> goto reregister;
>
> - set->nr_hw_queues = nr_hw_queues;
This isn't an equivalent transformation if nr_hw_queues >
set->nr_hw_queues.
--
Jens Axboe
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-04-16 12:12 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-16 7:53 [PATCH] blk-mq: cleanup redundant nr_hw_queues assignement Jeffle Xu
2021-04-16 12:12 ` Jens Axboe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).