From: John Garry <firstname.lastname@example.org>
To: Ming Lei <email@example.com>
Cc: Jens Axboe <firstname.lastname@example.org>, Christoph Hellwig <email@example.com>,
<firstname.lastname@example.org>, Yanhui Ma <email@example.com>,
Bart Van Assche <firstname.lastname@example.org>,
Subject: Re: [PATCH] blk-mq: plug request for shared sbitmap
Date: Tue, 18 May 2021 17:01:16 +0100 [thread overview]
Message-ID: <email@example.com> (raw)
On 18/05/2021 13:51, John Garry wrote:
> n 18/05/2021 13:00, Ming Lei wrote:
>>>> 'Before 620K' could be caused by busy queue when batching submission
>>>> applied, so merge chance is increased. This patch applies batching
>>>> submission, so queue becomes not busy enough.
>>>> BTW, what is the queue depth of sdev and can_queue of shost for your
>>>> hisilision SAS?
>>> sdev queue depth is 64 (see hisi_sas_slave_configure()) and host
>>> depth is
>>> 4096 - 96 (for reserved tags) = 4000
>> OK, so queue depth should get IO merged if there are too many requests
>> What is the same read test result without shared tags? still 430K?
> I never left a driver switch in place to disable it.
> I can forward-port "reply-map" support, which is not too difficult and I
> will let you know the result.
The 'after' results are similar to without shared sbitmap, i.e using
450K (read), 430K IOPs (randread)
For reference, with shared shared sbitmap:
Before 620K (read), 300K IOPs (randread)
After 460K (read), 430K (randread)*
These are all mq-deadline.
* I mixed read and randread result earlier by accident
>> And what is your exact read test script? And how many cpu cores in
>> your system?
next prev parent reply other threads:[~2021-05-18 16:02 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-14 2:20 [PATCH] blk-mq: plug request for shared sbitmap Ming Lei
2021-05-14 14:59 ` Jens Axboe
2021-05-18 9:44 ` John Garry
2021-05-18 11:16 ` Ming Lei
2021-05-18 11:42 ` John Garry
2021-05-18 12:00 ` Ming Lei
2021-05-18 12:51 ` John Garry
2021-05-18 16:01 ` John Garry [this message]
2021-05-19 0:21 ` Ming Lei
2021-05-19 8:41 ` John Garry
2021-05-20 1:23 ` Ming Lei
2021-05-20 8:21 ` John Garry
2021-05-18 11:54 ` Hannes Reinecke
2021-05-18 12:37 ` John Garry
2021-05-18 13:22 ` Hannes Reinecke
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).