From: John Garry <john.garry@huawei.com>
To: Ming Lei <ming.lei@redhat.com>
Cc: Jens Axboe <axboe@kernel.dk>, Christoph Hellwig <hch@lst.de>,
<linux-block@vger.kernel.org>, Yanhui Ma <yama@redhat.com>,
Bart Van Assche <bvanassche@acm.org>,
<kashyap.desai@broadcom.com>,
chenxiang <chenxiang66@hisilicon.com>
Subject: Re: [PATCH] blk-mq: plug request for shared sbitmap
Date: Thu, 20 May 2021 09:21:53 +0100 [thread overview]
Message-ID: <ad6318cf-d0ef-4385-c25a-3128bf458602@huawei.com> (raw)
In-Reply-To: <YKW6G1flax9vkfIR@T590>
On 20/05/2021 02:23, Ming Lei wrote:
>> BTW, recently we have seen 2x optimisation/improvement for shared sbitmap
>> which were under/related to nr_hw_queues == 1 check - this patch and the
>> changing of the default IO sched.
> You mean you saw 2X improvement in your hisilicon SAS compared with
> non-shared sbitmap? In Yanhui's virt test, we just bring back the perf
> to non-shared sbitmap's level.
>
Sorry, I meant one improvement is using mq-deadline by default, and
other improvement is the change in this patch. I didn't mean a double in
throughput.
Thanks,
John
next prev parent reply other threads:[~2021-05-20 8:23 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-14 2:20 [PATCH] blk-mq: plug request for shared sbitmap Ming Lei
2021-05-14 14:59 ` Jens Axboe
2021-05-18 9:44 ` John Garry
2021-05-18 11:16 ` Ming Lei
2021-05-18 11:42 ` John Garry
2021-05-18 12:00 ` Ming Lei
2021-05-18 12:51 ` John Garry
2021-05-18 16:01 ` John Garry
2021-05-19 0:21 ` Ming Lei
2021-05-19 8:41 ` John Garry
2021-05-20 1:23 ` Ming Lei
2021-05-20 8:21 ` John Garry [this message]
2021-05-18 11:54 ` Hannes Reinecke
2021-05-18 12:37 ` John Garry
2021-05-18 13:22 ` Hannes Reinecke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ad6318cf-d0ef-4385-c25a-3128bf458602@huawei.com \
--to=john.garry@huawei.com \
--cc=axboe@kernel.dk \
--cc=bvanassche@acm.org \
--cc=chenxiang66@hisilicon.com \
--cc=hch@lst.de \
--cc=kashyap.desai@broadcom.com \
--cc=linux-block@vger.kernel.org \
--cc=ming.lei@redhat.com \
--cc=yama@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).