From: Paolo Valente <paolo.valente@linaro.org>
To: liubaozhu <liubaozhu@uniontech.com>
Cc: axboe@kernel.dk, linux-block@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] block/bfq: the delta_from_first should be ns rather than us
Date: Wed, 21 Jul 2021 09:56:12 +0200 [thread overview]
Message-ID: <C5E7C12D-616A-40BD-8BFF-2D7C0211B8C9@linaro.org> (raw)
In-Reply-To: <20210721063047.92122-1-liubaozhu@uniontech.com>
[RESENDING ...]
> Il giorno 21 lug 2021, alle ore 08:30, liubaozhu <liubaozhu@uniontech.com> ha scritto:
>
> In the block/bfq-iosched.c,the function bfq_update_peak_rate(),
> bfqd->delta_from_first = now_ns - bfqd->first_dispatch,
> according to the subtraction operation here,now_ns is ns,
> and bfqd->first_dispatch is also ns,so bfqd->delta_from_first should be ns.
>
Correct!
Acked-by: Paolo Valente <paolo.valente@linaro.org>
Thank you,
Paolo
> Signed-off-by: liubaozhu <liubaozhu@uniontech.com>
> ---
> block/bfq-iosched.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/block/bfq-iosched.h b/block/bfq-iosched.h
> index 99c2a3cb0..7cf4fc8c3 100644
> --- a/block/bfq-iosched.h
> +++ b/block/bfq-iosched.h
> @@ -632,7 +632,7 @@ struct bfq_data {
> u64 tot_sectors_dispatched;
> /* max rq size seen during current observation interval (sectors) */
> u32 last_rq_max_size;
> - /* time elapsed from first dispatch in current observ. interval (us) */
> + /* time elapsed from first dispatch in current observ. interval (ns) */
> u64 delta_from_first;
> /*
> * Current estimate of the device peak rate, measured in
> --
> 2.20.1
>
>
>
next prev parent reply other threads:[~2021-07-21 7:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-21 6:30 [PATCH] block/bfq: the delta_from_first should be ns rather than us liubaozhu
2021-07-21 7:56 ` Paolo Valente [this message]
[not found] ` <3A3B282C-FA5D-43F3-9C78-5E257C93A835@linaro.org>
2021-07-21 16:19 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=C5E7C12D-616A-40BD-8BFF-2D7C0211B8C9@linaro.org \
--to=paolo.valente@linaro.org \
--cc=axboe@kernel.dk \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=liubaozhu@uniontech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).