linux-block.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Damien Le Moal <Damien.LeMoal@wdc.com>
To: "Martin K. Petersen" <martin.petersen@oracle.com>
Cc: Jens Axboe <axboe@kernel.dk>,
	"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
	"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
	Hannes Reinecke <hare@suse.de>
Subject: Re: [PATCH v5 0/5] Initial support for multi-actuator HDDs
Date: Thu, 26 Aug 2021 03:50:15 +0000	[thread overview]
Message-ID: <DM6PR04MB7081B82BD60E0C96F31C84E7E7C79@DM6PR04MB7081.namprd04.prod.outlook.com> (raw)
In-Reply-To: yq1ilzsannu.fsf@ca-mkp.ca.oracle.com

On 2021/08/26 12:43, Martin K. Petersen wrote:
> 
> Damien,
> 
>> I am not super happy with the name either. I used this one as the
>> least worst of possibilities I thought of.  seek_range/srange ? ->
>> that is very HDD centric and as we can reuse this for things like
>> dm-linear on top of SSDs, that does not really work.  I would prefer
>> something that convey the idea of "parallel command execution", since
>> this is the main point of the interface. prange ? cdm_range ?
>> req_range ?
> 
> How about independent_access_range? That doesn't imply head positioning
> and can also be used to describe a fault domain. And it is less
> disk-centric than concurrent_positioning_range.

I like it, but a bit long-ish. Do you think shortening to access_range would be
acceptable ?

we would have:

/sys/block/XYZ/queue/access_ranges/...

and

struct blk_access_range {
	...
	sector_t sector;
	sector_t nr_sectors;
}

struct blk_access_range *arange;

Adding independent does make everything even more obvious, but names become
rather long. Not an issue for the sysfs directory I think, but

struct blk_independent_access_range {
	...
	sector_t sector;
	sector_t nr_sectors;
}

is rather a long struct name. Shortening independent to "ind" could very easily
be confused with "indirection", so that is not an option. And "iaccess" is
obscure...

> 
> I concur that those names are a bit unwieldy but at least they are
> somewhat descriptive.
> 
> I consulted the thesaurus and didn't really like the other options
> (discrete, disjoint, separate, etc.). I think 'independent' is more
> accurate for this and better than 'concurrent' and 'parallel'.
> 


-- 
Damien Le Moal
Western Digital Research

  reply	other threads:[~2021-08-26  3:50 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-12  7:50 [PATCH v5 0/5] Initial support for multi-actuator HDDs Damien Le Moal
2021-08-12  7:50 ` [PATCH v5 1/5] block: Add concurrent positioning ranges support Damien Le Moal
2021-08-12  7:50 ` [PATCH v5 2/5] scsi: sd: add " Damien Le Moal
2021-08-12  7:50 ` [PATCH v5 3/5] libata: support concurrent positioning ranges log Damien Le Moal
2021-08-12  7:50 ` [PATCH v5 4/5] doc: document sysfs queue/cranges attributes Damien Le Moal
2021-08-12  7:50 ` [PATCH v5 5/5] doc: Fix typo in request queue sysfs documentation Damien Le Moal
2021-08-12 17:10 ` [PATCH v5 0/5] Initial support for multi-actuator HDDs Jens Axboe
2021-08-12 17:21   ` Martin K. Petersen
2021-08-12 17:25     ` Jens Axboe
2021-08-13  0:30       ` Damien Le Moal
2021-08-16 17:12         ` Martin K. Petersen
2021-08-17  4:06           ` Damien Le Moal
2021-08-16 17:10 ` Martin K. Petersen
2021-08-17  4:06   ` Damien Le Moal
2021-08-18  2:24     ` Martin K. Petersen
2021-08-18  2:45       ` Damien Le Moal
2021-08-23  1:27 ` Damien Le Moal
2021-08-26  2:07 ` Damien Le Moal
2021-08-26  2:41   ` Martin K. Petersen
2021-08-26  3:09     ` Damien Le Moal
2021-08-26  3:43       ` Martin K. Petersen
2021-08-26  3:50         ` Damien Le Moal [this message]
2021-08-26  6:28           ` Hannes Reinecke
2021-08-27  3:03           ` Martin K. Petersen
2021-08-27  3:11             ` Damien Le Moal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DM6PR04MB7081B82BD60E0C96F31C84E7E7C79@DM6PR04MB7081.namprd04.prod.outlook.com \
    --to=damien.lemoal@wdc.com \
    --cc=axboe@kernel.dk \
    --cc=hare@suse.de \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).