* [PATCH v6 1/6] Bluetooth: hci_qca: use wait_until_sent() for power pulses
2018-12-27 7:31 [PATCH v6 0/6] Bug fixes for Qualcomm BT chip wcn3990 Balakrishna Godavarthi
@ 2018-12-27 7:31 ` Balakrishna Godavarthi
2018-12-27 20:18 ` Matthias Kaehlcke
2018-12-27 7:31 ` [PATCH v6 2/6] Bluetooth: hci_qca: Deassert RTS while baudrate change command Balakrishna Godavarthi
` (4 subsequent siblings)
5 siblings, 1 reply; 13+ messages in thread
From: Balakrishna Godavarthi @ 2018-12-27 7:31 UTC (permalink / raw)
To: marcel, johan.hedberg
Cc: mka, linux-kernel, linux-bluetooth, hemantg, linux-arm-msm,
Balakrishna Godavarthi
wcn3990 requires a power pulse to turn ON/OFF along with
regulators. Sometimes we are observing the power pulses are sent
out with some time delay, due to queuing these commands. This is
causing synchronization issues with chip, which intern delay the
chip setup or may end up with communication issues.
Signed-off-by: Balakrishna Godavarthi <bgodavar@codeaurora.org>
---
Changes in v6:
* added serdev_device_write_flush() in qca_send_power_pulse
instead during the power off pulse.
Changes in v5:
* added serdev_device_write_flush() in qca_power_off().
---
drivers/bluetooth/hci_qca.c | 38 ++++++++++++++-----------------------
1 file changed, 14 insertions(+), 24 deletions(-)
diff --git a/drivers/bluetooth/hci_qca.c b/drivers/bluetooth/hci_qca.c
index f036c8f98ea3..507a2355c758 100644
--- a/drivers/bluetooth/hci_qca.c
+++ b/drivers/bluetooth/hci_qca.c
@@ -1013,11 +1013,9 @@ static inline void host_set_baudrate(struct hci_uart *hu, unsigned int speed)
hci_uart_set_baudrate(hu, speed);
}
-static int qca_send_power_pulse(struct hci_dev *hdev, u8 cmd)
+static int qca_send_power_pulse(struct hci_uart *hu, u8 cmd)
{
- struct hci_uart *hu = hci_get_drvdata(hdev);
- struct qca_data *qca = hu->priv;
- struct sk_buff *skb;
+ int ret;
/* These power pulses are single byte command which are sent
* at required baudrate to wcn3990. On wcn3990, we have an external
@@ -1029,19 +1027,17 @@ static int qca_send_power_pulse(struct hci_dev *hdev, u8 cmd)
* save power. Disabling hardware flow control is mandatory while
* sending power pulses to SoC.
*/
- bt_dev_dbg(hdev, "sending power pulse %02x to SoC", cmd);
-
- skb = bt_skb_alloc(sizeof(cmd), GFP_KERNEL);
- if (!skb)
- return -ENOMEM;
-
+ serdev_device_write_flush(hu->serdev);
+ bt_dev_dbg(hu->hdev, "sending power pulse %02x to SoC", cmd);
hci_uart_set_flow_control(hu, true);
+ ret = serdev_device_write_buf(hu->serdev, &cmd, sizeof(cmd));
+ if (ret < 0) {
+ bt_dev_err(hu->hdev, "failed to send power pulse %02x to SoC",
+ cmd);
+ return ret;
+ }
- skb_put_u8(skb, cmd);
- hci_skb_pkt_type(skb) = HCI_COMMAND_PKT;
-
- skb_queue_tail(&qca->txq, skb);
- hci_uart_tx_wakeup(hu);
+ serdev_device_wait_until_sent(hu->serdev, 0);
/* Wait for 100 uS for SoC to settle down */
usleep_range(100, 200);
@@ -1116,7 +1112,6 @@ static int qca_set_speed(struct hci_uart *hu, enum qca_speed_type speed_type)
static int qca_wcn3990_init(struct hci_uart *hu)
{
- struct hci_dev *hdev = hu->hdev;
struct qca_serdev *qcadev;
int ret;
@@ -1139,12 +1134,12 @@ static int qca_wcn3990_init(struct hci_uart *hu)
/* Forcefully enable wcn3990 to enter in to boot mode. */
host_set_baudrate(hu, 2400);
- ret = qca_send_power_pulse(hdev, QCA_WCN3990_POWEROFF_PULSE);
+ ret = qca_send_power_pulse(hu, QCA_WCN3990_POWEROFF_PULSE);
if (ret)
return ret;
qca_set_speed(hu, QCA_INIT_SPEED);
- ret = qca_send_power_pulse(hdev, QCA_WCN3990_POWERON_PULSE);
+ ret = qca_send_power_pulse(hu, QCA_WCN3990_POWERON_PULSE);
if (ret)
return ret;
@@ -1274,13 +1269,8 @@ static const struct qca_vreg_data qca_soc_data = {
static void qca_power_shutdown(struct hci_uart *hu)
{
- struct serdev_device *serdev = hu->serdev;
- unsigned char cmd = QCA_WCN3990_POWEROFF_PULSE;
-
host_set_baudrate(hu, 2400);
- hci_uart_set_flow_control(hu, true);
- serdev_device_write_buf(serdev, &cmd, sizeof(cmd));
- hci_uart_set_flow_control(hu, false);
+ qca_send_power_pulse(hu, QCA_WCN3990_POWEROFF_PULSE);
qca_power_setup(hu, false);
}
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project
^ permalink raw reply related [flat|nested] 13+ messages in thread
* Re: [PATCH v6 1/6] Bluetooth: hci_qca: use wait_until_sent() for power pulses
2018-12-27 7:31 ` [PATCH v6 1/6] Bluetooth: hci_qca: use wait_until_sent() for power pulses Balakrishna Godavarthi
@ 2018-12-27 20:18 ` Matthias Kaehlcke
2018-12-28 7:11 ` Balakrishna Godavarthi
0 siblings, 1 reply; 13+ messages in thread
From: Matthias Kaehlcke @ 2018-12-27 20:18 UTC (permalink / raw)
To: Balakrishna Godavarthi
Cc: marcel, johan.hedberg, linux-kernel, linux-bluetooth, hemantg,
linux-arm-msm
On Thu, Dec 27, 2018 at 01:01:31PM +0530, Balakrishna Godavarthi wrote:
> wcn3990 requires a power pulse to turn ON/OFF along with
> regulators. Sometimes we are observing the power pulses are sent
> out with some time delay, due to queuing these commands. This is
> causing synchronization issues with chip, which intern delay the
> chip setup or may end up with communication issues.
>
> Signed-off-by: Balakrishna Godavarthi <bgodavar@codeaurora.org>
> ---
> Changes in v6:
> * added serdev_device_write_flush() in qca_send_power_pulse
> instead during the power off pulse.
>
> Changes in v5:
> * added serdev_device_write_flush() in qca_power_off().
>
> ---
> drivers/bluetooth/hci_qca.c | 38 ++++++++++++++-----------------------
> 1 file changed, 14 insertions(+), 24 deletions(-)
>
> diff --git a/drivers/bluetooth/hci_qca.c b/drivers/bluetooth/hci_qca.c
> index f036c8f98ea3..507a2355c758 100644
> --- a/drivers/bluetooth/hci_qca.c
> +++ b/drivers/bluetooth/hci_qca.c
> @@ -1013,11 +1013,9 @@ static inline void host_set_baudrate(struct hci_uart *hu, unsigned int speed)
> hci_uart_set_baudrate(hu, speed);
> }
>
> -static int qca_send_power_pulse(struct hci_dev *hdev, u8 cmd)
> +static int qca_send_power_pulse(struct hci_uart *hu, u8 cmd)
> {
> - struct hci_uart *hu = hci_get_drvdata(hdev);
> - struct qca_data *qca = hu->priv;
> - struct sk_buff *skb;
> + int ret;
>
> /* These power pulses are single byte command which are sent
> * at required baudrate to wcn3990. On wcn3990, we have an external
> @@ -1029,19 +1027,17 @@ static int qca_send_power_pulse(struct hci_dev *hdev, u8 cmd)
> * save power. Disabling hardware flow control is mandatory while
> * sending power pulses to SoC.
> */
> - bt_dev_dbg(hdev, "sending power pulse %02x to SoC", cmd);
> -
> - skb = bt_skb_alloc(sizeof(cmd), GFP_KERNEL);
> - if (!skb)
> - return -ENOMEM;
> -
> + serdev_device_write_flush(hu->serdev);
> + bt_dev_dbg(hu->hdev, "sending power pulse %02x to SoC", cmd);
nit: why clutter the code flow by putting the log statement in the
middle of code that is actually doing something with the serial
interface?
In case you respin anyway I suggest to structure it like this:
bt_dev_dbg(hu->hdev, "sending power pulse %02x to SoC", cmd);
hci_uart_set_flow_control(hu, true);
serdev_device_write_flush(hu->serdev);
ret = serdev_device_write_buf(hu->serdev, &cmd, sizeof(cmd));
> hci_uart_set_flow_control(hu, true);
> + ret = serdev_device_write_buf(hu->serdev, &cmd, sizeof(cmd));
> + if (ret < 0) {
> + bt_dev_err(hu->hdev, "failed to send power pulse %02x to SoC",
nit: especially on 'embedded' devices 'SoC' is typically associated
with the CPU running Linux, you might want to change it to
'controller'.
> + cmd);
> + return ret;
> + }
>
> - skb_put_u8(skb, cmd);
> - hci_skb_pkt_type(skb) = HCI_COMMAND_PKT;
> -
> - skb_queue_tail(&qca->txq, skb);
> - hci_uart_tx_wakeup(hu);
> + serdev_device_wait_until_sent(hu->serdev, 0);
>
> /* Wait for 100 uS for SoC to settle down */
> usleep_range(100, 200);
I said earlier the delay here should be enough to ensure that the byte
gets transferred from a hardware buffer/FIFO to the controller,
however that didn't take into account that the power pulses are sent
with a baudrate of 2400. That translates to ~240 bytes/s, hence a
delay of 5 ms is needed to be on the safe side.
In case you change the delay please also update the comment to make
clear this is not only time for the BT controller to settle, but also
to guarantee that the command was actually sent to the controller.
So far it seems no problems have been observed, though this could be
thanks to the 100 ms delay in qca_wcn3990_init().
Cheers
Matthias
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH v6 1/6] Bluetooth: hci_qca: use wait_until_sent() for power pulses
2018-12-27 20:18 ` Matthias Kaehlcke
@ 2018-12-28 7:11 ` Balakrishna Godavarthi
0 siblings, 0 replies; 13+ messages in thread
From: Balakrishna Godavarthi @ 2018-12-28 7:11 UTC (permalink / raw)
To: Matthias Kaehlcke
Cc: marcel, johan.hedberg, linux-kernel, linux-bluetooth, hemantg,
linux-arm-msm
HI Matthias,
On 2018-12-28 01:48, Matthias Kaehlcke wrote:
> On Thu, Dec 27, 2018 at 01:01:31PM +0530, Balakrishna Godavarthi wrote:
>> wcn3990 requires a power pulse to turn ON/OFF along with
>> regulators. Sometimes we are observing the power pulses are sent
>> out with some time delay, due to queuing these commands. This is
>> causing synchronization issues with chip, which intern delay the
>> chip setup or may end up with communication issues.
>>
>> Signed-off-by: Balakrishna Godavarthi <bgodavar@codeaurora.org>
>> ---
>> Changes in v6:
>> * added serdev_device_write_flush() in qca_send_power_pulse
>> instead during the power off pulse.
>>
>> Changes in v5:
>> * added serdev_device_write_flush() in qca_power_off().
>>
>> ---
>> drivers/bluetooth/hci_qca.c | 38
>> ++++++++++++++-----------------------
>> 1 file changed, 14 insertions(+), 24 deletions(-)
>>
>> diff --git a/drivers/bluetooth/hci_qca.c b/drivers/bluetooth/hci_qca.c
>> index f036c8f98ea3..507a2355c758 100644
>> --- a/drivers/bluetooth/hci_qca.c
>> +++ b/drivers/bluetooth/hci_qca.c
>> @@ -1013,11 +1013,9 @@ static inline void host_set_baudrate(struct
>> hci_uart *hu, unsigned int speed)
>> hci_uart_set_baudrate(hu, speed);
>> }
>>
>> -static int qca_send_power_pulse(struct hci_dev *hdev, u8 cmd)
>> +static int qca_send_power_pulse(struct hci_uart *hu, u8 cmd)
>> {
>> - struct hci_uart *hu = hci_get_drvdata(hdev);
>> - struct qca_data *qca = hu->priv;
>> - struct sk_buff *skb;
>> + int ret;
>>
>> /* These power pulses are single byte command which are sent
>> * at required baudrate to wcn3990. On wcn3990, we have an external
>> @@ -1029,19 +1027,17 @@ static int qca_send_power_pulse(struct hci_dev
>> *hdev, u8 cmd)
>> * save power. Disabling hardware flow control is mandatory while
>> * sending power pulses to SoC.
>> */
>> - bt_dev_dbg(hdev, "sending power pulse %02x to SoC", cmd);
>> -
>> - skb = bt_skb_alloc(sizeof(cmd), GFP_KERNEL);
>> - if (!skb)
>> - return -ENOMEM;
>> -
>> + serdev_device_write_flush(hu->serdev);
>> + bt_dev_dbg(hu->hdev, "sending power pulse %02x to SoC", cmd);
>
> nit: why clutter the code flow by putting the log statement in the
> middle of code that is actually doing something with the serial
> interface?
>
> In case you respin anyway I suggest to structure it like this:
>
> bt_dev_dbg(hu->hdev, "sending power pulse %02x to SoC", cmd);
>
> hci_uart_set_flow_control(hu, true);
> serdev_device_write_flush(hu->serdev);
> ret = serdev_device_write_buf(hu->serdev, &cmd, sizeof(cmd));
>
>
>> hci_uart_set_flow_control(hu, true);
>> + ret = serdev_device_write_buf(hu->serdev, &cmd, sizeof(cmd));
>> + if (ret < 0) {
>> + bt_dev_err(hu->hdev, "failed to send power pulse %02x to SoC",
>
> nit: especially on 'embedded' devices 'SoC' is typically associated
> with the CPU running Linux, you might want to change it to
> 'controller'.
>
[Bala]: will update.
>> + cmd);
>> + return ret;
>> + }
>>
>> - skb_put_u8(skb, cmd);
>> - hci_skb_pkt_type(skb) = HCI_COMMAND_PKT;
>> -
>> - skb_queue_tail(&qca->txq, skb);
>> - hci_uart_tx_wakeup(hu);
>> + serdev_device_wait_until_sent(hu->serdev, 0);
>>
>> /* Wait for 100 uS for SoC to settle down */
>> usleep_range(100, 200);
>
> I said earlier the delay here should be enough to ensure that the byte
> gets transferred from a hardware buffer/FIFO to the controller,
> however that didn't take into account that the power pulses are sent
> with a baudrate of 2400. That translates to ~240 bytes/s, hence a
> delay of 5 ms is needed to be on the safe side.
>
[Bala]: sure will update the delay of 5 ms.
> In case you change the delay please also update the comment to make
> clear this is not only time for the BT controller to settle, but also
> to guarantee that the command was actually sent to the controller.
>
[Bala]: will update the comment.
> So far it seems no problems have been observed, though this could be
> thanks to the 100 ms delay in qca_wcn3990_init().
>
> Cheers
>
> Matthias
--
Regards
Balakrishna.
^ permalink raw reply [flat|nested] 13+ messages in thread
* [PATCH v6 2/6] Bluetooth: hci_qca: Deassert RTS while baudrate change command
2018-12-27 7:31 [PATCH v6 0/6] Bug fixes for Qualcomm BT chip wcn3990 Balakrishna Godavarthi
2018-12-27 7:31 ` [PATCH v6 1/6] Bluetooth: hci_qca: use wait_until_sent() for power pulses Balakrishna Godavarthi
@ 2018-12-27 7:31 ` Balakrishna Godavarthi
2018-12-27 7:31 ` [PATCH v6 3/6] Bluetooth: hci_qca: Fix frame reassembly errors for wcn3990 Balakrishna Godavarthi
` (3 subsequent siblings)
5 siblings, 0 replies; 13+ messages in thread
From: Balakrishna Godavarthi @ 2018-12-27 7:31 UTC (permalink / raw)
To: marcel, johan.hedberg
Cc: mka, linux-kernel, linux-bluetooth, hemantg, linux-arm-msm,
Balakrishna Godavarthi
This patch will help to stop frame reassembly errors while changing
the baudrate. This is because host send a change baudrate request
command to the chip with 115200 bps, Whereas chip will change their
UART clocks to the enable for new baudrate and sends the response
for the change request command with newer baudrate, On host side
we are still operating in 115200 bps which results of reading garbage
data. Here we are pulling RTS line, so that chip we will wait to send data
to host until host change its baudrate.
Signed-off-by: Balakrishna Godavarthi <bgodavar@codeaurora.org>
Tested-by: Matthias Kaehlcke <mka@chromium.org>
Reviewed-by: Matthias Kaehlcke <mka@chromium.org>
---
drivers/bluetooth/hci_qca.c | 24 +++++++++++++-----------
1 file changed, 13 insertions(+), 11 deletions(-)
diff --git a/drivers/bluetooth/hci_qca.c b/drivers/bluetooth/hci_qca.c
index 507a2355c758..63436023632d 100644
--- a/drivers/bluetooth/hci_qca.c
+++ b/drivers/bluetooth/hci_qca.c
@@ -963,7 +963,6 @@ static int qca_set_baudrate(struct hci_dev *hdev, uint8_t baudrate)
struct hci_uart *hu = hci_get_drvdata(hdev);
struct qca_data *qca = hu->priv;
struct sk_buff *skb;
- struct qca_serdev *qcadev;
u8 cmd[] = { 0x01, 0x48, 0xFC, 0x01, 0x00 };
if (baudrate > QCA_BAUDRATE_3200000)
@@ -977,13 +976,6 @@ static int qca_set_baudrate(struct hci_dev *hdev, uint8_t baudrate)
return -ENOMEM;
}
- /* Disabling hardware flow control is mandatory while
- * sending change baudrate request to wcn3990 SoC.
- */
- qcadev = serdev_device_get_drvdata(hu->serdev);
- if (qcadev->btsoc_type == QCA_WCN3990)
- hci_uart_set_flow_control(hu, true);
-
/* Assign commands to change baudrate and packet type. */
skb_put_data(skb, cmd, sizeof(cmd));
hci_skb_pkt_type(skb) = HCI_COMMAND_PKT;
@@ -999,9 +991,6 @@ static int qca_set_baudrate(struct hci_dev *hdev, uint8_t baudrate)
schedule_timeout(msecs_to_jiffies(BAUDRATE_SETTLE_TIMEOUT_MS));
set_current_state(TASK_RUNNING);
- if (qcadev->btsoc_type == QCA_WCN3990)
- hci_uart_set_flow_control(hu, false);
-
return 0;
}
@@ -1087,6 +1076,7 @@ static int qca_check_speeds(struct hci_uart *hu)
static int qca_set_speed(struct hci_uart *hu, enum qca_speed_type speed_type)
{
unsigned int speed, qca_baudrate;
+ struct qca_serdev *qcadev;
int ret;
if (speed_type == QCA_INIT_SPEED) {
@@ -1098,6 +1088,15 @@ static int qca_set_speed(struct hci_uart *hu, enum qca_speed_type speed_type)
if (!speed)
return 0;
+ /* Deassert RTS while changing the baudrate of chip and host.
+ * This will prevent chip from transmitting its response with
+ * the new baudrate while the host port is still operating at
+ * the old speed.
+ */
+ qcadev = serdev_device_get_drvdata(hu->serdev);
+ if (qcadev->btsoc_type == QCA_WCN3990)
+ serdev_device_set_rts(hu->serdev, false);
+
qca_baudrate = qca_get_baudrate_value(speed);
bt_dev_dbg(hu->hdev, "Set UART speed to %d", speed);
ret = qca_set_baudrate(hu->hdev, qca_baudrate);
@@ -1105,6 +1104,9 @@ static int qca_set_speed(struct hci_uart *hu, enum qca_speed_type speed_type)
return ret;
host_set_baudrate(hu, speed);
+
+ if (qcadev->btsoc_type == QCA_WCN3990)
+ serdev_device_set_rts(hu->serdev, true);
}
return 0;
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project
^ permalink raw reply related [flat|nested] 13+ messages in thread
* [PATCH v6 3/6] Bluetooth: hci_qca: Fix frame reassembly errors for wcn3990
2018-12-27 7:31 [PATCH v6 0/6] Bug fixes for Qualcomm BT chip wcn3990 Balakrishna Godavarthi
2018-12-27 7:31 ` [PATCH v6 1/6] Bluetooth: hci_qca: use wait_until_sent() for power pulses Balakrishna Godavarthi
2018-12-27 7:31 ` [PATCH v6 2/6] Bluetooth: hci_qca: Deassert RTS while baudrate change command Balakrishna Godavarthi
@ 2018-12-27 7:31 ` Balakrishna Godavarthi
2018-12-27 20:25 ` Matthias Kaehlcke
2018-12-27 7:31 ` [PATCH v6 4/6] Bluetooth: hci_qca: Disable IBS state machine and flush Tx buffer Balakrishna Godavarthi
` (2 subsequent siblings)
5 siblings, 1 reply; 13+ messages in thread
From: Balakrishna Godavarthi @ 2018-12-27 7:31 UTC (permalink / raw)
To: marcel, johan.hedberg
Cc: mka, linux-kernel, linux-bluetooth, hemantg, linux-arm-msm,
Balakrishna Godavarthi
During initalization of wcn3990, we observed UART is reading some
stray bytes on the Rx line. This is logging Frame reassembly errors
on the serial console. This could be because of tristate of Tx line
of wcn3990 during boot up.
[ 176.929612] Bluetooth: hci_qca.c:qca_recv() hci0: Frame reassembly failed (-84)
[ 176.945734] Bluetooth: hci_qca.c:qca_recv() hci0: Frame reassembly failed (-84)
[ 176.953298] Bluetooth: hci_qca.c:qca_recv() hci0: Frame reassembly failed (-84)
[ 177.010660] Bluetooth: hci_qca.c:qca_recv() hci0: Frame reassembly failed (-84)
[ 177.067633] Bluetooth: hci_qca.c:qca_recv() hci0: Frame reassembly failed (-84)
Now we enable a flag during bootup to stop executing proto receive
function and clear it back once the initialization is done.
Signed-off-by: Balakrishna Godavarthi <bgodavar@codeaurora.org>
Tested-by: Matthias Kaehlcke <mka@chromium.org>
---
drivers/bluetooth/hci_qca.c | 16 ++++++++++++++++
1 file changed, 16 insertions(+)
diff --git a/drivers/bluetooth/hci_qca.c b/drivers/bluetooth/hci_qca.c
index 63436023632d..0751b2359f6f 100644
--- a/drivers/bluetooth/hci_qca.c
+++ b/drivers/bluetooth/hci_qca.c
@@ -56,6 +56,7 @@
/* Controller states */
#define STATE_IN_BAND_SLEEP_ENABLED 1
+#define STATE_DISCARD_RX 2
#define IBS_WAKE_RETRANS_TIMEOUT_MS 100
#define IBS_TX_IDLE_TIMEOUT_MS 2000
@@ -511,6 +512,7 @@ static int qca_open(struct hci_uart *hu)
} else {
hu->init_speed = qcadev->init_speed;
hu->oper_speed = qcadev->oper_speed;
+ set_bit(STATE_DISCARD_RX, &qca->flags);
ret = qca_power_setup(hu, true);
if (ret) {
destroy_workqueue(qca->workqueue);
@@ -903,6 +905,13 @@ static int qca_recv(struct hci_uart *hu, const void *data, int count)
if (!test_bit(HCI_UART_REGISTERED, &hu->flags))
return -EUNATCH;
+ /* We discard Rx data received while device is in booting
+ * stage, This is because of BT chip Tx line is in tristate.
+ * Due to this we read some garbage data on UART Rx.
+ */
+ if (test_bit(STATE_DISCARD_RX, &qca->flags))
+ return 0;
+
qca->rx_skb = h4_recv_buf(hu->hdev, qca->rx_skb, data, count,
qca_recv_pkts, ARRAY_SIZE(qca_recv_pkts));
if (IS_ERR(qca->rx_skb)) {
@@ -1195,6 +1204,7 @@ static int qca_setup(struct hci_uart *hu)
if (ret)
return ret;
+ clear_bit(STATE_DISCARD_RX, &qca->flags);
ret = qca_read_soc_version(hdev, &soc_ver);
if (ret)
return ret;
@@ -1271,6 +1281,12 @@ static const struct qca_vreg_data qca_soc_data = {
static void qca_power_shutdown(struct hci_uart *hu)
{
+ struct qca_data *qca = hu->priv;
+
+ /* From this point we go into power off state. But serial port is
+ * still open, discard all the garbage data received on the Rx line.
+ */
+ set_bit(STATE_DISCARD_RX, &qca->flags);
host_set_baudrate(hu, 2400);
qca_send_power_pulse(hu, QCA_WCN3990_POWEROFF_PULSE);
qca_power_setup(hu, false);
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project
^ permalink raw reply related [flat|nested] 13+ messages in thread
* Re: [PATCH v6 3/6] Bluetooth: hci_qca: Fix frame reassembly errors for wcn3990
2018-12-27 7:31 ` [PATCH v6 3/6] Bluetooth: hci_qca: Fix frame reassembly errors for wcn3990 Balakrishna Godavarthi
@ 2018-12-27 20:25 ` Matthias Kaehlcke
2018-12-28 7:49 ` Balakrishna Godavarthi
0 siblings, 1 reply; 13+ messages in thread
From: Matthias Kaehlcke @ 2018-12-27 20:25 UTC (permalink / raw)
To: Balakrishna Godavarthi
Cc: marcel, johan.hedberg, linux-kernel, linux-bluetooth, hemantg,
linux-arm-msm
On Thu, Dec 27, 2018 at 01:01:33PM +0530, Balakrishna Godavarthi wrote:
> During initalization of wcn3990, we observed UART is reading some
> stray bytes on the Rx line. This is logging Frame reassembly errors
> on the serial console. This could be because of tristate of Tx line
> of wcn3990 during boot up.
My testing suggests that this change is not needed if the Rx line of
the SoC/AP is configured with a pull-up. We'd probably all prefer not
to have this change if there's a neater way to address the garbage
data. Could you test with adding the pull-up and dropping this patch
on your side?
Thanks
Matthias
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH v6 3/6] Bluetooth: hci_qca: Fix frame reassembly errors for wcn3990
2018-12-27 20:25 ` Matthias Kaehlcke
@ 2018-12-28 7:49 ` Balakrishna Godavarthi
0 siblings, 0 replies; 13+ messages in thread
From: Balakrishna Godavarthi @ 2018-12-28 7:49 UTC (permalink / raw)
To: Matthias Kaehlcke
Cc: marcel, johan.hedberg, linux-kernel, linux-bluetooth, hemantg,
linux-arm-msm
Hi Matthias,
On 2018-12-28 01:55, Matthias Kaehlcke wrote:
> On Thu, Dec 27, 2018 at 01:01:33PM +0530, Balakrishna Godavarthi wrote:
>> During initalization of wcn3990, we observed UART is reading some
>> stray bytes on the Rx line. This is logging Frame reassembly errors
>> on the serial console. This could be because of tristate of Tx line
>> of wcn3990 during boot up.
>
> My testing suggests that this change is not needed if the Rx line of
> the SoC/AP is configured with a pull-up. We'd probably all prefer not
> to have this change if there's a neater way to address the garbage
> data. Could you test with adding the pull-up and dropping this patch
> on your side?
>
> Thanks
>
> Matthias
Thanks a lot it worked to me. will drop this patch.
--
Regards
Balakrishna.
^ permalink raw reply [flat|nested] 13+ messages in thread
* [PATCH v6 4/6] Bluetooth: hci_qca: Disable IBS state machine and flush Tx buffer
2018-12-27 7:31 [PATCH v6 0/6] Bug fixes for Qualcomm BT chip wcn3990 Balakrishna Godavarthi
` (2 preceding siblings ...)
2018-12-27 7:31 ` [PATCH v6 3/6] Bluetooth: hci_qca: Fix frame reassembly errors for wcn3990 Balakrishna Godavarthi
@ 2018-12-27 7:31 ` Balakrishna Godavarthi
2018-12-27 7:31 ` [PATCH v6 5/6] Bluetooth: hci_qca: Update baudrate change wait time for wcn3990 Balakrishna Godavarthi
2018-12-27 7:31 ` [PATCH v6 6/6] Bluetooth: btqca: inject command complete event during fw download Balakrishna Godavarthi
5 siblings, 0 replies; 13+ messages in thread
From: Balakrishna Godavarthi @ 2018-12-27 7:31 UTC (permalink / raw)
To: marcel, johan.hedberg
Cc: mka, linux-kernel, linux-bluetooth, hemantg, linux-arm-msm,
Balakrishna Godavarthi
During hci down we observed IBS sleep commands are queued in the Tx
buffer and hci_uart_write_work is sending data to the chip which is
not required as the chip is powered off. This patch will disable IBS
and flush the Tx buffer before we turn off the chip.
Signed-off-by: Balakrishna Godavarthi <bgodavar@codeaurora.org>
---
drivers/bluetooth/hci_qca.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/bluetooth/hci_qca.c b/drivers/bluetooth/hci_qca.c
index 0751b2359f6f..4677a6a2716a 100644
--- a/drivers/bluetooth/hci_qca.c
+++ b/drivers/bluetooth/hci_qca.c
@@ -1287,6 +1287,8 @@ static void qca_power_shutdown(struct hci_uart *hu)
* still open, discard all the garbage data received on the Rx line.
*/
set_bit(STATE_DISCARD_RX, &qca->flags);
+ clear_bit(STATE_IN_BAND_SLEEP_ENABLED, &qca->flags);
+ qca_flush(hu);
host_set_baudrate(hu, 2400);
qca_send_power_pulse(hu, QCA_WCN3990_POWEROFF_PULSE);
qca_power_setup(hu, false);
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project
^ permalink raw reply related [flat|nested] 13+ messages in thread
* [PATCH v6 5/6] Bluetooth: hci_qca: Update baudrate change wait time for wcn3990
2018-12-27 7:31 [PATCH v6 0/6] Bug fixes for Qualcomm BT chip wcn3990 Balakrishna Godavarthi
` (3 preceding siblings ...)
2018-12-27 7:31 ` [PATCH v6 4/6] Bluetooth: hci_qca: Disable IBS state machine and flush Tx buffer Balakrishna Godavarthi
@ 2018-12-27 7:31 ` Balakrishna Godavarthi
2018-12-27 21:00 ` Matthias Kaehlcke
2018-12-27 7:31 ` [PATCH v6 6/6] Bluetooth: btqca: inject command complete event during fw download Balakrishna Godavarthi
5 siblings, 1 reply; 13+ messages in thread
From: Balakrishna Godavarthi @ 2018-12-27 7:31 UTC (permalink / raw)
To: marcel, johan.hedberg
Cc: mka, linux-kernel, linux-bluetooth, hemantg, linux-arm-msm,
Balakrishna Godavarthi
This patch will update the baudrate change request wait time from
300 ms to 100 ms. When host sends the change baudrate request to
the controller, controller sets its clock and wait until the
clocks settle down. Here the Wait time is required for both
host and controller to be on sync.
Signed-off-by: Balakrishna Godavarthi <bgodavar@codeaurora.org>
---
Changes in v6:
* intial patch.
---
drivers/bluetooth/hci_qca.c | 12 ++++++++++--
1 file changed, 10 insertions(+), 2 deletions(-)
diff --git a/drivers/bluetooth/hci_qca.c b/drivers/bluetooth/hci_qca.c
index 4677a6a2716a..61b0fb1ff32f 100644
--- a/drivers/bluetooth/hci_qca.c
+++ b/drivers/bluetooth/hci_qca.c
@@ -60,7 +60,8 @@
#define IBS_WAKE_RETRANS_TIMEOUT_MS 100
#define IBS_TX_IDLE_TIMEOUT_MS 2000
-#define BAUDRATE_SETTLE_TIMEOUT_MS 300
+#define ROME_BD_SETTLE_TIMEOUT_MS 300
+#define WCN3990_BD_SETTLE_TIMEOUT_MS 100
/* susclk rate */
#define SUSCLK_RATE_32KHZ 32768
@@ -972,8 +973,11 @@ static int qca_set_baudrate(struct hci_dev *hdev, uint8_t baudrate)
struct hci_uart *hu = hci_get_drvdata(hdev);
struct qca_data *qca = hu->priv;
struct sk_buff *skb;
+ struct qca_serdev *qcadev;
+ unsigned int bd_settling_timeout;
u8 cmd[] = { 0x01, 0x48, 0xFC, 0x01, 0x00 };
+ qcadev = serdev_device_get_drvdata(hu->serdev);
if (baudrate > QCA_BAUDRATE_3200000)
return -EINVAL;
@@ -996,8 +1000,12 @@ static int qca_set_baudrate(struct hci_dev *hdev, uint8_t baudrate)
* controller will come back after they receive this HCI command
* then host can communicate with new baudrate to controller
*/
+ bd_settling_timeout = qcadev->btsoc_type == QCA_WCN3990 ?
+ WCN3990_BD_SETTLE_TIMEOUT_MS :
+ ROME_BD_SETTLE_TIMEOUT_MS;
+
set_current_state(TASK_UNINTERRUPTIBLE);
- schedule_timeout(msecs_to_jiffies(BAUDRATE_SETTLE_TIMEOUT_MS));
+ schedule_timeout(msecs_to_jiffies(bd_settling_timeout));
set_current_state(TASK_RUNNING);
return 0;
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project
^ permalink raw reply related [flat|nested] 13+ messages in thread
* Re: [PATCH v6 5/6] Bluetooth: hci_qca: Update baudrate change wait time for wcn3990
2018-12-27 7:31 ` [PATCH v6 5/6] Bluetooth: hci_qca: Update baudrate change wait time for wcn3990 Balakrishna Godavarthi
@ 2018-12-27 21:00 ` Matthias Kaehlcke
2018-12-28 11:25 ` Balakrishna Godavarthi
0 siblings, 1 reply; 13+ messages in thread
From: Matthias Kaehlcke @ 2018-12-27 21:00 UTC (permalink / raw)
To: Balakrishna Godavarthi
Cc: marcel, johan.hedberg, linux-kernel, linux-bluetooth, hemantg,
linux-arm-msm
On Thu, Dec 27, 2018 at 01:01:35PM +0530, Balakrishna Godavarthi wrote:
> This patch will update the baudrate change request wait time from
> 300 ms to 100 ms. When host sends the change baudrate request to
> the controller, controller sets its clock and wait until the
> clocks settle down. Here the Wait time is required for both
> host and controller to be on sync.
Ultimately up to you, but I would advise against adding 'improvement'
changes to this series. The scope of the series is already fairly
vague ("Bug fixes for Qualcomm BT chip wcn3990"), with at least some
patches that could be sent individually, which would reduce churn when
respinning.
> Signed-off-by: Balakrishna Godavarthi <bgodavar@codeaurora.org>
> ---
>
> Changes in v6:
> * intial patch.
>
> ---
> drivers/bluetooth/hci_qca.c | 12 ++++++++++--
> 1 file changed, 10 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/bluetooth/hci_qca.c b/drivers/bluetooth/hci_qca.c
> index 4677a6a2716a..61b0fb1ff32f 100644
> --- a/drivers/bluetooth/hci_qca.c
> +++ b/drivers/bluetooth/hci_qca.c
> @@ -60,7 +60,8 @@
>
> #define IBS_WAKE_RETRANS_TIMEOUT_MS 100
> #define IBS_TX_IDLE_TIMEOUT_MS 2000
> -#define BAUDRATE_SETTLE_TIMEOUT_MS 300
> +#define ROME_BD_SETTLE_TIMEOUT_MS 300
> +#define WCN3990_BD_SETTLE_TIMEOUT_MS 100
My testing suggests that even the lower 100 ms delay isn't needed, if
different parts that require a delay are addressed more specifically,
instead of using a single long 'settle' delay
(https://lore.kernel.org/patchwork/patch/1026795/#1212816 has some
details).
My idea was to sent a patch after this series has landed to avoid
interfering with it.
Cheers
Matthias
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH v6 5/6] Bluetooth: hci_qca: Update baudrate change wait time for wcn3990
2018-12-27 21:00 ` Matthias Kaehlcke
@ 2018-12-28 11:25 ` Balakrishna Godavarthi
0 siblings, 0 replies; 13+ messages in thread
From: Balakrishna Godavarthi @ 2018-12-28 11:25 UTC (permalink / raw)
To: Matthias Kaehlcke
Cc: marcel, johan.hedberg, linux-kernel, linux-bluetooth, hemantg,
linux-arm-msm
Hi Matthias,
On 2018-12-28 02:30, Matthias Kaehlcke wrote:
> On Thu, Dec 27, 2018 at 01:01:35PM +0530, Balakrishna Godavarthi wrote:
>> This patch will update the baudrate change request wait time from
>> 300 ms to 100 ms. When host sends the change baudrate request to
>> the controller, controller sets its clock and wait until the
>> clocks settle down. Here the Wait time is required for both
>> host and controller to be on sync.
>
> Ultimately up to you, but I would advise against adding 'improvement'
> changes to this series. The scope of the series is already fairly
> vague ("Bug fixes for Qualcomm BT chip wcn3990"), with at least some
> patches that could be sent individually, which would reduce churn when
> respinning.
[Bala]: yes your correct will send this as improvement patch once the
series is merged.
>
>> Signed-off-by: Balakrishna Godavarthi <bgodavar@codeaurora.org>
>> ---
>>
>> Changes in v6:
>> * intial patch.
>>
>> ---
>> drivers/bluetooth/hci_qca.c | 12 ++++++++++--
>> 1 file changed, 10 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/bluetooth/hci_qca.c b/drivers/bluetooth/hci_qca.c
>> index 4677a6a2716a..61b0fb1ff32f 100644
>> --- a/drivers/bluetooth/hci_qca.c
>> +++ b/drivers/bluetooth/hci_qca.c
>> @@ -60,7 +60,8 @@
>>
>> #define IBS_WAKE_RETRANS_TIMEOUT_MS 100
>> #define IBS_TX_IDLE_TIMEOUT_MS 2000
>> -#define BAUDRATE_SETTLE_TIMEOUT_MS 300
>> +#define ROME_BD_SETTLE_TIMEOUT_MS 300
>> +#define WCN3990_BD_SETTLE_TIMEOUT_MS 100
>
> My testing suggests that even the lower 100 ms delay isn't needed, if
> different parts that require a delay are addressed more specifically,
> instead of using a single long 'settle' delay
> (https://lore.kernel.org/patchwork/patch/1026795/#1212816 has some
> details).
>
[Bala]: i to agree with you. but from the point 1, we have many chances
of getting
baudrate change delay. after lot of stress test and experiments
we found 100 ms is reasonable to handle all
of them together.
> My idea was to sent a patch after this series has landed to avoid
> interfering with it.
>
[Bala]: sure will drop this change from the series.
> Cheers
>
> Matthias
--
Regards
Balakrishna.
^ permalink raw reply [flat|nested] 13+ messages in thread
* [PATCH v6 6/6] Bluetooth: btqca: inject command complete event during fw download
2018-12-27 7:31 [PATCH v6 0/6] Bug fixes for Qualcomm BT chip wcn3990 Balakrishna Godavarthi
` (4 preceding siblings ...)
2018-12-27 7:31 ` [PATCH v6 5/6] Bluetooth: hci_qca: Update baudrate change wait time for wcn3990 Balakrishna Godavarthi
@ 2018-12-27 7:31 ` Balakrishna Godavarthi
5 siblings, 0 replies; 13+ messages in thread
From: Balakrishna Godavarthi @ 2018-12-27 7:31 UTC (permalink / raw)
To: marcel, johan.hedberg
Cc: mka, linux-kernel, linux-bluetooth, hemantg, linux-arm-msm,
Balakrishna Godavarthi
Latest qualcomm chips are not sending an command complete event for
every firmware packet sent to chip. They only respond with a vendor
specific event for the last firmware packet. This optimization will
decrease the BT ON time. Due to this we are seeing a timeout error
message logs on the console during firmware download. Now we are
injecting a command complete event once we receive an vendor specific
event for the last RAM firmware packet.
Signed-off-by: Balakrishna Godavarthi <bgodavar@codeaurora.org>
---
drivers/bluetooth/btqca.c | 39 ++++++++++++++++++++++++++++++++++++++-
drivers/bluetooth/btqca.h | 3 +++
2 files changed, 41 insertions(+), 1 deletion(-)
diff --git a/drivers/bluetooth/btqca.c b/drivers/bluetooth/btqca.c
index ec9e03a6b778..0b533f65f652 100644
--- a/drivers/bluetooth/btqca.c
+++ b/drivers/bluetooth/btqca.c
@@ -144,6 +144,7 @@ static void qca_tlv_check_data(struct rome_config *config,
* In case VSE is skipped, only the last segment is acked.
*/
config->dnld_mode = tlv_patch->download_mode;
+ config->dnld_type = config->dnld_mode;
BT_DBG("Total Length : %d bytes",
le32_to_cpu(tlv_patch->total_size));
@@ -264,6 +265,31 @@ static int qca_tlv_send_segment(struct hci_dev *hdev, int seg_size,
return err;
}
+static int qca_inject_cmd_complete_event(struct hci_dev *hdev)
+{
+ struct hci_event_hdr *hdr;
+ struct hci_ev_cmd_complete *evt;
+ struct sk_buff *skb;
+
+ skb = bt_skb_alloc(sizeof(*hdr) + sizeof(*evt) + 1, GFP_KERNEL);
+ if (!skb)
+ return -ENOMEM;
+
+ hdr = skb_put(skb, sizeof(*hdr));
+ hdr->evt = HCI_EV_CMD_COMPLETE;
+ hdr->plen = sizeof(*evt) + 1;
+
+ evt = skb_put(skb, sizeof(*evt));
+ evt->ncmd = 1;
+ evt->opcode = HCI_OP_NOP;
+
+ skb_put_u8(skb, QCA_HCI_CC_SUCCESS);
+
+ hci_skb_pkt_type(skb) = HCI_EVENT_PKT;
+
+ return hci_recv_frame(hdev, skb);
+}
+
static int qca_download_firmware(struct hci_dev *hdev,
struct rome_config *config)
{
@@ -297,11 +323,22 @@ static int qca_download_firmware(struct hci_dev *hdev,
ret = qca_tlv_send_segment(hdev, segsize, segment,
config->dnld_mode);
if (ret)
- break;
+ goto out;
segment += segsize;
}
+ /* Latest qualcomm chipsets are not sending a command complete event
+ * for every fw packet sent. They only respond with a vendor specific
+ * event for the last packet. This optimization in the chip will
+ * decrease the BT in initialization time. Here we will inject a command
+ * complete event to avoid a command timeout error message.
+ */
+ if ((config->dnld_type == ROME_SKIP_EVT_VSE_CC ||
+ config->dnld_type == ROME_SKIP_EVT_VSE))
+ return qca_inject_cmd_complete_event(hdev);
+
+out:
release_firmware(fw);
return ret;
diff --git a/drivers/bluetooth/btqca.h b/drivers/bluetooth/btqca.h
index 0c01f375fe83..5c8fc54133e3 100644
--- a/drivers/bluetooth/btqca.h
+++ b/drivers/bluetooth/btqca.h
@@ -40,6 +40,8 @@
#define QCA_WCN3990_POWERON_PULSE 0xFC
#define QCA_WCN3990_POWEROFF_PULSE 0xC0
+#define QCA_HCI_CC_SUCCESS 0x00
+
enum qca_bardrate {
QCA_BAUDRATE_115200 = 0,
QCA_BAUDRATE_57600,
@@ -81,6 +83,7 @@ struct rome_config {
char fwname[64];
uint8_t user_baud_rate;
enum rome_tlv_dnld_mode dnld_mode;
+ enum rome_tlv_dnld_mode dnld_type;
};
struct edl_event_hdr {
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project
^ permalink raw reply related [flat|nested] 13+ messages in thread