* [Bluez PATCH v1] avdtp: fix delay report valid states
@ 2020-03-20 5:14 Archie Pusaka
2020-03-27 2:14 ` Archie Pusaka
0 siblings, 1 reply; 3+ messages in thread
From: Archie Pusaka @ 2020-03-20 5:14 UTC (permalink / raw)
To: linux-bluetooth, Luiz Augusto von Dentz; +Cc: Archie Pusaka
From: Archie Pusaka <apusaka@chromium.org>
According to AVDTP specification section 6.19,
avdtp_delayreport_cmd could also be received when the state of SEP
is open.
Therefore, updating to accommodate such condition.
---
profiles/audio/avdtp.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/profiles/audio/avdtp.c b/profiles/audio/avdtp.c
index 0e075f9ff..4b0e63384 100644
--- a/profiles/audio/avdtp.c
+++ b/profiles/audio/avdtp.c
@@ -1936,6 +1936,7 @@ static gboolean avdtp_delayreport_cmd(struct avdtp *session,
stream = sep->stream;
if (sep->state != AVDTP_STATE_CONFIGURED &&
+ sep->state != AVDTP_STATE_OPEN &&
sep->state != AVDTP_STATE_STREAMING) {
err = AVDTP_BAD_STATE;
goto failed;
--
2.25.1.696.g5e7596f4ac-goog
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [Bluez PATCH v1] avdtp: fix delay report valid states
2020-03-20 5:14 [Bluez PATCH v1] avdtp: fix delay report valid states Archie Pusaka
@ 2020-03-27 2:14 ` Archie Pusaka
2020-03-27 20:55 ` Luiz Augusto von Dentz
0 siblings, 1 reply; 3+ messages in thread
From: Archie Pusaka @ 2020-03-27 2:14 UTC (permalink / raw)
To: linux-bluetooth, Luiz Augusto von Dentz; +Cc: Archie Pusaka
[re-sending as plain text]
Hi Bluez Maintainers,
Could you take a look at this proposal?
Thank you!
On Fri, 20 Mar 2020 at 13:14, Archie Pusaka <apusaka@google.com> wrote:
>
> From: Archie Pusaka <apusaka@chromium.org>
>
> According to AVDTP specification section 6.19,
> avdtp_delayreport_cmd could also be received when the state of SEP
> is open.
>
> Therefore, updating to accommodate such condition.
> ---
>
> profiles/audio/avdtp.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/profiles/audio/avdtp.c b/profiles/audio/avdtp.c
> index 0e075f9ff..4b0e63384 100644
> --- a/profiles/audio/avdtp.c
> +++ b/profiles/audio/avdtp.c
> @@ -1936,6 +1936,7 @@ static gboolean avdtp_delayreport_cmd(struct avdtp *session,
> stream = sep->stream;
>
> if (sep->state != AVDTP_STATE_CONFIGURED &&
> + sep->state != AVDTP_STATE_OPEN &&
> sep->state != AVDTP_STATE_STREAMING) {
> err = AVDTP_BAD_STATE;
> goto failed;
> --
> 2.25.1.696.g5e7596f4ac-goog
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [Bluez PATCH v1] avdtp: fix delay report valid states
2020-03-27 2:14 ` Archie Pusaka
@ 2020-03-27 20:55 ` Luiz Augusto von Dentz
0 siblings, 0 replies; 3+ messages in thread
From: Luiz Augusto von Dentz @ 2020-03-27 20:55 UTC (permalink / raw)
To: Archie Pusaka; +Cc: linux-bluetooth, Archie Pusaka
Hi Archie,
On Thu, Mar 26, 2020 at 7:14 PM Archie Pusaka <apusaka@google.com> wrote:
>
> [re-sending as plain text]
> Hi Bluez Maintainers,
>
> Could you take a look at this proposal?
>
> Thank you!
>
>
> On Fri, 20 Mar 2020 at 13:14, Archie Pusaka <apusaka@google.com> wrote:
> >
> > From: Archie Pusaka <apusaka@chromium.org>
> >
> > According to AVDTP specification section 6.19,
> > avdtp_delayreport_cmd could also be received when the state of SEP
> > is open.
> >
> > Therefore, updating to accommodate such condition.
> > ---
> >
> > profiles/audio/avdtp.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/profiles/audio/avdtp.c b/profiles/audio/avdtp.c
> > index 0e075f9ff..4b0e63384 100644
> > --- a/profiles/audio/avdtp.c
> > +++ b/profiles/audio/avdtp.c
> > @@ -1936,6 +1936,7 @@ static gboolean avdtp_delayreport_cmd(struct avdtp *session,
> > stream = sep->stream;
> >
> > if (sep->state != AVDTP_STATE_CONFIGURED &&
> > + sep->state != AVDTP_STATE_OPEN &&
> > sep->state != AVDTP_STATE_STREAMING) {
> > err = AVDTP_BAD_STATE;
> > goto failed;
> > --
> > 2.25.1.696.g5e7596f4ac-goog
> >
Applied, thanks.
--
Luiz Augusto von Dentz
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-03-27 20:55 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-20 5:14 [Bluez PATCH v1] avdtp: fix delay report valid states Archie Pusaka
2020-03-27 2:14 ` Archie Pusaka
2020-03-27 20:55 ` Luiz Augusto von Dentz
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).