* [bug report] Bluetooth: hci_qca: Enable WBS support for wcn3991
@ 2020-05-20 12:05 Dan Carpenter
2020-05-20 16:23 ` Abhishek Pandit-Subedi
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2020-05-20 12:05 UTC (permalink / raw)
To: abhishekpandit; +Cc: linux-bluetooth
Hello Abhishek Pandit-Subedi,
The patch a228f7a41029: "Bluetooth: hci_qca: Enable WBS support for
wcn3991" from May 14, 2020, leads to the following static checker
warning:
drivers/bluetooth/hci_qca.c:1960 qca_serdev_probe()
error: uninitialized symbol 'hdev'.
drivers/bluetooth/hci_qca.c
1948 }
1949
1950 if (power_ctrl_enabled) {
1951 hdev = qcadev->serdev_hu.hdev;
^^^^
hdev is only initialized here.
1952 set_bit(HCI_QUIRK_NON_PERSISTENT_SETUP, &hdev->quirks);
1953 hdev->shutdown = qca_power_off;
1954 }
1955
1956 /* Wideband speech support must be set per driver since it can't be
1957 * queried via hci.
1958 */
1959 if (data && (data->capabilities & QCA_CAP_WIDEBAND_SPEECH))
1960 set_bit(HCI_QUIRK_WIDEBAND_SPEECH_SUPPORTED, &hdev->quirks);
^^^^
Potentially uninitialized here.
1961
1962 return 0;
1963 }
regards,
dan carpenter
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [bug report] Bluetooth: hci_qca: Enable WBS support for wcn3991
2020-05-20 12:05 [bug report] Bluetooth: hci_qca: Enable WBS support for wcn3991 Dan Carpenter
@ 2020-05-20 16:23 ` Abhishek Pandit-Subedi
0 siblings, 0 replies; 2+ messages in thread
From: Abhishek Pandit-Subedi @ 2020-05-20 16:23 UTC (permalink / raw)
To: Dan Carpenter; +Cc: Bluez mailing list
Thanks for the heads-up Dan. Patch incoming to fix this.
Abhishek
On Wed, May 20, 2020 at 5:07 AM Dan Carpenter <dan.carpenter@oracle.com> wrote:
>
> Hello Abhishek Pandit-Subedi,
>
> The patch a228f7a41029: "Bluetooth: hci_qca: Enable WBS support for
> wcn3991" from May 14, 2020, leads to the following static checker
> warning:
>
> drivers/bluetooth/hci_qca.c:1960 qca_serdev_probe()
> error: uninitialized symbol 'hdev'.
>
> drivers/bluetooth/hci_qca.c
> 1948 }
> 1949
> 1950 if (power_ctrl_enabled) {
> 1951 hdev = qcadev->serdev_hu.hdev;
> ^^^^
> hdev is only initialized here.
>
> 1952 set_bit(HCI_QUIRK_NON_PERSISTENT_SETUP, &hdev->quirks);
> 1953 hdev->shutdown = qca_power_off;
> 1954 }
> 1955
> 1956 /* Wideband speech support must be set per driver since it can't be
> 1957 * queried via hci.
> 1958 */
> 1959 if (data && (data->capabilities & QCA_CAP_WIDEBAND_SPEECH))
> 1960 set_bit(HCI_QUIRK_WIDEBAND_SPEECH_SUPPORTED, &hdev->quirks);
> ^^^^
> Potentially uninitialized here.
>
> 1961
> 1962 return 0;
> 1963 }
>
> regards,
> dan carpenter
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-05-20 16:23 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-20 12:05 [bug report] Bluetooth: hci_qca: Enable WBS support for wcn3991 Dan Carpenter
2020-05-20 16:23 ` Abhishek Pandit-Subedi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).