* [Bluez PATCH v2] audio/avrcp: Fix media player passthrough bitmask
@ 2020-05-28 6:46 Archie Pusaka
2020-05-28 16:03 ` Luiz Augusto von Dentz
0 siblings, 1 reply; 2+ messages in thread
From: Archie Pusaka @ 2020-05-28 6:46 UTC (permalink / raw)
To: linux-bluetooth, Luiz Augusto von Dentz; +Cc: Michael Sun, Archie Pusaka
From: Archie Pusaka <apusaka@chromium.org>
Adjust the values of the passthrough bitmask with the declared
keys in avctp.c:key_map, according to section 6.10.2.1 of the
AVRCP specification.
---
Changes in v2:
- Fix the mix-up between the first 4 and the last 4 bits of each
octet
profiles/audio/avrcp.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/profiles/audio/avrcp.c b/profiles/audio/avrcp.c
index 773ccdb60..6c529bf0c 100644
--- a/profiles/audio/avrcp.c
+++ b/profiles/audio/avrcp.c
@@ -298,8 +298,8 @@ static unsigned int avctp_id = 0;
/* Default feature bit mask for media player as per avctp.c:key_map */
static const uint8_t features[16] = {
- 0xF8, 0xBF, 0xFF, 0xBF, 0x1F,
- 0xFB, 0x3F, 0x60, 0x00, 0x00,
+ 0x1F, 0xFA, 0xFF, 0xBB, 0xF3,
+ 0xBF, 0xF9, 0x06, 0x00, 0x00,
0x00, 0x00, 0x00, 0x00, 0x00,
0x00 };
--
2.27.0.rc2.251.g90737beb825-goog
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Bluez PATCH v2] audio/avrcp: Fix media player passthrough bitmask
2020-05-28 6:46 [Bluez PATCH v2] audio/avrcp: Fix media player passthrough bitmask Archie Pusaka
@ 2020-05-28 16:03 ` Luiz Augusto von Dentz
0 siblings, 0 replies; 2+ messages in thread
From: Luiz Augusto von Dentz @ 2020-05-28 16:03 UTC (permalink / raw)
To: Archie Pusaka; +Cc: linux-bluetooth, Michael Sun, Archie Pusaka
Hi Archie,
On Wed, May 27, 2020 at 11:46 PM Archie Pusaka <apusaka@google.com> wrote:
>
> From: Archie Pusaka <apusaka@chromium.org>
>
> Adjust the values of the passthrough bitmask with the declared
> keys in avctp.c:key_map, according to section 6.10.2.1 of the
> AVRCP specification.
> ---
>
> Changes in v2:
> - Fix the mix-up between the first 4 and the last 4 bits of each
> octet
>
> profiles/audio/avrcp.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/profiles/audio/avrcp.c b/profiles/audio/avrcp.c
> index 773ccdb60..6c529bf0c 100644
> --- a/profiles/audio/avrcp.c
> +++ b/profiles/audio/avrcp.c
> @@ -298,8 +298,8 @@ static unsigned int avctp_id = 0;
>
> /* Default feature bit mask for media player as per avctp.c:key_map */
> static const uint8_t features[16] = {
> - 0xF8, 0xBF, 0xFF, 0xBF, 0x1F,
> - 0xFB, 0x3F, 0x60, 0x00, 0x00,
> + 0x1F, 0xFA, 0xFF, 0xBB, 0xF3,
> + 0xBF, 0xF9, 0x06, 0x00, 0x00,
> 0x00, 0x00, 0x00, 0x00, 0x00,
> 0x00 };
>
> --
> 2.27.0.rc2.251.g90737beb825-goog
Perhaps we should add a translation table so when we update the
key_map we automatically update the features as well otherwise we
always risk having these out of sync.
--
Luiz Augusto von Dentz
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-05-28 16:03 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-28 6:46 [Bluez PATCH v2] audio/avrcp: Fix media player passthrough bitmask Archie Pusaka
2020-05-28 16:03 ` Luiz Augusto von Dentz
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).