From: Qu Wenruo <quwenruo.btrfs@gmx.com>
To: David Sterba <dsterba@suse.com>, linux-btrfs@vger.kernel.org
Subject: Re: [PATCH 3/9] btrfs: switch BTRFS_FS_* to enums
Date: Wed, 28 Nov 2018 09:21:51 +0800 [thread overview]
Message-ID: <11534862-4765-b0c8-9e84-84c1c70a5697@gmx.com> (raw)
In-Reply-To: <9ff441008db0d0bb2780cb94830c66fa65c78f60.1543348078.git.dsterba@suse.com>
[-- Attachment #1.1: Type: text/plain, Size: 2861 bytes --]
On 2018/11/28 上午3:53, David Sterba wrote:
> We can use simple enum for values that are not part of on-disk format:
> internal filesystem states.
>
> Signed-off-by: David Sterba <dsterba@suse.com>
Reviewed-by: Qu Wenruo <wqu@suse.com>
Thanks,
Qu
> ---
> fs/btrfs/ctree.h | 63 ++++++++++++++++++++++++------------------------
> 1 file changed, 31 insertions(+), 32 deletions(-)
>
> diff --git a/fs/btrfs/ctree.h b/fs/btrfs/ctree.h
> index 40c405d74a01..7176b95b40e7 100644
> --- a/fs/btrfs/ctree.h
> +++ b/fs/btrfs/ctree.h
> @@ -757,38 +757,37 @@ struct btrfs_swapfile_pin {
>
> bool btrfs_pinned_by_swapfile(struct btrfs_fs_info *fs_info, void *ptr);
>
> -#define BTRFS_FS_BARRIER 1
> -#define BTRFS_FS_CLOSING_START 2
> -#define BTRFS_FS_CLOSING_DONE 3
> -#define BTRFS_FS_LOG_RECOVERING 4
> -#define BTRFS_FS_OPEN 5
> -#define BTRFS_FS_QUOTA_ENABLED 6
> -#define BTRFS_FS_UPDATE_UUID_TREE_GEN 9
> -#define BTRFS_FS_CREATING_FREE_SPACE_TREE 10
> -#define BTRFS_FS_BTREE_ERR 11
> -#define BTRFS_FS_LOG1_ERR 12
> -#define BTRFS_FS_LOG2_ERR 13
> -#define BTRFS_FS_QUOTA_OVERRIDE 14
> -/* Used to record internally whether fs has been frozen */
> -#define BTRFS_FS_FROZEN 15
> -
> -/*
> - * Indicate that a whole-filesystem exclusive operation is running
> - * (device replace, resize, device add/delete, balance)
> - */
> -#define BTRFS_FS_EXCL_OP 16
> -
> -/*
> - * To info transaction_kthread we need an immediate commit so it doesn't
> - * need to wait for commit_interval
> - */
> -#define BTRFS_FS_NEED_ASYNC_COMMIT 17
> -
> -/*
> - * Indicate that balance has been set up from the ioctl and is in the main
> - * phase. The fs_info::balance_ctl is initialized.
> - */
> -#define BTRFS_FS_BALANCE_RUNNING 18
> +enum {
> + BTRFS_FS_BARRIER,
> + BTRFS_FS_CLOSING_START,
> + BTRFS_FS_CLOSING_DONE,
> + BTRFS_FS_LOG_RECOVERING,
> + BTRFS_FS_OPEN,
> + BTRFS_FS_QUOTA_ENABLED,
> + BTRFS_FS_UPDATE_UUID_TREE_GEN,
> + BTRFS_FS_CREATING_FREE_SPACE_TREE,
> + BTRFS_FS_BTREE_ERR,
> + BTRFS_FS_LOG1_ERR,
> + BTRFS_FS_LOG2_ERR,
> + BTRFS_FS_QUOTA_OVERRIDE,
> + /* Used to record internally whether fs has been frozen */
> + BTRFS_FS_FROZEN,
> + /*
> + * Indicate that a whole-filesystem exclusive operation is running
> + * (device replace, resize, device add/delete, balance)
> + */
> + BTRFS_FS_EXCL_OP,
> + /*
> + * To info transaction_kthread we need an immediate commit so it
> + * doesn't need to wait for commit_interval
> + */
> + BTRFS_FS_NEED_ASYNC_COMMIT,
> + /*
> + * Indicate that balance has been set up from the ioctl and is in the
> + * main phase. The fs_info::balance_ctl is initialized.
> + */
> + BTRFS_FS_BALANCE_RUNNING,
> +};
>
> struct btrfs_fs_info {
> u8 chunk_tree_uuid[BTRFS_UUID_SIZE];
>
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2018-11-28 1:22 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-27 19:53 [PATCH 0/9] Switch defines to enums David Sterba
2018-11-27 19:53 ` [PATCH 1/9] btrfs: switch BTRFS_FS_STATE_* " David Sterba
2018-11-28 0:24 ` Omar Sandoval
2018-11-28 15:22 ` David Sterba
2018-11-28 1:18 ` Qu Wenruo
2018-11-28 12:49 ` Johannes Thumshirn
2018-11-27 19:53 ` [PATCH 2/9] btrfs: switch BTRFS_BLOCK_RSV_* " David Sterba
2018-11-28 0:25 ` Omar Sandoval
2018-11-28 1:19 ` Qu Wenruo
2018-11-28 12:50 ` Johannes Thumshirn
2018-11-27 19:53 ` [PATCH 3/9] btrfs: switch BTRFS_FS_* " David Sterba
2018-11-28 0:28 ` Omar Sandoval
2018-11-28 1:21 ` Qu Wenruo [this message]
2018-11-27 19:53 ` [PATCH 4/9] btrfs: switch BTRFS_ROOT_* " David Sterba
2018-11-28 0:30 ` Omar Sandoval
2018-11-28 1:22 ` Qu Wenruo
2018-11-28 13:17 ` Johannes Thumshirn
2018-11-27 19:53 ` [PATCH 5/9] btrfs: swtich EXTENT_BUFFER_* " David Sterba
2018-11-28 0:31 ` Omar Sandoval
2018-11-28 1:24 ` Qu Wenruo
2018-11-28 13:19 ` Johannes Thumshirn
2018-11-27 19:53 ` [PATCH 6/9] btrfs: switch EXTENT_FLAG_* " David Sterba
2018-11-28 0:32 ` Omar Sandoval
2018-11-28 1:25 ` Qu Wenruo
2018-11-28 13:26 ` Johannes Thumshirn
2018-11-27 19:53 ` [PATCH 7/9] btrfs: switch BTRFS_*_LOCK " David Sterba
2018-11-28 0:37 ` Omar Sandoval
2018-11-28 13:22 ` David Sterba
2018-11-28 1:26 ` Qu Wenruo
2018-11-27 19:53 ` [PATCH 8/9] btrfs: switch BTRFS_ORDERED_* " David Sterba
2018-11-28 0:37 ` Omar Sandoval
2018-11-28 1:32 ` Qu Wenruo
2018-11-28 13:28 ` Johannes Thumshirn
2018-11-27 19:53 ` [PATCH 9/9] btrfs: drop extra enum initialization where using defaults David Sterba
2018-11-28 0:38 ` Omar Sandoval
2018-11-28 1:35 ` Qu Wenruo
2018-11-28 13:29 ` Johannes Thumshirn
2018-11-28 1:33 ` [PATCH 0/9] Switch defines to enums Qu Wenruo
2018-11-28 13:25 ` David Sterba
2018-11-28 13:50 ` Qu Wenruo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=11534862-4765-b0c8-9e84-84c1c70a5697@gmx.com \
--to=quwenruo.btrfs@gmx.com \
--cc=dsterba@suse.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).