From: Qu Wenruo <quwenruo.btrfs@gmx.com>
To: David Sterba <dsterba@suse.com>, linux-btrfs@vger.kernel.org
Subject: Re: [PATCH 7/9] btrfs: switch BTRFS_*_LOCK to enums
Date: Wed, 28 Nov 2018 09:26:03 +0800 [thread overview]
Message-ID: <896fd455-f4af-9f18-f60d-538e9ee040ca@gmx.com> (raw)
In-Reply-To: <5293feb9eb97fdaaa34db024ead13c5ec19234e3.1543348078.git.dsterba@suse.com>
[-- Attachment #1.1: Type: text/plain, Size: 979 bytes --]
On 2018/11/28 上午3:53, David Sterba wrote:
> We can use simple enum for values that are not part of on-disk format:
> tree lock types.
>
> Signed-off-by: David Sterba <dsterba@suse.com>
Reviewed-by: Qu Wenruo <wqu@suse.com>
Thanks,
Qu
> ---
> fs/btrfs/locking.h | 10 ++++++----
> 1 file changed, 6 insertions(+), 4 deletions(-)
>
> diff --git a/fs/btrfs/locking.h b/fs/btrfs/locking.h
> index 29135def468e..684d0ef4faa4 100644
> --- a/fs/btrfs/locking.h
> +++ b/fs/btrfs/locking.h
> @@ -6,10 +6,12 @@
> #ifndef BTRFS_LOCKING_H
> #define BTRFS_LOCKING_H
>
> -#define BTRFS_WRITE_LOCK 1
> -#define BTRFS_READ_LOCK 2
> -#define BTRFS_WRITE_LOCK_BLOCKING 3
> -#define BTRFS_READ_LOCK_BLOCKING 4
> +enum {
> + BTRFS_WRITE_LOCK,
> + BTRFS_READ_LOCK,
> + BTRFS_WRITE_LOCK_BLOCKING,
> + BTRFS_READ_LOCK_BLOCKING,
> +};
>
> void btrfs_tree_lock(struct extent_buffer *eb);
> void btrfs_tree_unlock(struct extent_buffer *eb);
>
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2018-11-28 1:26 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-27 19:53 [PATCH 0/9] Switch defines to enums David Sterba
2018-11-27 19:53 ` [PATCH 1/9] btrfs: switch BTRFS_FS_STATE_* " David Sterba
2018-11-28 0:24 ` Omar Sandoval
2018-11-28 15:22 ` David Sterba
2018-11-28 1:18 ` Qu Wenruo
2018-11-28 12:49 ` Johannes Thumshirn
2018-11-27 19:53 ` [PATCH 2/9] btrfs: switch BTRFS_BLOCK_RSV_* " David Sterba
2018-11-28 0:25 ` Omar Sandoval
2018-11-28 1:19 ` Qu Wenruo
2018-11-28 12:50 ` Johannes Thumshirn
2018-11-27 19:53 ` [PATCH 3/9] btrfs: switch BTRFS_FS_* " David Sterba
2018-11-28 0:28 ` Omar Sandoval
2018-11-28 1:21 ` Qu Wenruo
2018-11-27 19:53 ` [PATCH 4/9] btrfs: switch BTRFS_ROOT_* " David Sterba
2018-11-28 0:30 ` Omar Sandoval
2018-11-28 1:22 ` Qu Wenruo
2018-11-28 13:17 ` Johannes Thumshirn
2018-11-27 19:53 ` [PATCH 5/9] btrfs: swtich EXTENT_BUFFER_* " David Sterba
2018-11-28 0:31 ` Omar Sandoval
2018-11-28 1:24 ` Qu Wenruo
2018-11-28 13:19 ` Johannes Thumshirn
2018-11-27 19:53 ` [PATCH 6/9] btrfs: switch EXTENT_FLAG_* " David Sterba
2018-11-28 0:32 ` Omar Sandoval
2018-11-28 1:25 ` Qu Wenruo
2018-11-28 13:26 ` Johannes Thumshirn
2018-11-27 19:53 ` [PATCH 7/9] btrfs: switch BTRFS_*_LOCK " David Sterba
2018-11-28 0:37 ` Omar Sandoval
2018-11-28 13:22 ` David Sterba
2018-11-28 1:26 ` Qu Wenruo [this message]
2018-11-27 19:53 ` [PATCH 8/9] btrfs: switch BTRFS_ORDERED_* " David Sterba
2018-11-28 0:37 ` Omar Sandoval
2018-11-28 1:32 ` Qu Wenruo
2018-11-28 13:28 ` Johannes Thumshirn
2018-11-27 19:53 ` [PATCH 9/9] btrfs: drop extra enum initialization where using defaults David Sterba
2018-11-28 0:38 ` Omar Sandoval
2018-11-28 1:35 ` Qu Wenruo
2018-11-28 13:29 ` Johannes Thumshirn
2018-11-28 1:33 ` [PATCH 0/9] Switch defines to enums Qu Wenruo
2018-11-28 13:25 ` David Sterba
2018-11-28 13:50 ` Qu Wenruo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=896fd455-f4af-9f18-f60d-538e9ee040ca@gmx.com \
--to=quwenruo.btrfs@gmx.com \
--cc=dsterba@suse.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).