From: David Sterba <dsterba@suse.com>
To: linux-btrfs@vger.kernel.org
Cc: David Sterba <dsterba@suse.com>
Subject: [PATCH 0/9] Switch defines to enums
Date: Tue, 27 Nov 2018 20:53:38 +0100 [thread overview]
Message-ID: <cover.1543348078.git.dsterba@suse.com> (raw)
This is motivated by a merging mistake that happened a few releases ago.
Two patches updated BTRFS_FS_* flags independently to the same value,
git did not see any direct merge conflict. The two values got mixed at
runtime and caused crash.
Update all #define sequential values, the above merging problem would
not happen as there would be a conflict and the enum value
auto-increment would prevent duplicated values anyway.
David Sterba (9):
btrfs: switch BTRFS_FS_STATE_* to enums
btrfs: switch BTRFS_BLOCK_RSV_* to enums
btrfs: switch BTRFS_FS_* to enums
btrfs: switch BTRFS_ROOT_* to enums
btrfs: swtich EXTENT_BUFFER_* to enums
btrfs: switch EXTENT_FLAG_* to enums
btrfs: switch BTRFS_*_LOCK to enums
btrfs: switch BTRFS_ORDERED_* to enums
btrfs: drop extra enum initialization where using defaults
fs/btrfs/btrfs_inode.h | 2 +-
fs/btrfs/ctree.h | 168 ++++++++++++++++++++++------------------
fs/btrfs/disk-io.h | 10 +--
fs/btrfs/extent_io.h | 28 ++++---
fs/btrfs/extent_map.h | 21 +++--
fs/btrfs/locking.h | 10 ++-
fs/btrfs/ordered-data.h | 45 ++++++-----
fs/btrfs/qgroup.h | 2 +-
fs/btrfs/sysfs.h | 2 +-
fs/btrfs/transaction.h | 14 ++--
10 files changed, 169 insertions(+), 133 deletions(-)
--
2.19.1
next reply other threads:[~2018-11-27 19:53 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-27 19:53 David Sterba [this message]
2018-11-27 19:53 ` [PATCH 1/9] btrfs: switch BTRFS_FS_STATE_* to enums David Sterba
2018-11-28 0:24 ` Omar Sandoval
2018-11-28 15:22 ` David Sterba
2018-11-28 1:18 ` Qu Wenruo
2018-11-28 12:49 ` Johannes Thumshirn
2018-11-27 19:53 ` [PATCH 2/9] btrfs: switch BTRFS_BLOCK_RSV_* " David Sterba
2018-11-28 0:25 ` Omar Sandoval
2018-11-28 1:19 ` Qu Wenruo
2018-11-28 12:50 ` Johannes Thumshirn
2018-11-27 19:53 ` [PATCH 3/9] btrfs: switch BTRFS_FS_* " David Sterba
2018-11-28 0:28 ` Omar Sandoval
2018-11-28 1:21 ` Qu Wenruo
2018-11-27 19:53 ` [PATCH 4/9] btrfs: switch BTRFS_ROOT_* " David Sterba
2018-11-28 0:30 ` Omar Sandoval
2018-11-28 1:22 ` Qu Wenruo
2018-11-28 13:17 ` Johannes Thumshirn
2018-11-27 19:53 ` [PATCH 5/9] btrfs: swtich EXTENT_BUFFER_* " David Sterba
2018-11-28 0:31 ` Omar Sandoval
2018-11-28 1:24 ` Qu Wenruo
2018-11-28 13:19 ` Johannes Thumshirn
2018-11-27 19:53 ` [PATCH 6/9] btrfs: switch EXTENT_FLAG_* " David Sterba
2018-11-28 0:32 ` Omar Sandoval
2018-11-28 1:25 ` Qu Wenruo
2018-11-28 13:26 ` Johannes Thumshirn
2018-11-27 19:53 ` [PATCH 7/9] btrfs: switch BTRFS_*_LOCK " David Sterba
2018-11-28 0:37 ` Omar Sandoval
2018-11-28 13:22 ` David Sterba
2018-11-28 1:26 ` Qu Wenruo
2018-11-27 19:53 ` [PATCH 8/9] btrfs: switch BTRFS_ORDERED_* " David Sterba
2018-11-28 0:37 ` Omar Sandoval
2018-11-28 1:32 ` Qu Wenruo
2018-11-28 13:28 ` Johannes Thumshirn
2018-11-27 19:53 ` [PATCH 9/9] btrfs: drop extra enum initialization where using defaults David Sterba
2018-11-28 0:38 ` Omar Sandoval
2018-11-28 1:35 ` Qu Wenruo
2018-11-28 13:29 ` Johannes Thumshirn
2018-11-28 1:33 ` [PATCH 0/9] Switch defines to enums Qu Wenruo
2018-11-28 13:25 ` David Sterba
2018-11-28 13:50 ` Qu Wenruo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1543348078.git.dsterba@suse.com \
--to=dsterba@suse.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).