From: Omar Sandoval <osandov@osandov.com>
To: David Sterba <dsterba@suse.com>
Cc: linux-btrfs@vger.kernel.org
Subject: Re: [PATCH 2/4] btrfs: tests: move testing members of struct btrfs_root to the end
Date: Mon, 10 Sep 2018 16:37:36 -0700 [thread overview]
Message-ID: <20180910233736.GA16436@vader> (raw)
In-Reply-To: <f8b15d6ea41fc91c7e8608352cd242722c4c1b3b.1536599879.git.dsterba@suse.com>
On Mon, Sep 10, 2018 at 07:22:26PM +0200, David Sterba wrote:
> The data used only for tests are better placed at the end of the
> structure so that they don't change the structure layout. All new
> members of btrfs_root should be placed before.
Reviewed-by: Omar Sandoval <osandov@fb.com>
> Signed-off-by: David Sterba <dsterba@suse.com>
> ---
> fs/btrfs/ctree.h | 9 ++++-----
> 1 file changed, 4 insertions(+), 5 deletions(-)
>
> diff --git a/fs/btrfs/ctree.h b/fs/btrfs/ctree.h
> index 45b7029d0f23..ee05857cc8ac 100644
> --- a/fs/btrfs/ctree.h
> +++ b/fs/btrfs/ctree.h
> @@ -1203,11 +1203,6 @@ struct btrfs_root {
>
> u64 highest_objectid;
>
> -#ifdef CONFIG_BTRFS_FS_RUN_SANITY_TESTS
> - /* only used with CONFIG_BTRFS_FS_RUN_SANITY_TESTS is enabled */
> - u64 alloc_bytenr;
> -#endif
> -
> u64 defrag_trans_start;
> struct btrfs_key defrag_progress;
> struct btrfs_key defrag_max;
> @@ -1280,6 +1275,10 @@ struct btrfs_root {
> spinlock_t qgroup_meta_rsv_lock;
> u64 qgroup_meta_rsv_pertrans;
> u64 qgroup_meta_rsv_prealloc;
> +
> +#ifdef CONFIG_BTRFS_FS_RUN_SANITY_TESTS
> + u64 alloc_bytenr;
> +#endif
> };
>
> struct btrfs_file_private {
> --
> 2.18.0
>
next prev parent reply other threads:[~2018-09-11 4:34 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-10 17:22 [PATCH 0/4] Self-test cleanups David Sterba
2018-09-10 17:22 ` [PATCH 1/4] btrfs: tests: add separate stub for find_lock_delalloc_range David Sterba
2018-09-10 23:40 ` Omar Sandoval
2018-09-11 8:50 ` David Sterba
2018-09-14 16:38 ` [PATCH 1/4 v2] " David Sterba
2018-09-17 17:43 ` Omar Sandoval
2018-09-10 17:22 ` [PATCH 2/4] btrfs: tests: move testing members of struct btrfs_root to the end David Sterba
2018-09-10 23:37 ` Omar Sandoval [this message]
2018-09-10 17:22 ` [PATCH 3/4] btrfs: tests: group declarations of self-test helpers David Sterba
2018-09-10 23:41 ` Omar Sandoval
2018-09-10 17:22 ` [PATCH 4/4] btrfs: tests: polish ifdefs around testing helper David Sterba
2018-09-10 23:43 ` Omar Sandoval
2018-09-11 9:22 ` David Sterba
2018-09-11 19:14 ` Omar Sandoval
2018-09-14 14:20 ` David Sterba
2018-09-14 16:42 ` [PATCH 4/4 v2] " David Sterba
2018-09-17 17:40 ` Omar Sandoval
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180910233736.GA16436@vader \
--to=osandov@osandov.com \
--cc=dsterba@suse.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).