From: Omar Sandoval <osandov@osandov.com>
To: David Sterba <dsterba@suse.com>
Cc: linux-btrfs@vger.kernel.org
Subject: Re: [PATCH 3/4] btrfs: tests: group declarations of self-test helpers
Date: Mon, 10 Sep 2018 16:41:14 -0700 [thread overview]
Message-ID: <20180910234114.GC16436@vader> (raw)
In-Reply-To: <f97be987031016b1f48e819261aa69db2c609647.1536599879.git.dsterba@suse.com>
On Mon, Sep 10, 2018 at 07:22:29PM +0200, David Sterba wrote:
Reviewed-by: Omar Sandoval <osandov@fb.com>
> Signed-off-by: David Sterba <dsterba@suse.com>
> ---
> fs/btrfs/ctree.h | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/fs/btrfs/ctree.h b/fs/btrfs/ctree.h
> index ee05857cc8ac..32d2fce4ac53 100644
> --- a/fs/btrfs/ctree.h
> +++ b/fs/btrfs/ctree.h
> @@ -3194,9 +3194,6 @@ int btrfs_prealloc_file_range_trans(struct inode *inode,
> u64 start, u64 num_bytes, u64 min_size,
> loff_t actual_len, u64 *alloc_hint);
> extern const struct dentry_operations btrfs_dentry_operations;
> -#ifdef CONFIG_BTRFS_FS_RUN_SANITY_TESTS
> -void btrfs_test_inode_set_ops(struct inode *inode);
> -#endif
>
> /* ioctl.c */
> long btrfs_ioctl(struct file *file, unsigned int cmd, unsigned long arg);
> @@ -3709,6 +3706,7 @@ static inline int btrfs_defrag_cancelled(struct btrfs_fs_info *fs_info)
>
> /* Sanity test specific functions */
> #ifdef CONFIG_BTRFS_FS_RUN_SANITY_TESTS
> +void btrfs_test_inode_set_ops(struct inode *inode);
> void btrfs_test_destroy_inode(struct inode *inode);
> #endif
>
> --
> 2.18.0
>
next prev parent reply other threads:[~2018-09-11 4:37 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-10 17:22 [PATCH 0/4] Self-test cleanups David Sterba
2018-09-10 17:22 ` [PATCH 1/4] btrfs: tests: add separate stub for find_lock_delalloc_range David Sterba
2018-09-10 23:40 ` Omar Sandoval
2018-09-11 8:50 ` David Sterba
2018-09-14 16:38 ` [PATCH 1/4 v2] " David Sterba
2018-09-17 17:43 ` Omar Sandoval
2018-09-10 17:22 ` [PATCH 2/4] btrfs: tests: move testing members of struct btrfs_root to the end David Sterba
2018-09-10 23:37 ` Omar Sandoval
2018-09-10 17:22 ` [PATCH 3/4] btrfs: tests: group declarations of self-test helpers David Sterba
2018-09-10 23:41 ` Omar Sandoval [this message]
2018-09-10 17:22 ` [PATCH 4/4] btrfs: tests: polish ifdefs around testing helper David Sterba
2018-09-10 23:43 ` Omar Sandoval
2018-09-11 9:22 ` David Sterba
2018-09-11 19:14 ` Omar Sandoval
2018-09-14 14:20 ` David Sterba
2018-09-14 16:42 ` [PATCH 4/4 v2] " David Sterba
2018-09-17 17:40 ` Omar Sandoval
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180910234114.GC16436@vader \
--to=osandov@osandov.com \
--cc=dsterba@suse.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).