[PATCH v2,RESEND] btrfs: fix the duplicated definition of 'inode_item_err'

[PATCH v2,RESEND] btrfs: fix the duplicated definition of 'inode_item_err'

[Zheng Wei]

remove the duplicated definition of 'inode_item_err'
in the file tree-checker.c

Signed-off-by: Zheng Wei <wei.zheng@vivo.com>
---

changelog
v1 -> v2
 - resend for the failure of delivery to some recipients.

 fs/btrfs/tree-checker.c | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/fs/btrfs/tree-checker.c b/fs/btrfs/tree-checker.c
index a92f8a6dd192..517b44300a05 100644
--- a/fs/btrfs/tree-checker.c
+++ b/fs/btrfs/tree-checker.c
@@ -957,10 +957,6 @@ static int check_dev_item(struct extent_buffer *leaf,
 	return 0;
 }
 
-/* Inode item error output has the same format as dir_item_err() */
-#define inode_item_err(eb, slot, fmt, ...)			\
-	dir_item_err(eb, slot, fmt, __VA_ARGS__)
-
 static int check_inode_item(struct extent_buffer *leaf,
 			    struct btrfs_key *key, int slot)
 {
-- 
2.17.1

Re: [PATCH v2,RESEND] btrfs: fix the duplicated definition of 'inode_item_err'

[Greg Kroah-Hartman]

On Mon, Mar 16, 2020 at 11:45:57AM +0800, Zheng Wei wrote:
> remove the duplicated definition of 'inode_item_err'
> in the file tree-checker.c
> 
> Signed-off-by: Zheng Wei <wei.zheng@vivo.com>
> ---
> 
> changelog
> v1 -> v2
>  - resend for the failure of delivery to some recipients.
> 
>  fs/btrfs/tree-checker.c | 4 ----
>  1 file changed, 4 deletions(-)

Your choice of people to send this patch to is very odd:

$ ./scripts/get_maintainer.pl --file fs/btrfs/tree-checker.c
Chris Mason <clm@fb.com> (maintainer:BTRFS FILE SYSTEM)
Josef Bacik <josef@toxicpanda.com> (maintainer:BTRFS FILE SYSTEM)
David Sterba <dsterba@suse.com> (maintainer:BTRFS FILE SYSTEM)
linux-btrfs@vger.kernel.org (open list:BTRFS FILE SYSTEM)
linux-kernel@vger.kernel.org (open list)


Please be more mindful.

thanks,

greg k-h

Re: [PATCH v2,RESEND] btrfs: fix the duplicated definition of 'inode_item_err'

[郑伟]

From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Date: 2020-03-16 16:20:21
To:  Zheng Wei <wei.zheng@vivo.com>
Cc:  Catalin Marinas <catalin.marinas@arm.com>,Will Deacon <will@kernel.org>,Chris Mason <clm@fb.com>,Josef Bacik <josef@toxicpanda.com>,David Sterba <dsterba@suse.com>,Allison Randal <allison@lohutok.net>,Hanjun Guo <guohanjun@huawei.com>,Enrico Weigelt <info@metux.net>,Yunfeng Ye <yeyunfeng@huawei.com>,Thomas Gleixner <tglx@linutronix.de>,linux-arm-kernel@lists.infradead.org,linux-kernel@vger.kernel.org,linux-btrfs@vger.kernel.org,kernel@vivo.com,wenhu.wang@vivo.com
Subject: Re: [PATCH v2,RESEND] btrfs: fix the duplicated definition of 'inode_item_err'>On Mon, Mar 16, 2020 at 11:45:57AM +0800, Zheng Wei wrote:
>> remove the duplicated definition of 'inode_item_err'
>> in the file tree-checker.c
>> 
>> Signed-off-by: Zheng Wei <wei.zheng@vivo.com>
>> ---
>> 
>> changelog
>> v1 -> v2
>>  - resend for the failure of delivery to some recipients.
>> 
>>  fs/btrfs/tree-checker.c | 4 ----
>>  1 file changed, 4 deletions(-)
>
>Your choice of people to send this patch to is very odd:
>
>$ ./scripts/get_maintainer.pl --file fs/btrfs/tree-checker.c
>Chris Mason <clm@fb.com> (maintainer:BTRFS FILE SYSTEM)
>Josef Bacik <josef@toxicpanda.com> (maintainer:BTRFS FILE SYSTEM)
>David Sterba <dsterba@suse.com> (maintainer:BTRFS FILE SYSTEM)
>linux-btrfs@vger.kernel.org (open list:BTRFS FILE SYSTEM)
>linux-kernel@vger.kernel.org (open list)
>
so sorry for this,
as a new submitter, I used 'scripts/get_maintainer.pl my patch' command to get the mailing list.
I'll pay more attention next time.

Thanks,
Zheng Wei
>
>Please be more mindful.
>
>thanks,
>
>greg k-h

Re: [PATCH v2,RESEND] btrfs: fix the duplicated definition of 'inode_item_err'

[Nikolay Borisov]

On 16.03.20 г. 5:45 ч., Zheng Wei wrote:
> remove the duplicated definition of 'inode_item_err'
> in the file tree-checker.c
> 
> Signed-off-by: Zheng Wei <wei.zheng@vivo.com>

Reviewed-by: Nikolay Borisov <nborisov@suse.com>

> ---
> 
> changelog
> v1 -> v2
>  - resend for the failure of delivery to some recipients.
> 
>  fs/btrfs/tree-checker.c | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/fs/btrfs/tree-checker.c b/fs/btrfs/tree-checker.c
> index a92f8a6dd192..517b44300a05 100644
> --- a/fs/btrfs/tree-checker.c
> +++ b/fs/btrfs/tree-checker.c
> @@ -957,10 +957,6 @@ static int check_dev_item(struct extent_buffer *leaf,
>  	return 0;
>  }
>  
> -/* Inode item error output has the same format as dir_item_err() */
> -#define inode_item_err(eb, slot, fmt, ...)			\
> -	dir_item_err(eb, slot, fmt, __VA_ARGS__)
> -
>  static int check_inode_item(struct extent_buffer *leaf,
>  			    struct btrfs_key *key, int slot)
>  {
> 

Re: [PATCH v2,RESEND] btrfs: fix the duplicated definition of 'inode_item_err'

[David Sterba]

On Mon, Mar 16, 2020 at 11:45:57AM +0800, Zheng Wei wrote:
> remove the duplicated definition of 'inode_item_err'
> in the file tree-checker.c
> 
> Signed-off-by: Zheng Wei <wei.zheng@vivo.com>

Thanks, added to devel queue.