* [PATCH v2,RESEND] btrfs: fix the duplicated definition of 'inode_item_err'
@ 2020-03-16 3:45 Zheng Wei
2020-03-16 8:20 ` Greg Kroah-Hartman
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Zheng Wei @ 2020-03-16 3:45 UTC (permalink / raw)
To: Catalin Marinas, Will Deacon, Chris Mason, Josef Bacik,
David Sterba, Allison Randal, Greg Kroah-Hartman, Hanjun Guo,
Enrico Weigelt, Yunfeng Ye, Thomas Gleixner, linux-arm-kernel,
linux-kernel, linux-btrfs
Cc: kernel, wenhu.wang, Zheng Wei
remove the duplicated definition of 'inode_item_err'
in the file tree-checker.c
Signed-off-by: Zheng Wei <wei.zheng@vivo.com>
---
changelog
v1 -> v2
- resend for the failure of delivery to some recipients.
fs/btrfs/tree-checker.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/fs/btrfs/tree-checker.c b/fs/btrfs/tree-checker.c
index a92f8a6dd192..517b44300a05 100644
--- a/fs/btrfs/tree-checker.c
+++ b/fs/btrfs/tree-checker.c
@@ -957,10 +957,6 @@ static int check_dev_item(struct extent_buffer *leaf,
return 0;
}
-/* Inode item error output has the same format as dir_item_err() */
-#define inode_item_err(eb, slot, fmt, ...) \
- dir_item_err(eb, slot, fmt, __VA_ARGS__)
-
static int check_inode_item(struct extent_buffer *leaf,
struct btrfs_key *key, int slot)
{
--
2.17.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH v2,RESEND] btrfs: fix the duplicated definition of 'inode_item_err'
2020-03-16 3:45 [PATCH v2,RESEND] btrfs: fix the duplicated definition of 'inode_item_err' Zheng Wei
@ 2020-03-16 8:20 ` Greg Kroah-Hartman
2020-03-16 9:17 ` 郑伟
2020-03-16 8:48 ` Nikolay Borisov
2020-04-06 16:11 ` David Sterba
2 siblings, 1 reply; 5+ messages in thread
From: Greg Kroah-Hartman @ 2020-03-16 8:20 UTC (permalink / raw)
To: Zheng Wei
Cc: Catalin Marinas, Will Deacon, Chris Mason, Josef Bacik,
David Sterba, Allison Randal, Hanjun Guo, Enrico Weigelt,
Yunfeng Ye, Thomas Gleixner, linux-arm-kernel, linux-kernel,
linux-btrfs, kernel, wenhu.wang
On Mon, Mar 16, 2020 at 11:45:57AM +0800, Zheng Wei wrote:
> remove the duplicated definition of 'inode_item_err'
> in the file tree-checker.c
>
> Signed-off-by: Zheng Wei <wei.zheng@vivo.com>
> ---
>
> changelog
> v1 -> v2
> - resend for the failure of delivery to some recipients.
>
> fs/btrfs/tree-checker.c | 4 ----
> 1 file changed, 4 deletions(-)
Your choice of people to send this patch to is very odd:
$ ./scripts/get_maintainer.pl --file fs/btrfs/tree-checker.c
Chris Mason <clm@fb.com> (maintainer:BTRFS FILE SYSTEM)
Josef Bacik <josef@toxicpanda.com> (maintainer:BTRFS FILE SYSTEM)
David Sterba <dsterba@suse.com> (maintainer:BTRFS FILE SYSTEM)
linux-btrfs@vger.kernel.org (open list:BTRFS FILE SYSTEM)
linux-kernel@vger.kernel.org (open list)
Please be more mindful.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2,RESEND] btrfs: fix the duplicated definition of 'inode_item_err'
2020-03-16 3:45 [PATCH v2,RESEND] btrfs: fix the duplicated definition of 'inode_item_err' Zheng Wei
2020-03-16 8:20 ` Greg Kroah-Hartman
@ 2020-03-16 8:48 ` Nikolay Borisov
2020-04-06 16:11 ` David Sterba
2 siblings, 0 replies; 5+ messages in thread
From: Nikolay Borisov @ 2020-03-16 8:48 UTC (permalink / raw)
To: linux-btrfs
On 16.03.20 г. 5:45 ч., Zheng Wei wrote:
> remove the duplicated definition of 'inode_item_err'
> in the file tree-checker.c
>
> Signed-off-by: Zheng Wei <wei.zheng@vivo.com>
Reviewed-by: Nikolay Borisov <nborisov@suse.com>
> ---
>
> changelog
> v1 -> v2
> - resend for the failure of delivery to some recipients.
>
> fs/btrfs/tree-checker.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/fs/btrfs/tree-checker.c b/fs/btrfs/tree-checker.c
> index a92f8a6dd192..517b44300a05 100644
> --- a/fs/btrfs/tree-checker.c
> +++ b/fs/btrfs/tree-checker.c
> @@ -957,10 +957,6 @@ static int check_dev_item(struct extent_buffer *leaf,
> return 0;
> }
>
> -/* Inode item error output has the same format as dir_item_err() */
> -#define inode_item_err(eb, slot, fmt, ...) \
> - dir_item_err(eb, slot, fmt, __VA_ARGS__)
> -
> static int check_inode_item(struct extent_buffer *leaf,
> struct btrfs_key *key, int slot)
> {
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2,RESEND] btrfs: fix the duplicated definition of 'inode_item_err'
2020-03-16 8:20 ` Greg Kroah-Hartman
@ 2020-03-16 9:17 ` 郑伟
0 siblings, 0 replies; 5+ messages in thread
From: 郑伟 @ 2020-03-16 9:17 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: Catalin Marinas, Will Deacon, Chris Mason, Josef Bacik,
David Sterba, Allison Randal, Hanjun Guo, Enrico Weigelt,
Yunfeng Ye, Thomas Gleixner, linux-arm-kernel, linux-kernel,
linux-btrfs, kernel, wenhu.wang
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Date: 2020-03-16 16:20:21
To: Zheng Wei <wei.zheng@vivo.com>
Cc: Catalin Marinas <catalin.marinas@arm.com>,Will Deacon <will@kernel.org>,Chris Mason <clm@fb.com>,Josef Bacik <josef@toxicpanda.com>,David Sterba <dsterba@suse.com>,Allison Randal <allison@lohutok.net>,Hanjun Guo <guohanjun@huawei.com>,Enrico Weigelt <info@metux.net>,Yunfeng Ye <yeyunfeng@huawei.com>,Thomas Gleixner <tglx@linutronix.de>,linux-arm-kernel@lists.infradead.org,linux-kernel@vger.kernel.org,linux-btrfs@vger.kernel.org,kernel@vivo.com,wenhu.wang@vivo.com
Subject: Re: [PATCH v2,RESEND] btrfs: fix the duplicated definition of 'inode_item_err'>On Mon, Mar 16, 2020 at 11:45:57AM +0800, Zheng Wei wrote:
>> remove the duplicated definition of 'inode_item_err'
>> in the file tree-checker.c
>>
>> Signed-off-by: Zheng Wei <wei.zheng@vivo.com>
>> ---
>>
>> changelog
>> v1 -> v2
>> - resend for the failure of delivery to some recipients.
>>
>> fs/btrfs/tree-checker.c | 4 ----
>> 1 file changed, 4 deletions(-)
>
>Your choice of people to send this patch to is very odd:
>
>$ ./scripts/get_maintainer.pl --file fs/btrfs/tree-checker.c
>Chris Mason <clm@fb.com> (maintainer:BTRFS FILE SYSTEM)
>Josef Bacik <josef@toxicpanda.com> (maintainer:BTRFS FILE SYSTEM)
>David Sterba <dsterba@suse.com> (maintainer:BTRFS FILE SYSTEM)
>linux-btrfs@vger.kernel.org (open list:BTRFS FILE SYSTEM)
>linux-kernel@vger.kernel.org (open list)
>
so sorry for this,
as a new submitter, I used 'scripts/get_maintainer.pl my patch' command to get the mailing list.
I'll pay more attention next time.
Thanks,
Zheng Wei
>
>Please be more mindful.
>
>thanks,
>
>greg k-h
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2,RESEND] btrfs: fix the duplicated definition of 'inode_item_err'
2020-03-16 3:45 [PATCH v2,RESEND] btrfs: fix the duplicated definition of 'inode_item_err' Zheng Wei
2020-03-16 8:20 ` Greg Kroah-Hartman
2020-03-16 8:48 ` Nikolay Borisov
@ 2020-04-06 16:11 ` David Sterba
2 siblings, 0 replies; 5+ messages in thread
From: David Sterba @ 2020-04-06 16:11 UTC (permalink / raw)
To: Zheng Wei; +Cc: David Sterba, linux-btrfs
On Mon, Mar 16, 2020 at 11:45:57AM +0800, Zheng Wei wrote:
> remove the duplicated definition of 'inode_item_err'
> in the file tree-checker.c
>
> Signed-off-by: Zheng Wei <wei.zheng@vivo.com>
Thanks, added to devel queue.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2020-04-06 18:04 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-16 3:45 [PATCH v2,RESEND] btrfs: fix the duplicated definition of 'inode_item_err' Zheng Wei
2020-03-16 8:20 ` Greg Kroah-Hartman
2020-03-16 9:17 ` 郑伟
2020-03-16 8:48 ` Nikolay Borisov
2020-04-06 16:11 ` David Sterba
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).