* [PATCH 1/2] btrfs-progs: mkfs-tests: Set $csum so mkfs.btrfs does not fail
@ 2019-12-05 15:36 Marcos Paulo de Souza
2019-12-05 15:36 ` [PATCH 2/2] btrfs-progs: mkfs-tests: Change $dev1 to TEST_DEV Marcos Paulo de Souza
2019-12-10 8:33 ` [PATCH 1/2] btrfs-progs: mkfs-tests: Set $csum so mkfs.btrfs does not fail Nikolay Borisov
0 siblings, 2 replies; 4+ messages in thread
From: Marcos Paulo de Souza @ 2019-12-05 15:36 UTC (permalink / raw)
Cc: dsterba, linux-btrfs, Marcos Paulo de Souza
From: Marcos Paulo de Souza <mpdesouza@suse.com>
Signed-off-by: Marcos Paulo de Souza <mpdesouza@suse.com>
---
tests/mkfs-tests/020-basic-checksums-mount/test.sh | 1 +
1 file changed, 1 insertion(+)
diff --git a/tests/mkfs-tests/020-basic-checksums-mount/test.sh b/tests/mkfs-tests/020-basic-checksums-mount/test.sh
index 41ef5417..b7252786 100755
--- a/tests/mkfs-tests/020-basic-checksums-mount/test.sh
+++ b/tests/mkfs-tests/020-basic-checksums-mount/test.sh
@@ -12,6 +12,7 @@ prepare_test_dev
test_mkfs_mount_checksum()
{
+ csum=$1
run_check_stdout $SUDO_HELPER "$TOP/mkfs.btrfs" -f --csum "$csum" "$TEST_DEV" | grep -q "Checksum:.*$csum"
run_check $SUDO_HELPER "$TOP/btrfs" inspect-internal dump-super "$TEST_DEV"
run_check $SUDO_HELPER "$TOP/btrfs" check "$TEST_DEV"
--
2.23.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH 2/2] btrfs-progs: mkfs-tests: Change $dev1 to TEST_DEV
2019-12-05 15:36 [PATCH 1/2] btrfs-progs: mkfs-tests: Set $csum so mkfs.btrfs does not fail Marcos Paulo de Souza
@ 2019-12-05 15:36 ` Marcos Paulo de Souza
2019-12-10 8:34 ` Nikolay Borisov
2019-12-10 8:33 ` [PATCH 1/2] btrfs-progs: mkfs-tests: Set $csum so mkfs.btrfs does not fail Nikolay Borisov
1 sibling, 1 reply; 4+ messages in thread
From: Marcos Paulo de Souza @ 2019-12-05 15:36 UTC (permalink / raw)
Cc: dsterba, linux-btrfs, Marcos Paulo de Souza
From: Marcos Paulo de Souza <mpdesouza@suse.com>
It seems to be a typo, since $dev1 was not set, and we are dealing with
TEST_DEV and not with loop devices.
Signed-off-by: Marcos Paulo de Souza <mpdesouza@suse.com>
---
tests/mkfs-tests/020-basic-checksums-mount/test.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/mkfs-tests/020-basic-checksums-mount/test.sh b/tests/mkfs-tests/020-basic-checksums-mount/test.sh
index b7252786..42bf5fab 100755
--- a/tests/mkfs-tests/020-basic-checksums-mount/test.sh
+++ b/tests/mkfs-tests/020-basic-checksums-mount/test.sh
@@ -17,7 +17,7 @@ test_mkfs_mount_checksum()
run_check $SUDO_HELPER "$TOP/btrfs" inspect-internal dump-super "$TEST_DEV"
run_check $SUDO_HELPER "$TOP/btrfs" check "$TEST_DEV"
- run_check $SUDO_HELPER mount "$dev1" "$TEST_MNT"
+ run_check $SUDO_HELPER mount "$TEST_DEV" "$TEST_MNT"
run_check "$TOP/btrfs" filesystem df "$TEST_MNT"
run_check $SUDO_HELPER "$TOP/btrfs" filesystem usage "$TEST_MNT"
run_check $SUDO_HELPER "$TOP/btrfs" device usage "$TEST_MNT"
--
2.23.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 1/2] btrfs-progs: mkfs-tests: Set $csum so mkfs.btrfs does not fail
2019-12-05 15:36 [PATCH 1/2] btrfs-progs: mkfs-tests: Set $csum so mkfs.btrfs does not fail Marcos Paulo de Souza
2019-12-05 15:36 ` [PATCH 2/2] btrfs-progs: mkfs-tests: Change $dev1 to TEST_DEV Marcos Paulo de Souza
@ 2019-12-10 8:33 ` Nikolay Borisov
1 sibling, 0 replies; 4+ messages in thread
From: Nikolay Borisov @ 2019-12-10 8:33 UTC (permalink / raw)
To: Marcos Paulo de Souza; +Cc: dsterba, linux-btrfs, Marcos Paulo de Souza
On 5.12.19 г. 17:36 ч., Marcos Paulo de Souza wrote:
> From: Marcos Paulo de Souza <mpdesouza@suse.com>
>
> Signed-off-by: Marcos Paulo de Souza <mpdesouza@suse.com>
Reviewed-by: Nikolay Borisov <nborisov@suse.com>
> ---
> tests/mkfs-tests/020-basic-checksums-mount/test.sh | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/tests/mkfs-tests/020-basic-checksums-mount/test.sh b/tests/mkfs-tests/020-basic-checksums-mount/test.sh
> index 41ef5417..b7252786 100755
> --- a/tests/mkfs-tests/020-basic-checksums-mount/test.sh
> +++ b/tests/mkfs-tests/020-basic-checksums-mount/test.sh
> @@ -12,6 +12,7 @@ prepare_test_dev
>
> test_mkfs_mount_checksum()
> {
> + csum=$1
> run_check_stdout $SUDO_HELPER "$TOP/mkfs.btrfs" -f --csum "$csum" "$TEST_DEV" | grep -q "Checksum:.*$csum"
> run_check $SUDO_HELPER "$TOP/btrfs" inspect-internal dump-super "$TEST_DEV"
> run_check $SUDO_HELPER "$TOP/btrfs" check "$TEST_DEV"
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 2/2] btrfs-progs: mkfs-tests: Change $dev1 to TEST_DEV
2019-12-05 15:36 ` [PATCH 2/2] btrfs-progs: mkfs-tests: Change $dev1 to TEST_DEV Marcos Paulo de Souza
@ 2019-12-10 8:34 ` Nikolay Borisov
0 siblings, 0 replies; 4+ messages in thread
From: Nikolay Borisov @ 2019-12-10 8:34 UTC (permalink / raw)
To: Marcos Paulo de Souza; +Cc: dsterba, linux-btrfs, Marcos Paulo de Souza
On 5.12.19 г. 17:36 ч., Marcos Paulo de Souza wrote:
> From: Marcos Paulo de Souza <mpdesouza@suse.com>
>
> It seems to be a typo, since $dev1 was not set, and we are dealing with
> TEST_DEV and not with loop devices.
>
> Signed-off-by: Marcos Paulo de Souza <mpdesouza@suse.com>
Reviewed-by: Nikolay Borisov <nborisov@suse.com>
> ---
> tests/mkfs-tests/020-basic-checksums-mount/test.sh | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/mkfs-tests/020-basic-checksums-mount/test.sh b/tests/mkfs-tests/020-basic-checksums-mount/test.sh
> index b7252786..42bf5fab 100755
> --- a/tests/mkfs-tests/020-basic-checksums-mount/test.sh
> +++ b/tests/mkfs-tests/020-basic-checksums-mount/test.sh
> @@ -17,7 +17,7 @@ test_mkfs_mount_checksum()
> run_check $SUDO_HELPER "$TOP/btrfs" inspect-internal dump-super "$TEST_DEV"
> run_check $SUDO_HELPER "$TOP/btrfs" check "$TEST_DEV"
>
> - run_check $SUDO_HELPER mount "$dev1" "$TEST_MNT"
> + run_check $SUDO_HELPER mount "$TEST_DEV" "$TEST_MNT"
> run_check "$TOP/btrfs" filesystem df "$TEST_MNT"
> run_check $SUDO_HELPER "$TOP/btrfs" filesystem usage "$TEST_MNT"
> run_check $SUDO_HELPER "$TOP/btrfs" device usage "$TEST_MNT"
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-12-10 8:34 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-12-05 15:36 [PATCH 1/2] btrfs-progs: mkfs-tests: Set $csum so mkfs.btrfs does not fail Marcos Paulo de Souza
2019-12-05 15:36 ` [PATCH 2/2] btrfs-progs: mkfs-tests: Change $dev1 to TEST_DEV Marcos Paulo de Souza
2019-12-10 8:34 ` Nikolay Borisov
2019-12-10 8:33 ` [PATCH 1/2] btrfs-progs: mkfs-tests: Set $csum so mkfs.btrfs does not fail Nikolay Borisov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).