* [PATCH 0/2] Unused code cleanups
@ 2019-08-01 17:52 David Sterba
2019-08-01 17:53 ` [PATCH 1/2] btrfs: remove unused btrfs_device::flush_bio_sent David Sterba
2019-08-01 17:53 ` [PATCH 2/2] btrfs: remove unused key type set/get helpers David Sterba
0 siblings, 2 replies; 5+ messages in thread
From: David Sterba @ 2019-08-01 17:52 UTC (permalink / raw)
To: linux-btrfs; +Cc: David Sterba
David Sterba (2):
btrfs: remove unused btrfs_device::flush_bio_sent
btrfs: remove unused key type set/get helpers
fs/btrfs/ctree.h | 10 ----------
fs/btrfs/volumes.h | 1 -
2 files changed, 11 deletions(-)
--
2.22.0
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH 1/2] btrfs: remove unused btrfs_device::flush_bio_sent
2019-08-01 17:52 [PATCH 0/2] Unused code cleanups David Sterba
@ 2019-08-01 17:53 ` David Sterba
2019-08-02 3:38 ` Anand Jain
2019-08-01 17:53 ` [PATCH 2/2] btrfs: remove unused key type set/get helpers David Sterba
1 sibling, 1 reply; 5+ messages in thread
From: David Sterba @ 2019-08-01 17:53 UTC (permalink / raw)
To: linux-btrfs; +Cc: David Sterba
The status of flush bio is tracked as a status bit, changed in commit
1c3063b6dbfa ("btrfs: cleanup device states define
BTRFS_DEV_STATE_FLUSH_SENT"), the flush_bio_sent was forgotten.
Signed-off-by: David Sterba <dsterba@suse.com>
---
fs/btrfs/volumes.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/fs/btrfs/volumes.h b/fs/btrfs/volumes.h
index c71354fe1363..081cb734a239 100644
--- a/fs/btrfs/volumes.h
+++ b/fs/btrfs/volumes.h
@@ -82,7 +82,6 @@ struct btrfs_device {
unsigned long dev_state;
blk_status_t last_flush_error;
- int flush_bio_sent;
#ifdef __BTRFS_NEED_DEVICE_DATA_ORDERED
seqcount_t data_seqcount;
--
2.22.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH 2/2] btrfs: remove unused key type set/get helpers
2019-08-01 17:52 [PATCH 0/2] Unused code cleanups David Sterba
2019-08-01 17:53 ` [PATCH 1/2] btrfs: remove unused btrfs_device::flush_bio_sent David Sterba
@ 2019-08-01 17:53 ` David Sterba
2019-08-02 3:41 ` Anand Jain
1 sibling, 1 reply; 5+ messages in thread
From: David Sterba @ 2019-08-01 17:53 UTC (permalink / raw)
To: linux-btrfs; +Cc: David Sterba
The switch to open coded set/get has happend long time ago in
962a298f3511 ("btrfs: kill the key type accessor helpers"), remove the
stray helpers.
Signed-off-by: David Sterba <dsterba@suse.com>
---
fs/btrfs/ctree.h | 10 ----------
1 file changed, 10 deletions(-)
diff --git a/fs/btrfs/ctree.h b/fs/btrfs/ctree.h
index 1110bbd4bffb..3af3f680b5f1 100644
--- a/fs/btrfs/ctree.h
+++ b/fs/btrfs/ctree.h
@@ -2072,16 +2072,6 @@ static inline void btrfs_dir_item_key_to_cpu(const struct extent_buffer *eb,
btrfs_disk_key_to_cpu(key, &disk_key);
}
-static inline u8 btrfs_key_type(const struct btrfs_key *key)
-{
- return key->type;
-}
-
-static inline void btrfs_set_key_type(struct btrfs_key *key, u8 val)
-{
- key->type = val;
-}
-
/* struct btrfs_header */
BTRFS_SETGET_HEADER_FUNCS(header_bytenr, struct btrfs_header, bytenr, 64);
BTRFS_SETGET_HEADER_FUNCS(header_generation, struct btrfs_header,
--
2.22.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-08-02 3:41 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-08-01 17:52 [PATCH 0/2] Unused code cleanups David Sterba
2019-08-01 17:53 ` [PATCH 1/2] btrfs: remove unused btrfs_device::flush_bio_sent David Sterba
2019-08-02 3:38 ` Anand Jain
2019-08-01 17:53 ` [PATCH 2/2] btrfs: remove unused key type set/get helpers David Sterba
2019-08-02 3:41 ` Anand Jain
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).