From: "Vivek Yadav" <vivek.2311@samsung.com>
To: "'Marc Kleine-Budde'" <mkl@pengutronix.de>
Cc: <rcsekar@samsung.com>, <krzysztof.kozlowski+dt@linaro.org>,
<wg@grandegger.com>, <davem@davemloft.net>, <edumazet@google.com>,
<kuba@kernel.org>, <pabeni@redhat.com>,
<pankaj.dubey@samsung.com>, <ravi.patel@samsung.com>,
<alim.akhtar@samsung.com>, <linux-fsd@tesla.com>,
<robh+dt@kernel.org>, <linux-can@vger.kernel.org>,
<netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-samsung-soc@vger.kernel.org>, <devicetree@vger.kernel.org>,
<aswani.reddy@samsung.com>, <sriranjani.p@samsung.com>
Subject: RE: [PATCH v3 1/2] can: m_can: Move mram init to mcan device setup
Date: Thu, 24 Nov 2022 14:36:48 +0530 [thread overview]
Message-ID: <01a101d8ffe4$1797f290$46c7d7b0$@samsung.com> (raw)
In-Reply-To: <20221123224146.iic52cuhhnwqk2te@pengutronix.de>
> -----Original Message-----
> From: Marc Kleine-Budde <mkl@pengutronix.de>
> Sent: 24 November 2022 04:12
> To: Vivek Yadav <vivek.2311@samsung.com>
> Cc: rcsekar@samsung.com; krzysztof.kozlowski+dt@linaro.org;
> wg@grandegger.com; davem@davemloft.net; edumazet@google.com;
> kuba@kernel.org; pabeni@redhat.com; pankaj.dubey@samsung.com;
> ravi.patel@samsung.com; alim.akhtar@samsung.com; linux-fsd@tesla.com;
> robh+dt@kernel.org; linux-can@vger.kernel.org; netdev@vger.kernel.org;
> linux-kernel@vger.kernel.org; linux-arm-kernel@lists.infradead.org; linux-
> samsung-soc@vger.kernel.org; devicetree@vger.kernel.org;
> aswani.reddy@samsung.com; sriranjani.p@samsung.com
> Subject: Re: [PATCH v3 1/2] can: m_can: Move mram init to mcan device
> setup
>
> On 22.11.2022 16:24:54, Vivek Yadav wrote:
> > When we try to access the mcan message ram addresses, hclk is gated by
> > any other drivers or disabled, because of that probe gets failed.
> >
> > Move the mram init functionality to mcan device setup called by mcan
> > class register from mcan probe function, by that time clocks are
> > enabled.
>
> Why not call the RAM init directly from m_can_chip_config()?
>
m_can_chip_config function is called from m_can open.
Configuring RAM init every time we open the CAN instance is not needed, I think only once during the probe is enough.
If message RAM init failed then fifo Transmit and receive will fail and there will be no communication. So there is no point to "open and Configure CAN chip".
From my understanding it's better to keep RAM init inside the probe and if there is a failure happened goes to CAN probe failure.
> Marc
Thanks for reviewing the patch.
>
> --
> Pengutronix e.K. | Marc Kleine-Budde |
> Embedded Linux |
> https://protect2.fireeye.com/v1/url?k=818c3690-e0f1dc13-818dbddf-
> 74fe48600158-a08b6a4bfa0b043e&q=1&e=315ed8d1-1645-4c16-b5e7-
> 2a250ae36941&u=https%3A%2F%2Fwww.pengutronix.de%2F |
> Vertretung West/Dortmund | Phone: +49-231-2826-924 |
> Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
next prev parent reply other threads:[~2022-11-24 9:42 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20221122105017epcas5p269e97219d3ebe2eaf37fa428a7275f35@epcas5p2.samsung.com>
2022-11-22 10:54 ` [PATCH v3 0/2] can: mcan: Add MCAN support for FSD SoC Vivek Yadav
[not found] ` <CGME20221122105022epcas5p3f5db1c5790b605bac8d319fe06ad915b@epcas5p3.samsung.com>
2022-11-22 10:54 ` [PATCH v3 1/2] can: m_can: Move mram init to mcan device setup Vivek Yadav
2022-11-23 22:41 ` Marc Kleine-Budde
2022-11-24 9:06 ` Vivek Yadav [this message]
2022-11-24 14:54 ` Marc Kleine-Budde
2022-12-01 4:10 ` Vivek Yadav
2022-12-02 15:04 ` Marc Kleine-Budde
[not found] ` <CGME20221122105027epcas5p2237c5bc9ab02cf12f6e0f603c5bb90c4@epcas5p2.samsung.com>
2022-11-22 10:54 ` [PATCH v3 2/2] arm64: dts: fsd: Add MCAN device node Vivek Yadav
2022-11-23 8:38 ` Krzysztof Kozlowski
2022-12-06 8:26 ` Pankaj Dubey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='01a101d8ffe4$1797f290$46c7d7b0$@samsung.com' \
--to=vivek.2311@samsung.com \
--cc=alim.akhtar@samsung.com \
--cc=aswani.reddy@samsung.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-can@vger.kernel.org \
--cc=linux-fsd@tesla.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=mkl@pengutronix.de \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pankaj.dubey@samsung.com \
--cc=ravi.patel@samsung.com \
--cc=rcsekar@samsung.com \
--cc=robh+dt@kernel.org \
--cc=sriranjani.p@samsung.com \
--cc=wg@grandegger.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).