From: Marc Kleine-Budde <mkl@pengutronix.de>
To: Vivek Yadav <vivek.2311@samsung.com>
Cc: rcsekar@samsung.com, krzysztof.kozlowski+dt@linaro.org,
wg@grandegger.com, davem@davemloft.net, edumazet@google.com,
kuba@kernel.org, pabeni@redhat.com, pankaj.dubey@samsung.com,
ravi.patel@samsung.com, alim.akhtar@samsung.com,
linux-fsd@tesla.com, robh+dt@kernel.org,
linux-can@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org,
aswani.reddy@samsung.com, sriranjani.p@samsung.com
Subject: Re: RE: RE: [PATCH v3 1/2] can: m_can: Move mram init to mcan device setup
Date: Fri, 2 Dec 2022 16:04:39 +0100 [thread overview]
Message-ID: <20221202150439.dmt7omdck7wdjpbv@pengutronix.de> (raw)
In-Reply-To: <01f901d9053a$f138bdd0$d3aa3970$@samsung.com>
[-- Attachment #1: Type: text/plain, Size: 1931 bytes --]
On 01.12.2022 09:40:50, Vivek Yadav wrote:
> > That probably depends on you power management. If I add a regulator
> > to power the external tcan4x5x chip and power it up during open(), I
> > need to initialize the RAM.
> >
> Thanks for the clarification,
>
> There is one doubt for which I need clarity if I add ram init in
> m_can_chip_config.
>
> In the current implementation, m_can_ram_init is added in the probe
> and m_can_class_resume function.
>
> If I add the ram init function in chip_config which is getting called
> from m_can_start, then m_can_init_ram will be called two times, once
> in resume and next from m_can_start also.
As m_can_start() is called from resume, remove the direct call to
m_can_init_ram() from m_can_class_resume().
> Can we add ram init inside the m_can_open function itself? Because it
> is independent of m_can resume functionality.
See above.
mainline implementation:
m_can_class_resume()
-> m_can_init_ram()
m_can_open()
-> m_can_start()
-> m_can_chip_config()
-> ops->init
m_can_init_ram() (for tcan only)
proposed:
m_can_class_resume()
-> m_can_start()
-> m_can_chip_config()
-> m_can_init_ram()
m_can_open()
-> m_can_start()
-> m_can_chip_config()
-> m_can_init_ram()
In mainline m_can_init_ram() is called for the tcan during open(). So if
you call m_can_init_ram() from m_can_chip_config(), remove it from the
tcan's tcan4x5x_init() functions, and from m_can_class_resume() it
should only be called once for open and once for resume.
regards,
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Embedded Linux | https://www.pengutronix.de |
Vertretung West/Dortmund | Phone: +49-231-2826-924 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2022-12-02 15:05 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20221122105017epcas5p269e97219d3ebe2eaf37fa428a7275f35@epcas5p2.samsung.com>
2022-11-22 10:54 ` [PATCH v3 0/2] can: mcan: Add MCAN support for FSD SoC Vivek Yadav
[not found] ` <CGME20221122105022epcas5p3f5db1c5790b605bac8d319fe06ad915b@epcas5p3.samsung.com>
2022-11-22 10:54 ` [PATCH v3 1/2] can: m_can: Move mram init to mcan device setup Vivek Yadav
2022-11-23 22:41 ` Marc Kleine-Budde
2022-11-24 9:06 ` Vivek Yadav
2022-11-24 14:54 ` Marc Kleine-Budde
2022-12-01 4:10 ` Vivek Yadav
2022-12-02 15:04 ` Marc Kleine-Budde [this message]
[not found] ` <CGME20221122105027epcas5p2237c5bc9ab02cf12f6e0f603c5bb90c4@epcas5p2.samsung.com>
2022-11-22 10:54 ` [PATCH v3 2/2] arm64: dts: fsd: Add MCAN device node Vivek Yadav
2022-11-23 8:38 ` Krzysztof Kozlowski
2022-12-06 8:26 ` Pankaj Dubey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221202150439.dmt7omdck7wdjpbv@pengutronix.de \
--to=mkl@pengutronix.de \
--cc=alim.akhtar@samsung.com \
--cc=aswani.reddy@samsung.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-can@vger.kernel.org \
--cc=linux-fsd@tesla.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pankaj.dubey@samsung.com \
--cc=ravi.patel@samsung.com \
--cc=rcsekar@samsung.com \
--cc=robh+dt@kernel.org \
--cc=sriranjani.p@samsung.com \
--cc=vivek.2311@samsung.com \
--cc=wg@grandegger.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).