From: Marc Kleine-Budde <mkl@pengutronix.de>
To: Oliver Hartkopp <socketcan@hartkopp.net>,
dvyukov@google.com, netdev@vger.kernel.org,
linux-can@vger.kernel.org
Cc: syzkaller-bugs@googlegroups.com,
syzbot+381d06e0c8eaacb8706f@syzkaller.appspotmail.com,
syzbot+d0ddd88c9a7432f041e6@syzkaller.appspotmail.com,
syzbot+76d62d3b8162883c7d11@syzkaller.appspotmail.com
Subject: Re: [PATCH] can: remove WARN() statement from list operation sanity check
Date: Fri, 27 Nov 2020 08:28:44 +0100 [thread overview]
Message-ID: <0c10c604-ce38-3733-a442-37945ec36075@pengutronix.de> (raw)
In-Reply-To: <20201126192140.14350-1-socketcan@hartkopp.net>
[-- Attachment #1.1: Type: text/plain, Size: 1230 bytes --]
On 11/26/20 8:21 PM, Oliver Hartkopp wrote:
> To detect potential bugs in CAN protocol implementations (double removal
> of receiver entries) a WARN() statement has been used if no matching list
> item was found for removal.
>
> The fault injection issued by syzkaller was able to create a situation
> where the closing of a socket runs simultaneously to the notifier call
> chain for removing the CAN network device in use.
>
> This case is very unlikely in real life but it doesn't break anything.
> Therefore we just replace the WARN() statement with pr_warn() to
> preserve the notification for the CAN protocol development.
>
> Reported-by: syzbot+381d06e0c8eaacb8706f@syzkaller.appspotmail.com
> Reported-by: syzbot+d0ddd88c9a7432f041e6@syzkaller.appspotmail.com
> Reported-by: syzbot+76d62d3b8162883c7d11@syzkaller.appspotmail.com
> Signed-off-by: Oliver Hartkopp <socketcan@hartkopp.net>
applied to can/testing.
tnx,
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Embedded Linux | https://www.pengutronix.de |
Vertretung West/Dortmund | Phone: +49-231-2826-924 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2020-11-27 7:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-26 19:21 [PATCH] can: remove WARN() statement from list operation sanity check Oliver Hartkopp
2020-11-27 7:28 ` Marc Kleine-Budde [this message]
2020-11-27 9:48 ` Marc Kleine-Budde
2020-11-27 13:16 ` Oliver Hartkopp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0c10c604-ce38-3733-a442-37945ec36075@pengutronix.de \
--to=mkl@pengutronix.de \
--cc=dvyukov@google.com \
--cc=linux-can@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=socketcan@hartkopp.net \
--cc=syzbot+381d06e0c8eaacb8706f@syzkaller.appspotmail.com \
--cc=syzbot+76d62d3b8162883c7d11@syzkaller.appspotmail.com \
--cc=syzbot+d0ddd88c9a7432f041e6@syzkaller.appspotmail.com \
--cc=syzkaller-bugs@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).