linux-can.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Oliver Hartkopp <socketcan@hartkopp.net>
To: Marc Kleine-Budde <mkl@pengutronix.de>,
	dvyukov@google.com, netdev@vger.kernel.org,
	linux-can@vger.kernel.org
Cc: syzkaller-bugs@googlegroups.com,
	syzbot+381d06e0c8eaacb8706f@syzkaller.appspotmail.com,
	syzbot+d0ddd88c9a7432f041e6@syzkaller.appspotmail.com,
	syzbot+76d62d3b8162883c7d11@syzkaller.appspotmail.com
Subject: Re: [PATCH] can: remove WARN() statement from list operation sanity check
Date: Fri, 27 Nov 2020 14:16:01 +0100	[thread overview]
Message-ID: <6ff82b35-4dd3-43e0-f1b2-5fe30c06d04a@hartkopp.net> (raw)
In-Reply-To: <73bec80c-fb97-0808-8ca5-6579d9ff5251@pengutronix.de>

On 27.11.20 10:48, Marc Kleine-Budde wrote:

>>   	/* Check for bugs in CAN protocol implementations using af_can.c:
>>   	 * 'rcv' will be NULL if no matching list item was found for removal.
>> +	 * As this case may potentially happen when closing a socket while
>> +	 * the notifier for removing the CAN netdev is running we just print
>> +	 * a warning here. Reported by syskaller (see commit message)
> I've removed the "Reported by syskaller (see commit message)" while applying the
> patch, to keep this comment short and to the point. Use tig/git blame (or any
> other future tool) to figure out the commit message for details :D
> 

Is fine for me ;-)

Thanks Marc!

      reply	other threads:[~2020-11-27 13:16 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-26 19:21 [PATCH] can: remove WARN() statement from list operation sanity check Oliver Hartkopp
2020-11-27  7:28 ` Marc Kleine-Budde
2020-11-27  9:48 ` Marc Kleine-Budde
2020-11-27 13:16   ` Oliver Hartkopp [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6ff82b35-4dd3-43e0-f1b2-5fe30c06d04a@hartkopp.net \
    --to=socketcan@hartkopp.net \
    --cc=dvyukov@google.com \
    --cc=linux-can@vger.kernel.org \
    --cc=mkl@pengutronix.de \
    --cc=netdev@vger.kernel.org \
    --cc=syzbot+381d06e0c8eaacb8706f@syzkaller.appspotmail.com \
    --cc=syzbot+76d62d3b8162883c7d11@syzkaller.appspotmail.com \
    --cc=syzbot+d0ddd88c9a7432f041e6@syzkaller.appspotmail.com \
    --cc=syzkaller-bugs@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).