* [PATCH 1/3] janitorial: asc2log: properly close infile
@ 2015-03-06 8:17 Robert Schwebel
2015-03-06 8:17 ` [PATCH 2/3] janitorial: log2asc: properly close infile and outfile Robert Schwebel
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Robert Schwebel @ 2015-03-06 8:17 UTC (permalink / raw)
To: linux-can; +Cc: Robert Schwebel
outfile is closed as well, so do this symmetrically for infile.
Signed-off-by: Robert Schwebel <r.schwebel@pengutronix.de>
---
asc2log.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/asc2log.c b/asc2log.c
index 548fc7e..ae78a41 100644
--- a/asc2log.c
+++ b/asc2log.c
@@ -343,5 +343,6 @@ int main(int argc, char **argv)
}
}
fclose(outfile);
+ fclose(infile);
return 0;
}
--
2.1.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH 2/3] janitorial: log2asc: properly close infile and outfile
2015-03-06 8:17 [PATCH 1/3] janitorial: asc2log: properly close infile Robert Schwebel
@ 2015-03-06 8:17 ` Robert Schwebel
2015-03-06 8:17 ` [PATCH 3/3] gitignore: add isotpperf Robert Schwebel
2015-03-06 9:27 ` [PATCH 1/3] janitorial: asc2log: properly close infile Marc Kleine-Budde
2 siblings, 0 replies; 4+ messages in thread
From: Robert Schwebel @ 2015-03-06 8:17 UTC (permalink / raw)
To: linux-can; +Cc: Robert Schwebel
Signed-off-by: Robert Schwebel <r.schwebel@pengutronix.de>
---
log2asc.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/log2asc.c b/log2asc.c
index 446c0b6..29d13e8 100644
--- a/log2asc.c
+++ b/log2asc.c
@@ -198,6 +198,8 @@ int main(int argc, char **argv)
}
}
fflush(outfile);
+ fclose(outfile);
+ fclose(infile);
return 0;
}
--
2.1.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH 3/3] gitignore: add isotpperf
2015-03-06 8:17 [PATCH 1/3] janitorial: asc2log: properly close infile Robert Schwebel
2015-03-06 8:17 ` [PATCH 2/3] janitorial: log2asc: properly close infile and outfile Robert Schwebel
@ 2015-03-06 8:17 ` Robert Schwebel
2015-03-06 9:27 ` [PATCH 1/3] janitorial: asc2log: properly close infile Marc Kleine-Budde
2 siblings, 0 replies; 4+ messages in thread
From: Robert Schwebel @ 2015-03-06 8:17 UTC (permalink / raw)
To: linux-can; +Cc: Robert Schwebel
Signed-off-by: Robert Schwebel <r.schwebel@pengutronix.de>
---
.gitignore | 1 +
1 file changed, 1 insertion(+)
diff --git a/.gitignore b/.gitignore
index 746b676..b7d9cbd 100644
--- a/.gitignore
+++ b/.gitignore
@@ -34,6 +34,7 @@ GNUmakefile.in
/cansend
/cansniffer
/isotpdump
+/isotpperf
/isotprecv
/isotpsend
/isotpserver
--
2.1.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 1/3] janitorial: asc2log: properly close infile
2015-03-06 8:17 [PATCH 1/3] janitorial: asc2log: properly close infile Robert Schwebel
2015-03-06 8:17 ` [PATCH 2/3] janitorial: log2asc: properly close infile and outfile Robert Schwebel
2015-03-06 8:17 ` [PATCH 3/3] gitignore: add isotpperf Robert Schwebel
@ 2015-03-06 9:27 ` Marc Kleine-Budde
2 siblings, 0 replies; 4+ messages in thread
From: Marc Kleine-Budde @ 2015-03-06 9:27 UTC (permalink / raw)
To: Robert Schwebel, linux-can
[-- Attachment #1: Type: text/plain, Size: 506 bytes --]
On 03/06/2015 09:17 AM, Robert Schwebel wrote:
> outfile is closed as well, so do this symmetrically for infile.
>
> Signed-off-by: Robert Schwebel <r.schwebel@pengutronix.de>
Thanks, all three applied to master.
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions | Phone: +49-231-2826-924 |
Vertretung West/Dortmund | Fax: +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-03-06 9:27 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-03-06 8:17 [PATCH 1/3] janitorial: asc2log: properly close infile Robert Schwebel
2015-03-06 8:17 ` [PATCH 2/3] janitorial: log2asc: properly close infile and outfile Robert Schwebel
2015-03-06 8:17 ` [PATCH 3/3] gitignore: add isotpperf Robert Schwebel
2015-03-06 9:27 ` [PATCH 1/3] janitorial: asc2log: properly close infile Marc Kleine-Budde
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).