* [PATCH v2] can: mscan: mpc5xxx_can: Remove useless BUG_ON()
@ 2021-08-25 7:07 Tang Bin
2021-08-25 10:30 ` patchwork-bot+netdevbpf
0 siblings, 1 reply; 2+ messages in thread
From: Tang Bin @ 2021-08-25 7:07 UTC (permalink / raw)
To: mkl, wg, davem, kuba; +Cc: linux-can, netdev, linux-kernel, Tang Bin
In the function mpc5xxx_can_probe(), the variable 'data'
has already been determined in the above code, so the
BUG_ON() in this place is useless, remove it.
Signed-off-by: Tang Bin <tangbin@cmss.chinamobile.com>
---
Changes to v1
- Fix the commit message for typo
---
drivers/net/can/mscan/mpc5xxx_can.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/net/can/mscan/mpc5xxx_can.c b/drivers/net/can/mscan/mpc5xxx_can.c
index 3b7465acd..35892c1ef 100644
--- a/drivers/net/can/mscan/mpc5xxx_can.c
+++ b/drivers/net/can/mscan/mpc5xxx_can.c
@@ -317,7 +317,6 @@ static int mpc5xxx_can_probe(struct platform_device *ofdev)
clock_name = of_get_property(np, "fsl,mscan-clock-source", NULL);
- BUG_ON(!data);
priv->type = data->type;
priv->can.clock.freq = data->get_clock(ofdev, clock_name,
&mscan_clksrc);
--
2.20.1.windows.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2] can: mscan: mpc5xxx_can: Remove useless BUG_ON()
2021-08-25 7:07 [PATCH v2] can: mscan: mpc5xxx_can: Remove useless BUG_ON() Tang Bin
@ 2021-08-25 10:30 ` patchwork-bot+netdevbpf
0 siblings, 0 replies; 2+ messages in thread
From: patchwork-bot+netdevbpf @ 2021-08-25 10:30 UTC (permalink / raw)
To: Tang Bin; +Cc: mkl, wg, davem, kuba, linux-can, netdev, linux-kernel
Hello:
This patch was applied to netdev/net-next.git (refs/heads/master):
On Wed, 25 Aug 2021 15:07:52 +0800 you wrote:
> In the function mpc5xxx_can_probe(), the variable 'data'
> has already been determined in the above code, so the
> BUG_ON() in this place is useless, remove it.
>
> Signed-off-by: Tang Bin <tangbin@cmss.chinamobile.com>
> ---
> Changes to v1
> - Fix the commit message for typo
>
> [...]
Here is the summary with links:
- [v2] can: mscan: mpc5xxx_can: Remove useless BUG_ON()
https://git.kernel.org/netdev/net-next/c/cbe8cd7d83e2
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-08-25 10:30 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-25 7:07 [PATCH v2] can: mscan: mpc5xxx_can: Remove useless BUG_ON() Tang Bin
2021-08-25 10:30 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).