linux-can.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v1 0/2] isa: Make the remove callback for isa drivers return void
@ 2021-01-21 20:48 Uwe Kleine-König
  2021-01-21 20:48 ` [PATCH v1 2/2] " Uwe Kleine-König
  2021-01-22  1:03 ` [PATCH v1 0/2] " William Breathitt Gray
  0 siblings, 2 replies; 6+ messages in thread
From: Uwe Kleine-König @ 2021-01-21 20:48 UTC (permalink / raw)
  To: Wim Van Sebroeck, Guenter Roeck, William Breathitt Gray,
	Greg Kroah-Hartman, Rafael J. Wysocki, Pau Oliva Fora,
	Dmitry Torokhov, Mauro Carvalho Chehab, Wolfgang Grandegger,
	Marc Kleine-Budde, David S. Miller, Jakub Kicinski,
	Matthew Wilcox, Hannes Reinecke, James E.J. Bottomley,
	Martin K. Petersen, Finn Thain, Michael Schmitz, Jaroslav Kysela,
	Takashi Iwai
  Cc: linux-watchdog, linux-kernel, linux-i2c, linux-input,
	linux-media, linux-can, netdev, linux-scsi, alsa-devel

Hello,

as described in the commit log of the 2nd patch returning an error code
from a bus' remove callback doesn't make any difference as the driver
core ignores it and still considers the device removed.

So change the remove callback to return void to not give driver authors
an incentive to believe they could return an error.

There is only a single isa driver in the tree (assuming I didn't miss
any) that has a remove callback that can return a non zero return code.
This is "fixed" in the first patch, to make the second patch more
obviously correct.

Best regards
Uwe

Uwe Kleine-König (2):
  watchdog: pcwd: drop always-false if from remove callback
  isa: Make the remove callback for isa drivers return void

 drivers/base/isa.c                   | 2 +-
 drivers/i2c/busses/i2c-elektor.c     | 4 +---
 drivers/i2c/busses/i2c-pca-isa.c     | 4 +---
 drivers/input/touchscreen/htcpen.c   | 4 +---
 drivers/media/radio/radio-sf16fmr2.c | 4 +---
 drivers/net/can/sja1000/tscan1.c     | 4 +---
 drivers/net/ethernet/3com/3c509.c    | 3 +--
 drivers/scsi/advansys.c              | 3 +--
 drivers/scsi/aha1542.c               | 3 +--
 drivers/scsi/fdomain_isa.c           | 3 +--
 drivers/scsi/g_NCR5380.c             | 3 +--
 drivers/watchdog/pcwd.c              | 7 +------
 include/linux/isa.h                  | 2 +-
 sound/isa/ad1848/ad1848.c            | 3 +--
 sound/isa/adlib.c                    | 3 +--
 sound/isa/cmi8328.c                  | 3 +--
 sound/isa/cmi8330.c                  | 3 +--
 sound/isa/cs423x/cs4231.c            | 3 +--
 sound/isa/cs423x/cs4236.c            | 3 +--
 sound/isa/es1688/es1688.c            | 3 +--
 sound/isa/es18xx.c                   | 3 +--
 sound/isa/galaxy/galaxy.c            | 3 +--
 sound/isa/gus/gusclassic.c           | 3 +--
 sound/isa/gus/gusextreme.c           | 3 +--
 sound/isa/gus/gusmax.c               | 3 +--
 sound/isa/gus/interwave.c            | 3 +--
 sound/isa/msnd/msnd_pinnacle.c       | 3 +--
 sound/isa/opl3sa2.c                  | 3 +--
 sound/isa/opti9xx/miro.c             | 3 +--
 sound/isa/opti9xx/opti92x-ad1848.c   | 3 +--
 sound/isa/sb/jazz16.c                | 3 +--
 sound/isa/sb/sb16.c                  | 3 +--
 sound/isa/sb/sb8.c                   | 3 +--
 sound/isa/sc6000.c                   | 3 +--
 sound/isa/sscape.c                   | 3 +--
 sound/isa/wavefront/wavefront.c      | 3 +--
 36 files changed, 36 insertions(+), 79 deletions(-)


base-commit: 5a158981aafa7f29709034b17bd007b15cb29983
-- 
2.29.2

^ permalink raw reply	[flat|nested] 6+ messages in thread
end of thread, other threads:[~2021-01-22  9:25 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-21 20:48 [PATCH v1 0/2] isa: Make the remove callback for isa drivers return void Uwe Kleine-König
2021-01-21 20:48 ` [PATCH v1 2/2] " Uwe Kleine-König
2021-01-22  7:34   ` Marc Kleine-Budde
2021-01-22  8:53   ` Wolfram Sang
2021-01-22  9:01   ` Takashi Iwai
2021-01-22  1:03 ` [PATCH v1 0/2] " William Breathitt Gray

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).