From: Marc Kleine-Budde <mkl@pengutronix.de>
To: Torin Cooper-Bennun <torin@maxiluxsystems.com>
Cc: linux-rpi-kernel@lists.infradead.org, linux-can@vger.kernel.org
Subject: Re: can, tcan4x5x: look to merge rpi support into rpi kernel tree
Date: Tue, 16 Feb 2021 11:28:35 +0100 [thread overview]
Message-ID: <20210216102835.v5goqyksqsu6h6xr@hardanger.blackshift.org> (raw)
In-Reply-To: <CAALJrqiAFR7bacR3eB40OU0fbM1QOc-xnvDtts5tDh5cE+3rrw@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1650 bytes --]
On 16.02.2021 09:44:54, Torin Cooper-Bennun wrote:
> > Your mram-cfg looks broken, You don't have any TX Event FIFO entries. Please use
> > this one:
> >
> > bosch,mram-cfg = <0x0 0 0 16 0 0 1 1>;
>
> Okay, thanks for the tip, I usually don't make use of the TX event
> feature!
You might not, but the driver does :)
> This hasn't fixed the TX behaviour, though. I've verified
> that the frame is loaded into MRAM and requested for TX correctly, but
> the transceiver does this...
>
> 1. sends start-of-frame, then 5 bits of ID correctly, at the correct bitrate
> 2. bus then seems to be stuck dominant for 6 bits instead of
> transmitting further ID bits
> 3. bus lines drift back recessive (not a clean edge) over the duration
> of 12 bits
> 4. process repeats
>
> Steps 2-3 constitute an error frame, if my understanding is correct.
> Presently the TCAN4550 is not connected to any other CAN nodes; I
> would therefore expect the transmit to at least continue to the ACK
> field.
If the process repeats infinitely then the CAN controller doesn't go
into bus-off, which means the CAN bus is terminated correctly.
With your setup of only one node on the bus and correct termination, I
too think the frame should be send until the ACK field. I suggest to
first create a working CAN bus setup and then add the tcan to it.
regards,
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Embedded Linux | https://www.pengutronix.de |
Vertretung West/Dortmund | Phone: +49-231-2826-924 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2021-02-16 10:29 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <602651f9.1c69fb81.302a5.647d@mx.google.com>
[not found] ` <20210215144509.rhds7oybzat6u27w@hardanger.blackshift.org>
[not found] ` <CAALJrqgrmzGHZX+iiMYwMkVMpxtf_3fWYkVA-iMdPOxpGzrCRQ@mail.gmail.com>
2021-02-15 17:44 ` can, tcan4x5x: look to merge rpi support into rpi kernel tree Marc Kleine-Budde
2021-02-16 9:06 ` Torin Cooper-Bennun
2021-02-16 9:13 ` Marc Kleine-Budde
2021-02-16 9:44 ` Torin Cooper-Bennun
2021-02-16 10:28 ` Marc Kleine-Budde [this message]
[not found] ` <CAALJrqiVdmLQr7q2ijbWq70RD6PTD8PtVX_zmLW9=uNdc57WqA@mail.gmail.com>
2021-02-16 11:19 ` Marc Kleine-Budde
2021-02-16 11:38 ` Torin Cooper-Bennun
2021-02-16 12:32 ` Marc Kleine-Budde
2021-02-26 12:27 ` Torin Cooper-Bennun
2021-02-26 12:28 ` Marc Kleine-Budde
2021-02-26 12:18 ` Torin Cooper-Bennun
2021-02-26 12:22 ` Marc Kleine-Budde
2021-02-26 12:31 ` Torin Cooper-Bennun
2021-02-26 12:40 ` Marc Kleine-Budde
2021-02-26 13:26 ` Torin Cooper-Bennun
2021-02-26 13:39 ` Marc Kleine-Budde
2021-02-26 13:45 ` Torin Cooper-Bennun
2021-02-26 14:00 ` Marc Kleine-Budde
2021-02-26 15:26 ` Torin Cooper-Bennun
2021-02-26 16:01 ` Marc Kleine-Budde
2021-02-26 16:14 ` Torin Cooper-Bennun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210216102835.v5goqyksqsu6h6xr@hardanger.blackshift.org \
--to=mkl@pengutronix.de \
--cc=linux-can@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=torin@maxiluxsystems.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).