From: Marc Kleine-Budde <mkl@pengutronix.de>
To: Torin Cooper-Bennun <torin@maxiluxsystems.com>
Cc: linux-can@vger.kernel.org
Subject: Re: can, tcan4x5x: look to merge rpi support into rpi kernel tree
Date: Fri, 26 Feb 2021 13:22:59 +0100 [thread overview]
Message-ID: <7254df67-202f-ac23-c45c-fcb5172a70a3@pengutronix.de> (raw)
In-Reply-To: <20210226121854.4gb5yufb23hyar73@bigthink>
[-- Attachment #1.1: Type: text/plain, Size: 993 bytes --]
On 2/26/21 1:18 PM, Torin Cooper-Bennun wrote:
> Hi again. Going back to the start of our conversation:
>
> On Mon, Feb 15, 2021 at 03:45:09PM +0100, Marc Kleine-Budde wrote:
>> Sadly, the driver is still not in good shape...I think it will explode
>> as soon as you receive a CAN frame on the rpi, as the frames are passed
>> into the networking stack from the wrong context...
>>
>> Maybe I'll find some time to get receive properly working.
>
> Could you clarify what your concern is? netif_receive_skb seems to be
> used in the same way in m_can.c as in rx-offload.c.
The problem is that netif_receive_skb(skb) is called from a threaded interrupt
handler, but you should call it from NAPI.
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Embedded Linux | https://www.pengutronix.de |
Vertretung West/Dortmund | Phone: +49-231-2826-924 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2021-02-26 12:23 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <602651f9.1c69fb81.302a5.647d@mx.google.com>
[not found] ` <20210215144509.rhds7oybzat6u27w@hardanger.blackshift.org>
[not found] ` <CAALJrqgrmzGHZX+iiMYwMkVMpxtf_3fWYkVA-iMdPOxpGzrCRQ@mail.gmail.com>
2021-02-15 17:44 ` can, tcan4x5x: look to merge rpi support into rpi kernel tree Marc Kleine-Budde
2021-02-16 9:06 ` Torin Cooper-Bennun
2021-02-16 9:13 ` Marc Kleine-Budde
2021-02-16 9:44 ` Torin Cooper-Bennun
2021-02-16 10:28 ` Marc Kleine-Budde
[not found] ` <CAALJrqiVdmLQr7q2ijbWq70RD6PTD8PtVX_zmLW9=uNdc57WqA@mail.gmail.com>
2021-02-16 11:19 ` Marc Kleine-Budde
2021-02-16 11:38 ` Torin Cooper-Bennun
2021-02-16 12:32 ` Marc Kleine-Budde
2021-02-26 12:27 ` Torin Cooper-Bennun
2021-02-26 12:28 ` Marc Kleine-Budde
2021-02-26 12:18 ` Torin Cooper-Bennun
2021-02-26 12:22 ` Marc Kleine-Budde [this message]
2021-02-26 12:31 ` Torin Cooper-Bennun
2021-02-26 12:40 ` Marc Kleine-Budde
2021-02-26 13:26 ` Torin Cooper-Bennun
2021-02-26 13:39 ` Marc Kleine-Budde
2021-02-26 13:45 ` Torin Cooper-Bennun
2021-02-26 14:00 ` Marc Kleine-Budde
2021-02-26 15:26 ` Torin Cooper-Bennun
2021-02-26 16:01 ` Marc Kleine-Budde
2021-02-26 16:14 ` Torin Cooper-Bennun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7254df67-202f-ac23-c45c-fcb5172a70a3@pengutronix.de \
--to=mkl@pengutronix.de \
--cc=linux-can@vger.kernel.org \
--cc=torin@maxiluxsystems.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).