From: Marc Kleine-Budde <mkl@pengutronix.de>
To: Stephane Grosjean <s.grosjean@peak-system.com>,
linux-can Mailing List <linux-can@vger.kernel.org>
Subject: Re: [PATCH 1/3] can/peak_usb: add support of ethtool set_phys_id()
Date: Fri, 19 Mar 2021 09:35:31 +0100 [thread overview]
Message-ID: <20210319083531.qhnozidc2msjir7p@pengutronix.de> (raw)
In-Reply-To: <bf2f6330-2f28-54ba-7025-55828f916074@pengutronix.de>
[-- Attachment #1: Type: text/plain, Size: 1099 bytes --]
On 09.03.2021 13:15:27, Marc Kleine-Budde wrote:
> > diff --git a/drivers/net/can/usb/peak_usb/pcan_usb_pro.h b/drivers/net/can/usb/peak_usb/pcan_usb_pro.h
> > index 6bb12357d078..421104ee29f4 100644
> > --- a/drivers/net/can/usb/peak_usb/pcan_usb_pro.h
> > +++ b/drivers/net/can/usb/peak_usb/pcan_usb_pro.h
> > @@ -115,6 +115,12 @@ struct __packed pcan_usb_pro_devid {
> > __le32 serial_num;
> > };
> >
> > +#define FW_USBPRO_LED_DEVICE 0x00
> > +#define FW_USBPRO_LED_BLINK_FAST 0x01
> > +#define FW_USBPRO_LED_BLINK_SLOW 0x02
> > +#define FW_USBPRO_LED_ON 0x03
> > +#define FW_USBPRO_LED_OFF 0x04
>
> What about replacing the FW_ with PCAN_, so that we're using the same prefix
> within the driver? I can do this while applying.
I've replaced the FW_ with PCAN_ while applying the patch.
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Embedded Linux | https://www.pengutronix.de |
Vertretung West/Dortmund | Phone: +49-231-2826-924 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2021-03-19 8:36 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-09 8:21 [PATCH 0/3] can/peak_usb: Added improvement to the peak_usb driver Stephane Grosjean
2021-03-09 8:21 ` [PATCH 1/3] can/peak_usb: add support of ethtool set_phys_id() Stephane Grosjean
2021-03-09 11:20 ` Marc Kleine-Budde
2021-03-09 12:15 ` Marc Kleine-Budde
2021-03-19 8:35 ` Marc Kleine-Budde [this message]
2021-03-09 8:21 ` [PATCH 2/3] can/peak_usb: add forgotten supported devices Stephane Grosjean
2021-03-09 11:07 ` Marc Kleine-Budde
2021-03-09 14:22 ` Stéphane Grosjean
2021-03-09 15:27 ` Marc Kleine-Budde
2021-03-09 15:28 ` Marc Kleine-Budde
2021-03-19 8:39 ` Marc Kleine-Budde
2021-03-19 9:47 ` Vincent MAILHOL
2021-03-19 9:56 ` Marc Kleine-Budde
2021-03-19 10:07 ` Vincent MAILHOL
2021-03-19 12:00 ` Stéphane Grosjean
2021-03-09 8:21 ` [PATCH 3/3] can/peak_usb: add support of ONE_SHOT mode Stephane Grosjean
2021-03-09 10:36 ` Marc Kleine-Budde
2021-03-09 10:53 ` Oliver Hartkopp
2021-03-09 10:58 ` Marc Kleine-Budde
2021-03-19 10:01 ` Marc Kleine-Budde
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210319083531.qhnozidc2msjir7p@pengutronix.de \
--to=mkl@pengutronix.de \
--cc=linux-can@vger.kernel.org \
--cc=s.grosjean@peak-system.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).